Merge lp:~josharenson/unity8/settings_wizard_tests into lp:unity8
| Status: | Merged |
|---|---|
| Approved by: | Albert Astals Cid on 2015-07-02 |
| Approved revision: | 1792 |
| Merged at revision: | 1859 |
| Proposed branch: | lp:~josharenson/unity8/settings_wizard_tests |
| Merge into: | lp:unity8 |
| Diff against target: |
802 lines (+762/-0) 5 files modified
debian/control (+2/-0) tests/autopilot/unity8/settings_wizard/__init__.py (+507/-0) tests/autopilot/unity8/settings_wizard/fixture_setup.py (+58/-0) tests/autopilot/unity8/settings_wizard/ofono_helper.py (+116/-0) tests/autopilot/unity8/settings_wizard/tests/test_settings_wizard.py (+79/-0) |
| To merge this branch: | bzr merge lp:~josharenson/unity8/settings_wizard_tests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Albert Astals Cid (community) | xvfb is fine for testing | Approve on 2015-07-02 | |
| PS Jenkins bot | continuous-integration | Needs Fixing on 2015-06-08 | |
| Richard Huddie (community) | Approve on 2015-05-29 | ||
| Ubuntu Unity PS integration team | debian packaging | 2015-05-19 | Pending |
| Leo Arias | 2015-05-19 | Pending | |
|
Review via email:
|
|||
Commit Message
Add a basic autopilot test for the SettingsWizard
Description of the Change
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Yes
Adds ofono-phonesim and xvfb to unity8-autopilot dependencies. These will be used in a future branch, but are currently required for ofono_helper to function.
- 1784. By Josh Arenson on 2015-05-19
-
Remove debug code
- 1785. By Josh Arenson on 2015-05-19
-
Add license
- 1786. By Josh Arenson on 2015-05-20
-
Add license
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1785
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1786
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1785
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Richard Huddie (rhuddie) wrote : | # |
This looks good. I've got a question below about checking the state of the network connections to check the button state, rather than just pressing it regardless. I haven't had a chance to run it yet, but I'll give that a try later.
Thanks!
| Josh Arenson (josharenson) wrote : | # |
> This looks good. I've got a question below about checking the state of the
> network connections to check the button state, rather than just pressing it
> regardless. I haven't had a chance to run it yet, but I'll give that a try
> later.
>
> Thanks!
I agree with you, and I'll implement this tomorrow. I also am working on adding a LocationPage to the emulator and code to handle the wizard if the location page is present.
| Richard Huddie (rhuddie) wrote : | # |
Also, it would be better to remove the emulators folder and move the contents of settings_wizard.py into:
tests/autopilot
Then you can easily import the helpers in the test by doing:
from unity8.
We are trying to remove use of the word 'emulators' from the tests.
- 1787. By Josh Arenson on 2015-05-20
-
Merge upstream
- 1788. By Josh Arenson on 2015-05-21
-
[ Albert Astals Cid ]
* Add overrides to override functions
* Implement "rating-edit" preview widget (LP: #1318144)
* Make the DashContent::test_mainNavig ation test more stable (LP:
#1450809)
* Use art height as implicitHeight when the header is overlayed and
there's no summary
[ CI Train Bot ]
* New rebuild forced.
* Resync trunk.
[ Daniel d'Andrada ]
* Introducing FloatingFlickable
* Make Ubuntu.Gestures components install TouchRegistry by themselves
[ Michael Terry ]
* Fix a possible crash in our PAM threading code. (LP: #1425362) (LP:
#1425362)
* Fix the lockscreen becoming unresponsive after testing an app on the
device from QtCreator. (LP: #1435364)
[ Nick Dedekind ]
* Fixed desktop stage app focus.
* Fixed issue in laggy indicator autpilot tests (LP: #1446846) - 1789. By Josh Arenson on 2015-05-21
-
Make settings wizard test smarter when clicking through the wifi page
- 1790. By Josh Arenson on 2015-05-21
-
Move emulator code into module
| Josh Arenson (josharenson) wrote : | # |
WifiPage test checks for network connection/
> Also, it would be better to remove the emulators folder and move the contents
> of settings_wizard.py into:
>
> tests/autopilot
Done.
- 1791. By Josh Arenson on 2015-05-21
-
Remove unused methods
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1791
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Richard Huddie (rhuddie) wrote : | # |
This looks great. I ran the test locally and it passed. I understand that the ofono_helpers are for future use. So, approving.
| Michael Terry (mterry) wrote : | # |
Josh asked me to ACK the packaging changes. As mentioned on IRC, I'd like to avoid using xvfb if we can (feels weird to rely on it for phone stuff).
So Josh will test without using xvfb-run and see if phonesim really does require it. If so, fine. We can dep on it. But if it doesn't, let's drop the xvfb dep.
| Michael Terry (mterry) wrote : | # |
(Other than that, the packaging changes are trivial and fine.)
- 1792. By Josh Arenson on 2015-06-02
-
Find home dirctory regardless of platform
This allows for correctly deleting the wizard-has-run file on any platform
| Josh Arenson (josharenson) wrote : | # |
After a lot of playing around, it seems that ofono-phonesim does require xvfb to run, even when the -gui option is not specified (default is false). While this is unfortunate, mterry and I talked on IRC and agreed that it isn't harmful to install xvfb for testing, even though it only increases code coverage by a marginal amount. Can someone top level approve this?
| Leo Arias (elopio) wrote : | # |
You should mention on the commit message that you are adding the dependency. Otherwise ogra will go mad and start yelling ;)
Please mention there that it's only for testing and because the phonesim needs it. Maybe also report a bug for ofono-phonesim? I don't know the details, but maybe they can bundle a more simple wrapper.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1792
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Albert Astals Cid (aacid) wrote : | # |
Yes, someone should investigate why ofono-phonesim needs xvfb but there's no reason to stall this perfectly valid MR to land.
We can fine-tune-improve it when/if the thing gets fixed.
Top approving.
- 1793. By Josh Arenson on 2015-07-09
-
[ Albert Astals Cid ]
* Make the card sizes a bit dependant on the total of gu of the dash
[ Albert Astals Cid ]
* Save screenshots of suspended apps to disk
* Set width of title label when inside the title row (LP: #1461979)
* qmluitests was renamed to uitests
[ CI Train Bot ]
* Resync trunk.
[ Daniel d'Andrada ]
* Fix tst_OrientedShell and tst_Tutorial (LP: #1469761, #1466947)
[ Leo Arias ]
* Reorganized the python test helper modules. Deprecated the
unity8.shell.emulators namespace. (LP: #1306340)
[ Leonardo Arias Fonseca ]
* Reorganized the python test helper modules. Deprecated the
unity8.shell.emulators namespace. (LP: #1306340)
[ Lukáš Tinkl ]
* fix PO files extraction
[ Michael Zanetti ]
* Make use of QInputDeviceInfo in order to automatically switch
between usage modes and hide the OSK.
[ Nick Dedekind ]
* Fixed qtmultimedia mock which was generating errors in tests
[ Richard Huddie ]
* Reorganized the python test helper modules. Deprecated the
unity8.shell.emulators namespace. (LP: #1306340)
[ Albert Astals Cid ]
* Refactor QmlTest.cmake module so that all tests can go through it.
Also a bit of cleanup around tests.
* Support fallback images for dash card and preview widgets (LP:
#1324142)
[ CI Train Bot ]
* New rebuild forced.
* Resync trunk.
[ Daniel d'Andrada ]
* Fix Shell tests
[ Josh Arenson ]
* Refactor greeter emulator to unlock the greeter via dbus
[ Lukáš Tinkl ]
* respect target window's devicePixelRatio in MouseTouchAdaptor
[ Michael Zanetti ]
* Refactor QmlTest.cmake module so that all tests can go through it.
Also a bit of cleanup around tests.
[ Michał Sawicz ]
* Refactor QmlTest.cmake module so that all tests can go through it.
Also a bit of cleanup around tests.
[ handsome_feng ]
* Forbid closing apps during the edge gesture. (LP: #1445572)
* Removed the horizonal rule on pin unlock screen. (LP: #1368798)
[ handsome_feng<email address hidden> ]
* Forbid closing apps during the edge gesture. (LP: #1445572)
* No-change rebuild against Qt 5.4.2.
[ Michał Sawicz ]
* Implement full-shell rotation (LP: #1210199)
[ CI Train Bot ]
* New rebuild forced.
* Resync trunk.
[ Daniel d'Andrada ]
* Implemented autopilot-test and fake-sensors for shell-rotation.
[ Mirco Müller ]
* Implemented autopilot-test and fake-sensors for shell-rotation.
* Implement full-shell rotation (LP: #1210199)
[ CI Train Bot ]
* New rebuild forced.
* Resync trunk.
[ Renato Araujo Oliveira Filho ]
* Set the device led color to green. (LP: #1450894)

FAILED: Continuous integration, rev:1785 jenkins. qa.ubuntu. com/job/ unity8- ci/5740/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- wily-touch/ 19/console jenkins. qa.ubuntu. com/job/ unity8- wily-amd64- ci/18/console jenkins. qa.ubuntu. com/job/ unity8- wily-i386- ci/18/console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- wily-armhf/ 19/console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity8- ci/5740/ rebuild
http://