Code review comment for lp:~josharenson/unity8/fix-scope-managment-scrolling

Revision history for this message
Josh Arenson (josharenson) wrote :

> What do we need
>
> property alias animationProperty: d.relevantContentAxis
> Behavior on animationProperty { UbuntuNumberAnimation{} }
>
> for? As far as I can see they are not used anywhere, no?

I moved this into the private object as it appears you can't "Behave" on an alias. I also added a property to the API to allow the user to enable/disable the animation as it causes _horrible_ lag for small interval values (which makes sense as its doing an animation calculation every 2ms). In fact, I wonder if there is any point in having an interval < 16ms?

> Do you think that updating the position of the dragged item inside the list is
> doable? I think it would make more sense if it did.
I'll talk to you on IRC about this.. It seems like too strong of a coupling, but perhaps I'm misunderstanding.

« Back to merge proposal