Merge lp:~josharenson/unity8/fix-over-eager-scope-swipe into lp:unity8

[Josh Arenson]

Disable showDash when it is already shown.

 * Are there any related MPs required for this MP to build/function as expected? Please list.
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
Not exactly...

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2226
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/643/
Executed test runs:
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/365
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial,testname=qmluitests.sh/365
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=autopilot.sh/365
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/848
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/864
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/864
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/862
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/862/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/862
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/862/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/862
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/862/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/862
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/862/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/862
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/862/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/862
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/862/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/643/rebuild

review: Needs Fixing (continuous-integration)

[Albert Astals Cid (aacid)]

This does not seem to affect the case the bug is about (i.e. being on a non favorited scope and showing the launcher).

I put a console.log in that function and it doesn't seem to be triggered in that scenario.

[Albert Astals Cid (aacid)]

review: Needs Fixing

[Josh Arenson (josharenson)]

@Albert, really? I'm seeing it hit that code ever time I swipe the launcher, including on non-favorited scopes...

[Albert Astals Cid (aacid)]

Ok, i'll try again, maybe i didn't do it right :D

[Albert Astals Cid (aacid)]

I'm not sure we're testing the same thing you are, this is what i did:
 * Flash phone
 * edit /usr/share/unity8/Shell.qml
 * add console.log("onDashSwipeChanged", dashSwipe); as first line of onDashSwipeChanged:
 * restart unity8-dash
 * tailf .cache/upstart/unity8-dash.log
 * go to app scope
 * open the ubuntu store
 * check it's not a favorite scope
 * do a long left swipe
 * check that onDashSwipeChanged wasn't printed to the log

[Albert Astals Cid (aacid)]

Andrea pointed out that i need to restart unity8 and not unity8-dash, my bad.

[Albert Astals Cid (aacid)]

This fixes the "over eager" swipe by totally removing it. I'd say that what should happen is that when unity8-dash is shown the distance to trigger trigger is a bit longer, but people should still be able to do what they do nowadays.

review: Needs Fixing

[Josh Arenson (josharenson)]

I arrived at the value I chose, units.gu(12), by trial and error. It _should_ always be a reasonable value, but if you have other ideas, I'm open to them.

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2228
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/691/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/393
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial,testname=qmluitests.sh/393
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=autopilot.sh/393
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/909
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/925
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/925
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/923
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/923/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/923
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/923/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/923
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/923/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/923
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/923/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/923
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/923/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/923
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/923/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/691/rebuild

review: Needs Fixing (continuous-integration)

[Albert Astals Cid (aacid)]

I guess this is good enough for now.

Will have to reevaluate the whole thing when we move to the browser-like scopes

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass? If not, please explain why.
Yes (except previously broken autopilot)

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

[Unity8 CI Bot (unity8-ci-bot)]

PASSED: Continuous integration, rev:2228
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/715/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/403
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial,testname=qmluitests.sh/403
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=autopilot.sh/403
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/940
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/956
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/956
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/954
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/954/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/954
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/954/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/954
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/954/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/954
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/954/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/954
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/954/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/954
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/954/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/715/rebuild

review: Approve (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2228
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/812/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1059
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1075/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1075/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1073/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1073/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1073/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1073/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1073/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1073/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/812/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2228
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/824/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1071
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1082
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1082
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1080
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1080/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1080/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1080
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1080/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1080/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1080
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1080/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1080/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/824/rebuild

review: Needs Fixing (continuous-integration)

[Albert Astals Cid (aacid)]

Text conflict in qml/Shell.qml
1 conflicts encountered.

Note to self: Was already top approved

review: Needs Fixing

[lp:~josharenson/unity8/fix-over-eager-scope-swipe]

2342. By Launchpad Translations on behalf of unity-team on 2016-04-27

Launchpad automatic translations update.

2343. By Lukáš Tinkl on 2016-04-27

Hide the close button for dash Fixes: #1550056, #1564347
Approved by: Josh Arenson

2344. By Lukáš Tinkl on 2016-04-27

Unity8 windows now cascade instead of opening all in the top left corner Fixes: #1513813
Approved by: Lukáš Tinkl

2345. By Lukáš Tinkl on 2016-04-27

Notifications visual update, close button on mouse hover Fixes: #1564343
Approved by: Michael Zanetti

2346. By Lukáš Tinkl on 2016-04-27

Shell visual update
Approved by: Albert Astals Cid

2347. By Lukáš Tinkl on 2016-04-27

Drop OOBE wizard autopilot tests
Approved by: Michael Terry

2348. By Lukáš Tinkl on 2016-04-27

Stabilize wizard tests
Approved by: Albert Astals Cid

2349. By Lukáš Tinkl on 2016-04-27

Fix labels in desktop spread

2350. By Lukáš Tinkl on 2016-04-27

Fix upcoming event ETAs falling out of sync Fixes: #1557571

2351. By Albert Astals Cid on 2016-04-27

LVWPH: Account for contentHeight not really being "all" of the content height

m_minYExtent is also part of the content height Fixes: #1569976
Approved by: Michael Zanetti

2352. By Albert Astals Cid on 2016-04-27

rootObject can be null for a small moment after setSource is called
 Fixes: #1560501
Approved by: Daniel d'Andrada

2353. By Albert Astals Cid on 2016-04-27

forceLayout before calling positionViewAtIndex

We need the list size to be correctly updated before positionViewAtIndex

This needs https://bugs.launchpad.net/ubuntu/+source/qtdeclarative-opensource-src/+bug/1556842 to actually work Fixes: #1553475
Approved by: Michael Zanetti

2354. By Albert Astals Cid on 2016-04-27

Compile with Qt 5.6

And actually emit the signal Fixes: #1565632
Approved by: Timo Jyrinki, Michael Zanetti

2355. By Albert Astals Cid on 2016-04-27

Turn verify intro tryCompareFunction
Approved by: Michael Zanetti

2356. By Albert Astals Cid on 2016-04-27

Better error message if the item does not exist

Instead of
  Cannot read property 'width' of null
and a line pointing to UnityTestCase.qml, you get
   No item given
and a line pointing to the offending code
Approved by: Michael Terry

2357. By Albert Astals Cid on 2016-04-27

See all/less -> Show all/less
 Fixes: #1349471
Approved by: Andrea Cimitan

2358. By Albert Astals Cid on 2016-04-27

Add env var to enable js debugging/profiling even if not built on debug mode

Approved by: Michael Zanetti

2359. By Albert Astals Cid on 2016-04-27

CardCreator: Remove ShaderEffectSource

Seems we don't really need it (can't see any regression without it) and it fixes the weird flickering of the appstore card when changing departments Fixes: #1544875
Approved by: Josh Arenson

2360. By Albert Astals Cid on 2016-04-27

Take into account that sectionItem height can change

Approved by: Josh Arenson

2361. By Albert Astals Cid on 2016-04-27

NotificationAudio: We don't need weird "ifdef" for multimedia 5.6 vs 5.0 roles anymore
Approved by: Michael Zanetti

2362. By Albert Astals Cid on 2016-04-27

Stabilize test_superTabToCycleLauncher

Approved by: Michael Terry

2363. By Michael Zanetti on 2016-04-27

install devices.conf by default
Approved by: Michael Terry

2364. By Michael Zanetti on 2016-04-27

improve the pin lockscreen

On smallish screens, like the BQ E4.5, it frequently happens that one
misses a digit when quickly entering the pin. After a while of debugging
usage on my phone I noticed that the cause of this is actually that the
user keeps moving the finger while touching the buttons and so it
often happens that the touch events are not recognized as clicks.

I've been using this patch for a while now and it increased the reliability
of the pin entry a lot. I've also asked other people who reported the issue
to test this and feedback has been rather good.
Approved by: Michael Terry

2365. By Michael Zanetti on 2016-04-27

Drop the rotation lock for the dash Fixes: #1465331, #1574165
Approved by: Lukáš Tinkl

2366. By Michael Terry on 2016-04-27

Fix some unreliable test code.
Approved by: Albert Astals Cid

2367. By Michael Terry on 2016-04-27

Ignore Home Key presses when the greeter is up.

This avoids pocket presses / dialing on devices like the arale. Fixes: #1565818
Approved by: Daniel d'Andrada

2368. By Josh Arenson on 2016-04-27

Change the color of the activity pulse to blue Fixes: #1568082
Approved by: Michael Terry

2369. By Josh Arenson on 2016-04-27

Make scope filter settings button the same color as other foreground elements Fixes: #1563357
Approved by: Albert Astals Cid

2370. By Ted Gould on 2016-04-27

Switch to using uid/pwdent for getting username
Approved by: Michael Terry

2371. By Daniel van Vugt on 2016-04-27

Reinstate the touch performance/smoothness fix
(LP: #1486341, LP: #1556763).

It never really went away, but someone accidentally moved it out of
pre-start and into post-start where it has no effect. Fixes: #1556763
Approved by: Timo Jyrinki, Daniel d'Andrada

2372. By CI Train Bot Account on 2016-04-27

Releasing 8.12+16.04.20160427.3-0ubuntu1

2373. By CI Train Bot Account on 2016-04-29

Resync trunk.

2374. By Gerry Boland on 2016-04-29

Indicators: set menu height binding while fully open/closed, fixes dynamic grid unit bug.

Before this, if the grid units changed, the menu "height" remained fixed, but minimizedPanelHeight and openedHeight would adapt. This would mean for case phone (GU 22) to desktop (GU8):
a. if the menu was closed, it would remain at the old height (3*22=66pixels), while the panel would shrink (3*8 = 24). This would mean the menu was technically open, and would block input to windows
b. if the menu was opened, it would remain open at the old phone height, and not grow to the new screen height.
Approved by: Michael Terry

2375. By Michael Zanetti on 2016-04-29

Temporary means to override GUs on the internal screen
Approved by: Lukáš Tinkl

2376. By Daniel d'Andrada on 2016-04-29

Refactor screenshotting code and make it work in multimonitor scenarios

+ Workaround bug in QWindow regrading "visible" property when moving a window between screens.
+ Implement snapshotting the focused window with Alt+PrtScn
Approved by: Lukáš Tinkl

2377. By Daniel d'Andrada on 2016-04-29

Make shell rotation animation work on multimonitor scenarios.

Fixes the Shell snapshotting code, used in ninety-degrees rotation animations, to work on multimonitor scenarios.
Approved by: Lukáš Tinkl

2378. By Daniel d'Andrada on 2016-04-29

Ensure shell transformations use bindings as OrientedShell can get resized
Approved by: Michael Zanetti

2379. By Michael Zanetti on 2016-04-29

reduce some paint layers.

This will reduce overdraw by 2 layers when apps are focused, by 1 layer when
in spread.
Approved by: Michael Terry

2380. By Michael Zanetti on 2016-04-29

Call the dash sizing hack when units.gu changes
Approved by: Gerry Boland

2381. By CI Train Bot Account on 2016-04-29

Releasing 8.12+16.04.20160429.2-0ubuntu1

2382. By CI Train Bot Account on 2016-05-04

Resync trunk.

2383. By Andrea Cimitan on 2016-05-04

Add social actions to cards
Approved by: Josh Arenson

2384. By Albert Astals Cid on 2016-05-04

Pass the category correctly

Approved by: Pawel Stolowski

2385. By Albert Astals Cid on 2016-05-04

Make the previewActions react to the actions model changing

i.e. use a binding instead of a direct assingment Fixes: #1485887
Approved by: Andrea Cimitan

2386. By Albert Astals Cid on 2016-05-04

Update the icon also to the original one if that's what the scope wants

Approved by: Andrea Cimitan

2387. By Albert Astals Cid on 2016-05-04

Reload Preview Zoomable Image source if it gets updated

Approved by: Michael Zanetti

2388. By CI Train Bot Account on 2016-05-04

Make the previewActions react to the actions model changing

i.e. use a binding instead of a direct assingment Fixes: #1485887
Approved by: Andrea Cimitan

2389. By CI Train Bot Account on 2016-05-04

Update the icon also to the original one if that's what the scope wants

Approved by: Andrea Cimitan

2390. By CI Train Bot Account on 2016-05-04

Reload Preview Zoomable Image source if it gets updated

Approved by: Michael Zanetti

2391. By Albert Astals Cid on 2016-05-04

Expandable Filter Widget
Approved by: Andrea Cimitan, Pawel Stolowski

2392. By CI Train Bot Account on 2016-05-04

Releasing 8.12+16.04.20160504.2-0ubuntu1

2393. By CI Train Bot Account on 2016-05-05

Resync trunk.

2394. By Launchpad Translations on behalf of unity-team on 2016-05-06

Launchpad automatic translations update.

2395. By Launchpad Translations on behalf of unity-team on 2016-05-11

Launchpad automatic translations update.

2396. By Launchpad Translations on behalf of unity-team on 2016-05-17

Launchpad automatic translations update.

2397. By Daniel d'Andrada on 2016-05-18

Move prompt surfaces from MirSurface to Application

prompt surfaces can show up even before an application creates its first surface

2398. By CI Train Bot Account on 2016-05-18

Releasing 8.12+16.04.20160518.1-0ubuntu1

2399. By Launchpad Translations on behalf of unity-team on 2016-05-19

Launchpad automatic translations update.

2400. By Launchpad Translations on behalf of unity-team on 2016-05-20

Launchpad automatic translations update.

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2230
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1281/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1723
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1672
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/1672
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1665/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1665/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1665/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1665/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1665/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1665/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1665/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1665/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1665/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1281/rebuild

review: Needs Fixing (continuous-integration)

[lp:~josharenson/unity8/fix-over-eager-scope-swipe]

2401. By Josh Arenson on 2016-05-23

Fix mess

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2401
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1282/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1724
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1673
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/1673
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1666
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1666/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1666
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1666/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1666/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1666
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1666/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1666
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1666/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1666/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1666
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1666/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1666
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1666/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1666/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1282/rebuild

review: Needs Fixing (continuous-integration)

[Albert Astals Cid (aacid)]

Merges fine again.

review: Approve

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2401
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1287/
Executed test runs:
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/818
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/818
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/818
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1730
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1682
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/1682
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/1682
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1675
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1675/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1675
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1675/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1675
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1675/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1675
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1675/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1675
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1675/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1675
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1675/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1675
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1675/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1675
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1675/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1675
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1675/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1287/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2401
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1333/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/1771
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/869
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/869
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/869
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1797
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1744
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/1744
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/1744
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1737
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1737/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1737
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1737/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1737
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1737/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1737
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1737/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1737
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1737/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1737
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1737/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1737
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1737/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1737
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1737/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1737
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1737/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1333/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

PASSED: Continuous integration, rev:2401
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1382/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/1848
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/931
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/931
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/931
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1874
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1812
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/1812
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/1812
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1803
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1803/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1803
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1803/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1803
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1803/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1803
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1803/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1803
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1803/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1803
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1803/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1803
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1803/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1803
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1803/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1803
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1803/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1382/rebuild

review: Approve (continuous-integration)

=== modified file 'qml/Shell.qml'
--- qml/Shell.qml	2016-04-29 20:06:54 +0000
+++ qml/Shell.qml	2016-05-23 16:20:43 +0000
@@ -552,7 +552,14 @@
             id: launcher
             objectName: "launcher"
 
-            readonly property bool dashSwipe: progress > 0
+            /*
+             * Since the Dash doesn't have the same controll over surfaces that the
+             * Shell does, it can't slowly move the scope out of the way, as the shell
+             * does  with apps, and the dash is show instantly. This allows for some
+             * leeway and prevents accidental home swipes.
+             */
+            readonly property real offset: shell.focusedApplicationId == "unity8-dash" ? units.gu(12) : 0
+            readonly property bool dashSwipe: progress > offset
 
             anchors.top: parent.top
             anchors.topMargin: inverted ? 0 : panel.panelHeight