Merge lp:~josharenson/unity8/fix-greeter-password-focus into lp:unity8

[Josh Arenson]

Focus the greeter's password field when a prompt from PAM is received.

* Are there any related MPs required for this MP to build/function as expected? Please list.
lp:~josharenson/unity8/session-chooser-gui

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

[Unity8 CI Bot (unity8-ci-bot)]

PASSED: Continuous integration, rev:2006
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/149/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/149/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:2006
http://jenkins.qa.ubuntu.com/job/unity8-ci/7112/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6092
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-xenial-touch/527/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/1817
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity8-qmluitest-xenial-amd64/520
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/1712
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/1712
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-amd64-ci/519
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-i386-ci/518
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4703
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6103
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6103/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26832
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-xenial-touch/264/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/525
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/525/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26834

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7112/rebuild

review: Needs Fixing (continuous-integration)

[lp:~josharenson/unity8/fix-greeter-password-focus]

1966. By Josh Arenson on 2016-01-22

Enable running the greeter as a Mir server.

1967. By Josh Arenson on 2016-01-22

Fix whitespace, remove some hacks

1968. By Josh Arenson on 2016-01-22

Fix translations

1969. By Josh Arenson on 2016-01-26

[ Albert Astals Cid ]
* Fix bug #1536296 added: tests/plugins/Dash/cardcreator/10.tst (LP:
  #1536296)
* Fix card tests on the phone
[ CI Train Bot ]
* Update translation template

1970. By Josh Arenson on 2016-02-03

[ Albert Astals Cid ]
* Audio Preview Button: Don't gain focus on press (LP: #1517830)
* Better attempt at sanitization
* Better looking application scopes for wide screens
* Call printSettings correctly
* Card test: Limit the precision we ask for doubles to be equal
* Convert while into tryCompareFunction
* Do not use the same filepath parameter for all the card creator
  createQmlObject calls (LP: #1536379)
* Fix some test shells being unstable in the armhf builders
* Make revealByEdgePush more stable
* More reliable compares
* Move the mouse over the bfb before waiting for rendering
* Remove the DDAs constrains for every test
* Set the background source size to the max we'll need + new
  background (LP: #1539011)
[ Andrea Cimitan ]
* Dynamically change click scope card size according to size (LP:
  #1536745)
* Should fix lazyimage test failures on fast machines
[ CI Train Bot ]
* Fix card tests on the phone
* Update translation template
[ Daniel d'Andrada ]
* Desktop stage rotates only to follow screen orientation (LP:
  #1515977)
[ Lukáš Tinkl ]
* Hide/reveal the mouse pointer on touch/mouse events renamed:
  plugins/Utils/HomeKeyWatcher.cpp =>
  plugins/Utils/WindowInputMonitor.cpp plugins/Utils/HomeKeyWatcher.h
  => plugins/Utils/WindowInputMonitor.h
  tests/mocks/Utils/HomeKeyWatcher.qml =>
  tests/mocks/Utils/WindowInputMonitor.qml
  tests/plugins/Utils/HomeKeyWatcherTest.cpp =>
  tests/plugins/Utils/WindowInputMonitorTest.cpp
[ Michael Terry ]
* Synchronize the mouse-cursor-speed and touchpad-cursor-speed
  properties with USC. (LP: #1536383)
[ Michael Zanetti ]
* Add InputMethod to secondary screen
* Add a virtual Touchpad while external screen is connected
* Make big tablets switch to windowed mode by plugging a kbd only (LP:
  #1535399)
* Prevent alt key presses from being dispatched to the app on alt+tab
  (LP: #1532862)
[ Michał Sawicz ]
* Make qmluitests.sh more robust and allow parallel test execution
* Skip SessionBackendTest::testLogin1Capabilities until we talk to a
  mock instead (LP: #1532112, #1532113)

1971. By Josh Arenson on 2016-02-03

Fix ninja complaining about qmldir files

1972. By Josh Arenson on 2016-02-09

Re-enable tests.

[Michael Terry (mterry)]

Might it be easier to just move the forceActiveFocus() call into LoginList's showPrompt()?

[Michael Terry (mterry)]

(rather than adding a new property, that is)

review: Needs Information

[lp:~josharenson/unity8/fix-greeter-password-focus]

1973. By Josh Arenson on 2016-02-16

[ Albert Astals Cid ]
* Do not use components in card creator generated code
* Forward the makesurevisible signal from the inner preview widget
* Make fallback also be fallback when the image is empty and not only
  on error (LP: #1531913)
* Make the artShapeSize assignment be updated when using dynamic grid
  units
* Visual improvements to the dash audio play cards
* We don't use the unity-scope-scopes anymore (LP: #1439172)
[ Andrea Cimitan ]
* only request a bigger image if zoomable widget data property is
  true, otherwise just leave the screen size (LP: #1536814)
[ CI Train Bot ]
* Update translation template
[ Daniel d'Andrada ]
* Set initial surface size (LP: #1532974)
[ Daniel d'Andrada, Michał Sawicz ]
* Window Size Hints
[ Florian Boucault ]
* Splash screen: delay showing the ActivityIndicator by 2 seconds.
[ Lukáš Tinkl ]
* Replace the word "phone" with a more generic term "device" in the
  welcome wizard (LP: #1294732, #1543527)
[ Michael Terry ]
* Have the tablet greeter set appropriate OSK hints if the user has a
  passcode instead of a passphrase. (LP: #1544173)
[ Michael Zanetti ]
* Don't eat mouse events in the edgebarrer
[ Michał Sawicz ]
* Bump unity-api dependencies
[ Nick Dedekind ]
* Added support for secondary indicator actions (LP: #1398888)
* Remove zombie if they're not animated. (LP: #1534541)
* Removed unused panel resources
[ Ted Gould ]
* Start the indicators after Unity8 starts instead of before
[ Albert Astals Cid ]
* LVWPH: Reset to initial values when list is empty (LP: #1540490)
* Make LazyImage qmltest less flaky on CI
[ Andrea Cimitan ]
* Make LazyImage qmltest less flaky on CI
[ CI Train Bot ]
* Resync trunk.
* Update translation template
[ Michael Terry ]
* Display the current user's real name on the tablet lockscreen. (LP:
  #1536714)

1974. By Josh Arenson on 2016-02-22

[ Albert Astals Cid ]
* Make the audio previews create a playlist (LP: #1540477)
[ CI Train Bot ]
* Resync trunk. added: po/aa.po
* Update translation template

1975. By Josh Arenson on 2016-02-24

Fix issue where a passwordless user was logged in automatically.

1976. By Josh Arenson on 2016-02-29

Merge trunk.

1977. By Josh Arenson on 2016-03-02

Merge trunk

1978. By Josh Arenson on 2016-03-04

Fix translations

1979. By Josh Arenson on 2016-03-04

Fix translations

1980. By Josh Arenson on 2016-03-04

Merge pre-req

[Albert Astals Cid (aacid)]

Text conflict in plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt
Conflict adding file plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.BASE. Moved existing file to plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.BASE.moved.
Conflict adding file plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.BASE.moved. Moved existing file to plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.BASE.moved.moved.
Conflict adding file plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.BASE.moved.moved. Moved existing file to plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.BASE.moved.moved.moved.
Conflict adding file plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.BASE.moved.moved.moved. Moved existing file to plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.BASE.moved.moved.moved.moved.
Conflict adding file plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.BASE.moved.moved.moved.moved. Moved existing file to plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.BASE.moved.moved.moved.moved.moved.
Conflict adding file plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.BASE.moved.moved.moved.moved.moved. Moved existing file to plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.BASE.moved.moved.moved.moved.moved.moved.
Conflict adding file plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.BASE.moved.moved.moved.moved.moved.moved. Moved existing file to plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.BASE.moved.moved.moved.moved.moved.moved.moved.
Conflict adding file plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.OTHER. Moved existing file to plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.OTHER.moved.
Conflict adding file plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.OTHER.moved. Moved existing file to plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.OTHER.moved.moved.
Conflict adding file plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.OTHER.moved.moved. Moved existing file to plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.OTHER.moved.moved.moved.
Conflict adding file plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.OTHER.moved.moved.moved. Moved existing file to plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.OTHER.moved.moved.moved.moved.
Conflict adding file plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.OTHER.moved.moved.moved.moved. Moved existing file to plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.OTHER.moved.moved.moved.moved.moved.
Conflict adding file plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.OTHER.moved.moved.moved.moved.moved. Moved existing file to plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.OTHER.moved.moved.moved.moved.moved.moved.
Conflict adding file plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.OTHER.moved.moved.moved.moved.moved.moved. Moved existing file to plugins/LightDM/IntegratedLightDM/liblightdm/CMakeLists.txt.OTHER.moved.moved.moved.moved.moved.moved.moved.
Conflict adding file plugins/LightDM/Integr...

[lp:~josharenson/unity8/fix-greeter-password-focus]

1981. By Josh Arenson on 2016-03-17

merge prereq

1982. By Josh Arenson on 2016-03-21

merge prereq

1983. By Josh Arenson on 2016-03-21

merge prereq

1984. By Josh Arenson on 2016-03-21

merge prereq

1985. By Josh Arenson on 2016-03-22

merge prereq

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:1985
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/850/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1105/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/850/rebuild

review: Needs Fixing (continuous-integration)

[Michał Sawicz (saviq)]

Text conflict in qml/Greeter/Greeter.qml
Text conflict in qml/Shell.qml
2 conflicts encountered.

[lp:~josharenson/unity8/fix-greeter-password-focus]

1986. By Josh Arenson on 2016-03-25

merge prereq

[Michael Terry (mterry)]

> Might it be easier to just move the forceActiveFocus() call into LoginList's showPrompt()?

I commented that a long time ago. Eh? Seems like focus is a detail that should be handled by LoginList, if it's given a request to show the prompt.

review: Needs Information

Unmerged revisions

1986. By Josh Arenson on 2016-03-25

merge prereq

1985. By Josh Arenson on 2016-03-22

merge prereq

1984. By Josh Arenson on 2016-03-21

merge prereq

1983. By Josh Arenson on 2016-03-21

merge prereq

1982. By Josh Arenson on 2016-03-21

merge prereq

1981. By Josh Arenson on 2016-03-17

merge prereq

1980. By Josh Arenson on 2016-03-04

Merge pre-req

=== modified file 'qml/Greeter/LoginList.qml'
--- qml/Greeter/LoginList.qml	2016-03-25 20:10:35 +0000
+++ qml/Greeter/LoginList.qml	2016-03-25 20:10:36 +0000
@@ -24,6 +24,7 @@
 
     property alias model: userList.model
     property bool alphanumeric: true
+    property alias passwordInput: passwordInput
     property int currentIndex
     property bool locked
 

=== modified file 'qml/Greeter/WideView.qml'
--- qml/Greeter/WideView.qml	2016-03-25 20:10:35 +0000
+++ qml/Greeter/WideView.qml	2016-03-25 20:10:36 +0000
@@ -73,6 +73,7 @@
     readonly property var showPrompt: ifLoginlistShownThen(doShowPrompt);
     function doShowPrompt(text, isSecret, isDefaultPrompt) {
         loginAreaLoader.item.showPrompt(text, isSecret, isDefaultPrompt);
+        loginAreaLoader.item.passwordInput.forceActiveFocus();
     }
 
     readonly property var tryToUnlock: ifLoginlistShownThen(doTryToUnlock);