Merge lp:~josharenson/unity8/fix-greeter-password-focus-backport into lp:unity8

Proposed by Josh Arenson
Status: Rejected
Rejected by: Josh Arenson
Proposed branch: lp:~josharenson/unity8/fix-greeter-password-focus-backport
Merge into: lp:unity8
Diff against target: 11 lines (+1/-0)
1 file modified
qml/Greeter/LoginList.qml (+1/-0)
To merge this branch: bzr merge lp:~josharenson/unity8/fix-greeter-password-focus-backport
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Needs Fixing
Josh Arenson Disapprove
Michael Terry Needs Information
Albert Astals Cid (community) Needs Fixing
Review via email: mp+296558@code.launchpad.net

Commit message

Focus the greeter password input for tablets automatically

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.
No

* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

* If you changed the UI, has there been a design review?
Nah...

To post a comment you must log in.
Revision history for this message
Albert Astals Cid (aacid) wrote :

Can we have an autotest?

review: Needs Fixing
Revision history for this message
Michael Terry (mterry) wrote :

I think we can also just drop the bit right beforehand, eh?

 if (wasPrompted) // stay in text field if second prompt
     passwordInput.focus = true;

review: Needs Information
Revision history for this message
Josh Arenson (josharenson) wrote :

Rejecting as mterry's redesign of the login box fixes this indirectly

review: Disapprove
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2442
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1408/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/1874
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/955
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/955
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/955
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1900
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1837
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/1837
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/1837
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1828
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1828/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1828
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1828/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1828
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/1828/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1828
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1828/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1828
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1828/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1828
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/1828/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1828
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1828/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1828
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1828/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1828
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/1828/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1408/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

2442. By Josh Arenson

Focus the greeter password input for tablets automatically

2441. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Greeter/LoginList.qml'
2--- qml/Greeter/LoginList.qml 2016-02-10 18:23:26 +0000
3+++ qml/Greeter/LoginList.qml 2016-06-06 14:09:21 +0000
4@@ -64,6 +64,7 @@
5 if (wasPrompted) // stay in text field if second prompt
6 passwordInput.focus = true;
7 wasPrompted = true;
8+ passwordInput.forceActiveFocus();
9 }
10
11 function showError() {

Subscribers

People subscribed via source and target branches