Merge lp:~josharenson/qtmir/allow_duplicate_focusing into lp:qtmir
Status: | Merged |
---|---|
Approved by: | Gerry Boland |
Approved revision: | 250 |
Merged at revision: | 258 |
Proposed branch: | lp:~josharenson/qtmir/allow_duplicate_focusing |
Merge into: | lp:qtmir |
Diff against target: |
52 lines (+29/-2) 2 files modified
src/modules/Unity/Application/application_manager.cpp (+0/-2) tests/modules/ApplicationManager/application_manager_test.cpp (+29/-0) |
To merge this branch: | bzr merge lp:~josharenson/qtmir/allow_duplicate_focusing |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gerry Boland (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email:
|
Commit message
Remove check to see if application is already focused before focusing.
Work around lp:1362017 by removing a check to see if an application is already focused before focusing. This forces all applications to go through all steps of obtaining focus, even if the application was already focused.
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes, and ran unit tests
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
Fix lp:1362017
This works around an issue where the panel stays in the foreground when it is used to open an app behind it that already has focus by allowing an application that already has focus, to request it again.
FAILED: Continuous integration, rev:249 /code.launchpad .net/~josharens on/qtmir/ allow_duplicate _focusing/ +merge/ 234556/ +edit-commit- message
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http:// jenkins. qa.ubuntu. com/job/ qtmir-ci/ 70/ jenkins. qa.ubuntu. com/job/ qtmir-utopic- amd64-ci/ 70 jenkins. qa.ubuntu. com/job/ qtmir-utopic- armhf-ci/ 70/console
Executed test runs:
SUCCESS: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/qtmir- ci/70/rebuild
http://