Merge lp:~josephriches/anoise/anoise into lp:anoise

Proposed by Joseph Riches on 2017-12-04
Status: Needs review
Proposed branch: lp:~josephriches/anoise/anoise
Merge into: lp:anoise
Diff against target: 9 lines (+1/-0)
1 file modified
anoise.desktop.in (+1/-0)
To merge this branch: bzr merge lp:~josephriches/anoise/anoise
Reviewer Review Type Date Requested Status
costales 2017-12-04 Needs Information on 2018-01-07
Review via email: mp+334707@code.launchpad.net

Description of the change

Add 'StartupWMClass' to desktop file, this fixes various system integration things on some desktop enviroments.

For example, on Budgie as the WM_NAME differs from WM_CLASS Budgie cannot determine the WM_CLASS without this hint and thus the pin to panel option is not shown. Additionally, the themed icon is not used. Adding StartupWMClass to the desktop file fixes these issues.

To post a comment you must log in.
costales (costales) wrote :

Hi Joseph,

Thanks a lot for the fix.

One question, I'm not sure the python file is right. Should it be in lowercase? Would it need the complete path?

costales@T410:~/Desktop/anoise$ find . -name "Anoise.py"
costales@T410:~/Desktop/anoise$ find . -name "anoise.py"
./anoise/anoise.py
costales@T410:~/Desktop/anoise$

Thanks in advance and merry Xmas.

review: Needs Fixing
costales (costales) wrote :

I was looking more deep...
https://developer.gnome.org/desktop-entry-spec/
"...it is known that the application will map at least one window with the given string..."
ANoise hasn't a window, it's integrated into the Unity sound control, then, I'm not sure about this fix in all desktop environments :/

review: Needs Information

Unmerged revisions

57. By Joseph Riches on 2017-12-04

Add StartupWMClass to desktop file

Fixes system integration of anoise-gui on some desktop enviroments, including:

* The pin to panel not being shown on Budgie as WM_NAME differs from
  WM_CLASS and Budgie cannot determine the WM_CLASS.
* The themed icon not being shown in some situations
* The applications showing twice on some docks.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'anoise.desktop.in'
--- anoise.desktop.in 2015-05-08 18:19:42 +0000
+++ anoise.desktop.in 2017-12-04 21:37:30 +0000
@@ -8,4 +8,5 @@
8Type=Application8Type=Application
9Categories=AudioVideo;Player;9Categories=AudioVideo;Player;
10Keywords=Player;Audio;10Keywords=Player;Audio;
11StartupWMClass=Anoise.py
11X-Ubuntu-Gettext-Domain=anoise12X-Ubuntu-Gettext-Domain=anoise

Subscribers

People subscribed via source and target branches

to all changes: