Ubuntu Packaging Guide

Merge lp:~josephjamesmills/ubuntu-packaging-guide/libraries.rst-line14 into lp:ubuntu-packaging-guide

  1. libraries.rst-line14
  2. Merge into trunk
Proposed by Joseph Mills
Status: Rejected
Rejected by: Simon Quigley
Proposed branch: lp:~josephjamesmills/ubuntu-packaging-guide/libraries.rst-line14
Merge into: lp:ubuntu-packaging-guide
Diff against target: 26 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
ubuntu-packaging-guide/libraries.rst (+1/-1)
To merge this branch: bzr merge lp:~josephjamesmills/ubuntu-packaging-guide/libraries.rst-line14
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Needs Fixing
Review via email: mp+106952@code.launchpad.net

Description of the change

fixed a grammar error.

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Thanks for your work on this. This might need some additional work.

In the original I read "If any of the symbols is removed or changes..." as "If *one* of the symbols is removed or changes".

When you change it to "If any of the symbols are removed or changes..." it should at least be "...or change..." to reflect it's written in plural.

review: Needs Fixing
Revision history for this message
Daniel Holbach (dholbach) wrote :

I'll mark these merge proposals as 'work in progress' to get them off the review list.

Revision history for this message
Simon Quigley (tsimonq2) wrote :

Rejecting due to the fact that this will be rewritten and feedback was requested but nothing was done to fix it.

Unmerged revisions

100. By Joseph Mills

libraries.rst:line 14 Changed 'If any of the symbols is removed' to 'If any of the symbols are removed'.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-03-12 22:28:59 +0000
3+++ debian/changelog 2012-05-23 07:23:24 +0000
4@@ -1,3 +1,9 @@
5+ubuntu-packaging-guide (0.1ubuntu1) quantal; urgency=low
6+
7+ * ubuntu-packaging-guide/libraries.rst: Changed 'If any of the symbols is removed' too 'If any of the symbols are removed' on line 14
8+
9+ -- Joseph Mills <josephjamesmills@josephjamesmills> Sat, 19 May 2012 02:51:14 -0400
10+
11 ubuntu-packaging-guide (0.1) UNRELEASED; urgency=low
12
13 * Initial release.
14
15=== modified file 'ubuntu-packaging-guide/libraries.rst'
16--- ubuntu-packaging-guide/libraries.rst 2012-03-20 22:02:49 +0000
17+++ ubuntu-packaging-guide/libraries.rst 2012-05-23 07:23:24 +0000
18@@ -11,7 +11,7 @@
19 SONAME which includes a version number. This SONAME version does not
20 necessarily match the public release version number. A program gets
21 compiled against a given SONAME version of the library. If any of the
22-symbols is removed or changes then the version number needs to be
23+symbols are removed or changes then the version number needs to be
24 changed which forces any packages using that library to be recompiled
25 against the new version. Version numbers are usually set by upstream
26 and we follow them in our binary package names called an ABI number,

Subscribers

People subscribed via source and target branches