Merge lp:~jose/summit/981880-fix into lp:summit

Proposed by José Antonio Rey
Status: Merged
Approved by: Michael Hall
Approved revision: 481
Merged at revision: 508
Proposed branch: lp:~jose/summit/981880-fix
Merge into: lp:summit
Diff against target: 171 lines (+82/-31)
2 files modified
summit/schedule/templates/schedule/mine.html (+41/-16)
summit/schedule/templates/schedule/review.html (+41/-15)
To merge this branch: bzr merge lp:~jose/summit/981880-fix
Reviewer Review Type Date Requested Status
Michael Hall (community) Approve
Review via email: mp+153270@code.launchpad.net

Commit message

Copied hover details from daily.html to mine.html and review.html. Credits to mhall119.

Description of the change

Copied hover details from daily.html to mine.html and review.html.

To post a comment you must log in.
Revision history for this message
Michael Hall (mhall119) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'summit/schedule/templates/schedule/mine.html'
2--- summit/schedule/templates/schedule/mine.html 2012-04-15 02:34:02 +0000
3+++ summit/schedule/templates/schedule/mine.html 2013-03-14 01:21:22 +0000
4@@ -6,21 +6,6 @@
5
6 {% block head %}
7 {{ block.super }}
8-<script language="JavaScript">
9-
10-function show_agenda_details(agenda_id, index_id) {
11- var elem_id = 'agenda-'+agenda_id+'-'+index_id+'-details'
12- var details = document.getElementById(elem_id)
13- details.style.display='block';
14-}
15-
16-function hide_agenda_details(agenda_id, index_id) {
17- var elem_id = 'agenda-'+agenda_id+'-'+index_id+'-details'
18- var details = document.getElementById(elem_id)
19- details.style.display='none';
20-}
21-
22-</script>
23 <style>
24 TABLE img.icon {
25 vertical-align: bottom;
26@@ -87,7 +72,6 @@
27 {% block content %}
28 <div class="row">
29 <article class="span-12">
30-
31 <div class="schedule-head">
32 <h2>Meetings created by {{ drafter.name }}</h2>
33 </div>
34@@ -95,9 +79,31 @@
35 {% for meeting in meetings %}
36 <tr style="background-color: {{ meeting.track_color }}; {% if meeting.private %}border: 1px; border-style: solid; border-color: #FF0000;{% endif %}">
37 <td width="75%">
38+ <span onMouseOver="show_meeting_details({{meeting.id}});" onMouseOut="hide_meeting_details({{meeting.id}});">
39 <a href="{{ meeting.meeting_page_url }}" style="color: #000000;" class="main-agenda-item-name">
40 {{ meeting.title }}
41 </a>
42+<div id="meeting-{{meeting.id}}-details" class="agenda-details">
43+<div class="arrow"></div>
44+<div class="meeting-description">{{meeting.description}}</div>
45+{% if meeting.participant_set.count %}
46+<br /><b>Participants:</b>
47+<div>{% for participant in meeting.participant_set.all %}
48+ <div>
49+ {% if participant.required %}
50+ <img class="icon" src="/media/img/required.png" title="required" alt="(required)">
51+ {% else %}
52+ <img class="icon" src="/media/img/attending.png" alt="attending">
53+ {% endif %}{{ participant.attendee.user }}</div>
54+{% endfor %}</div>
55+{% endif %}
56+{% if meeting.tracks.count > 0 %}
57+<br /><b>Tracks:</b>
58+<ul>{% for track in meeting.tracks.all %}
59+ <li style="color: #{{track.color}};">{{ track.title }}</li>
60+{% endfor %}</ul>
61+{% endif %}
62+</div>
63 </td>
64 <td width="25%">
65 Status: {{ meeting.get_approved_display }}
66@@ -107,4 +113,23 @@
67 </table>
68 </article>
69 </div>
70+{% block closure %}
71+
72+<script language="JavaScript">
73+
74+function show_meeting_details(meeting_id) {
75+ var elem_id = 'meeting-'+meeting_id+'-details'
76+ var details = document.getElementById(elem_id)
77+ details.style.display='block';
78+}
79+
80+function hide_meeting_details(meeting_id) {
81+ var elem_id = 'meeting-'+meeting_id+'-details'
82+ var details = document.getElementById(elem_id)
83+ details.style.display='none';
84+}
85+
86+</script>
87+{% endblock %}
88+
89 {% endblock %}
90
91=== modified file 'summit/schedule/templates/schedule/review.html'
92--- summit/schedule/templates/schedule/review.html 2012-04-15 02:34:02 +0000
93+++ summit/schedule/templates/schedule/review.html 2013-03-14 01:21:22 +0000
94@@ -6,21 +6,6 @@
95
96 {% block extrahead %}
97 {{ block.super }}
98-<script language="JavaScript">
99-
100-function show_agenda_details(agenda_id, index_id) {
101- var elem_id = 'agenda-'+agenda_id+'-'+index_id+'-details'
102- var details = document.getElementById(elem_id)
103- details.style.display='block';
104-}
105-
106-function hide_agenda_details(agenda_id, index_id) {
107- var elem_id = 'agenda-'+agenda_id+'-'+index_id+'-details'
108- var details = document.getElementById(elem_id)
109- details.style.display='none';
110-}
111-
112-</script>
113 <style>
114 TABLE img.icon {
115 vertical-align: bottom;
116@@ -96,9 +81,31 @@
117 {% for meeting in meetings %}
118 <tr style="background-color: {{ meeting.track_color }}; {% if meeting.private %}border: 1px; border-style: solid; border-color: #FF0000;{% endif %}">
119 <td width="75%">
120+ <span onMouseOver="show_meeting_details({{meeting.id}});" onMouseOut="hide_meeting_details({{meeting.id}});">
121 <a href="{{ meeting.meeting_page_url }}" style="color: #000000;" class="main-agenda-item-name">
122 {{ meeting.title }}
123 </a>
124+<div id="meeting-{{meeting.id}}-details" class="agenda-details">
125+<div class="arrow"></div>
126+<div class="meeting-description">{{meeting.description}}</div>
127+{% if meeting.participant_set.count %}
128+<br /><b>Participants:</b>
129+<div>{% for participant in meeting.participant_set.all %}
130+ <div>
131+ {% if participant.required %}
132+ <img class="icon" src="/media/img/required.png" title="required" alt="(required)">
133+ {% else %}
134+ <img class="icon" src="/media/img/attending.png" alt="attending">
135+ {% endif %}{{ participant.attendee.user }}</div>
136+{% endfor %}</div>
137+{% endif %}
138+{% if meeting.tracks.count > 0 %}
139+<br /><b>Tracks:</b>
140+<ul>{% for track in meeting.tracks.all %}
141+ <li style="color: #{{track.color}};">{{ track.title }}</li>
142+{% endfor %}</ul>
143+{% endif %}
144+</div>
145 </td>
146 <td width="25%">
147 <a href="{% url summit.schedule.views.meeting_review summit.name meeting.id %}">Status: {{ meeting.get_approved_display }}</a>
148@@ -109,4 +116,23 @@
149 {% endfor%}
150 </article>
151 </div>
152+{% block closure %}
153+
154+<script language="JavaScript">
155+
156+function show_meeting_details(meeting_id) {
157+ var elem_id = 'meeting-'+meeting_id+'-details'
158+ var details = document.getElementById(elem_id)
159+ details.style.display='block';
160+}
161+
162+function hide_meeting_details(meeting_id) {
163+ var elem_id = 'meeting-'+meeting_id+'-details'
164+ var details = document.getElementById(elem_id)
165+ details.style.display='none';
166+}
167+
168+</script>
169+{% endblock %}
170+
171 {% endblock %}

Subscribers

People subscribed via source and target branches

to all changes: