Merge lp:~jose/loco-team-portal/irc-nick-fix into lp:loco-team-portal

Proposed by José Antonio Rey
Status: Merged
Approved by: Adnane Belmadiaf
Approved revision: 675
Merged at revision: 675
Proposed branch: lp:~jose/loco-team-portal/irc-nick-fix
Merge into: lp:loco-team-portal
Diff against target: 12 lines (+1/-1)
1 file modified
loco_directory/templates/irc_chat.html (+1/-1)
To merge this branch: bzr merge lp:~jose/loco-team-portal/irc-nick-fix
Reviewer Review Type Date Requested Status
Adnane Belmadiaf Approve
Review via email: mp+212331@code.launchpad.net

Commit message

Changed the default nick for the IRC user

Description of the change

Currently, people in the #ubuntu-locoteams channel are often confused by the existance of locodir-user. It would be good if we could have it as just another guest, and allow the person to choose the nick instead of giving the default of locodir-user, which makes the different users look like if they were just one.

* Changed the default nick for the IRC user

To post a comment you must log in.
Revision history for this message
Adnane Belmadiaf (daker) wrote :

LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/templates/irc_chat.html'
2--- loco_directory/templates/irc_chat.html 2012-05-26 12:20:08 +0000
3+++ loco_directory/templates/irc_chat.html 2014-03-23 20:58:47 +0000
4@@ -20,7 +20,7 @@
5 {% if user.is_authenticated %}
6 <iframe src="http://webchat.freenode.net/?channels=#ubuntu-locoteams&prompt=1&uio=MTE9MzE28&nick={{ user.username|irc }}" width="900" height="400"></iframe>
7 {% else %}
8- <iframe src="http://webchat.freenode.net/?channels=#ubuntu-locoteams&prompt=1&uio=MTE9MzE28&nick=locodir-user" width="900" height="400"></iframe>
9+ <iframe src="http://webchat.freenode.net/?channels=#ubuntu-locoteams&prompt=1&uio=MTE9MzE28" width="900" height="400"></iframe>
10 {% endif %}
11 </div>
12 </section></div>

Subscribers

People subscribed via source and target branches