Merge lp:~jose/charms/trusty/owncloud/fix-poodle into lp:charms/trusty/owncloud

[José Antonio Rey]

Fixed POODLE vulnerability.

[Charles Butler (lazypower)]

+1 LGTM - I left a note behind on the precise merge regarding checking the SSL configuration for your edification.

Thanks for the patch Jose!

review: Approve

[Charles Butler (lazypower)]

Ah wait, i didn't notice this is in install - what about existing deployments?

Can you move this to either upgrade-charm, or config-changed so we make sure we've fixed anythin gout there in the wild? Thanks!

review: Needs Fixing

[Review Queue (review-queue)]

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-10949-results

review: Needs Fixing (automated testing)

[lp:~jose/charms/trusty/owncloud/fix-poodle]

32. By José Antonio Rey on 2015-02-03

Moved from install to config-changed

[José Antonio Rey (jose)]

And moved to config-changed!

[Charles Butler (lazypower)]

+1 LGTM - deployed and checked, and poodle was not one of the listed vulnerabilities. Ty for moving this to config-changed.

Keep up the good work Jose!

review: Approve

=== modified file 'hooks/config-changed'
--- hooks/config-changed	2014-11-04 04:21:14 +0000
+++ hooks/config-changed	2015-02-03 07:09:12 +0000
@@ -170,7 +170,10 @@
 service apache2 start || :
 service apache2 reload
 
-
+if [ ! -f .fixpoodle ]; then
+    sed -i "s/SSLProtocol all/SSLProtocol all -SSLv3/g" /etc/apache2/mods-enabled/ssl.conf
+    touch .fixpoodle
+fi
 
 if [ ! -f .443 ]; then
     open-port 443