Merge lp:~jose/charms/precise/tracks/add-tests into lp:charms/tracks

[José Antonio Rey]

Add tests and fixed small bug on the install hook which prevented install

[Review Queue (review-queue)]

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-10342-results

review: Needs Fixing (automated testing)

[Adam Israel (aisrael)]

Hi José,

I had the opportunity to review this merge proposal today. I ran into a couple small issues in tests/10-deploy:

line 34 should reference tractions_relation instead of relation
line 43 is missing a closing parentheses
line 57 needs a % after the string

I also had to bump up the deployment timeout to 3600 in order for it to complete.

Unfortunately, the test failed once the timeout and the above issues were resolved:

2014-12-17 16:26:11 Starting deployment of local
2014-12-17 16:26:14 Deploying services...
2014-12-17 16:26:15 Deploying service mysql using cs:precise/mysql-50
2014-12-17 16:26:21 Deploying service tracks using cs:precise/tracks-5
2014-12-17 16:57:55 Adding relations...
2014-12-17 16:57:57 Adding relation tracks:db <-> mysql:db
2014-12-17 16:58:58 Exposing service 'tracks'
2014-12-17 16:58:59 Deployment complete in 1969.82 seconds
/usr/lib/python3/dist-packages/charmworldlib/api.py:18: ResourceWarning: unclosed <ssl.SSLSocket fd=5, family=AddressFamily.AF_INET, type=SocketType.SOCK_STREAM, proto=6, laddr=('192.168.1.147', 44436), raddr=('91.189.92.34', 443)>
  return self.fetch_json(endpoint, params, 'get')
/usr/lib/python3/dist-packages/charmworldlib/api.py:18: ResourceWarning: unclosed <ssl.SSLSocket fd=5, family=AddressFamily.AF_INET, type=SocketType.SOCK_STREAM, proto=6, laddr=('192.168.1.147', 44128), raddr=('91.189.92.33', 443)>
  return self.fetch_json(endpoint, params, 'get')
EE/usr/lib/python3.4/unittest/case.py:602: ResourceWarning: unclosed <socket.socket fd=6, family=AddressFamily.AF_INET, type=SocketType.SOCK_STREAM, proto=6, laddr=('10.0.3.1', 43307), raddr=('10.0.3.32', 80)>
  outcome.errors.clear()

======================================================================
ERROR: test_1_verify_mysql_rel (__main__.TestDeployment)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/stone/charms/precise/tracks/tests/10-deploy", line 39, in test_1_verify_mysql_rel
    user = tracks_relation['username']
KeyError: 'username'

======================================================================
ERROR: test_2_verify_tracks (__main__.TestDeployment)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/stone/charms/precise/tracks/tests/10-deploy", line 58, in test_2_verify_tracks
    amulet.raise_status(amulet.FAIL, msg=message)
  File "/usr/lib/python3/dist-packages/amulet/helpers.py", line 140, in raise_status
    sys.exit(code)
SystemExit: 1

----------------------------------------------------------------------
Ran 2 tests in 2057.725s

FAILED (errors=2)
private-address 10.0.3.32
private-address 10.0.3.192
user uwofaemaakaimoh
database tracks
password soxeibusahcheal
slave False
host 10.0.3.192
Tracks was not found running on 10.0.3.32

Thanks for your work on improving this charm! Feel free to reach out if you have any questions about my findings.

review: Needs Fixing

Unmerged revisions

8. By José Antonio Rey on 2014-11-11

Added tests and fixed small bug on install hook

=== modified file 'hooks/install'
--- hooks/install	2014-07-14 06:23:58 +0000
+++ hooks/install	2014-11-11 14:17:17 +0000
@@ -17,7 +17,7 @@
 libruby sqlite3 libmysql-ruby libmysql-ruby libsqlite3-ruby libsqlite3-dev \
 imagemagick graphicsmagick libgraphicsmagick1-dev librmagick-ruby \
 libxslt-dev libxml2-dev pwgen rubygems mysql-client wget ruby2.1-dev \
-libcap2-bin
+libcap2-bin git
 
 juju-log "installing tracks"
 cd /home/tracks/

=== added directory 'tests'
=== added file 'tests/00-setup'
--- tests/00-setup	1970-01-01 00:00:00 +0000
+++ tests/00-setup	2014-11-11 14:17:17 +0000
@@ -0,0 +1,5 @@
+#!/bin/bash
+
+sudo add-apt-repository ppa:juju/stable -y
+sudo apt-get update
+sudo apt-get install amulet python3-requests -y

=== added file 'tests/10-deploy'
--- tests/10-deploy	1970-01-01 00:00:00 +0000
+++ tests/10-deploy	2014-11-11 14:17:17 +0000
@@ -0,0 +1,64 @@
+#!/usr/bin/env python3
+
+import amulet
+import requests
+import unittest
+
+
+class TestDeployment(unittest.TestCase):
+    @classmethod
+    def setUpClass(cls):
+        cls.deployment = amulet.Deployment(series='precise')
+
+        cls.deployment.add('tracks')
+        cls.deployment.add('mysql')
+        cls.deployment.relate('tracks:db', 'mysql:db')
+        cls.deployment.expose('tracks')
+
+        try:
+            cls.deployment.setup(timeout=900)
+            cls.deployment.sentry.wait()
+        except amulet.helpers.TimeoutError:
+            amulet.raise_status(amulet.SKIP, msg="Environment wasn't stood up \
+                                in time")
+        except:
+            raise
+        cls.tracksunit = cls.deployment.sentry.unit['tracks/0']
+        cls.mysqlunit = cls.deployment.sentry.unit['mysql/0']
+        cls.ipaddr = cls.tracksunit.info['public-address']
+
+
+
+    def test_1_verify_mysql_rel(self):
+        tracks_relation = self.tracksunit.relation('db', 'mysql:db')
+        for key, value in relation.items():
+            print(key, value)
+        mysql_relation = self.mysqlunit.relation('db', 'tracks:db')
+        for key, value in mysql_relation.items():
+            print(key, value)
+        user = tracks_relation['username']
+        mysql_ip = mysql_relation['db_host']
+        mysql_password = mysql_relation['password']
+        cmd = 'mysqladmin status -h {0} -u {1} --password={2}'.format(mysql_ip,
+          mysql_user, mysql_password
+        output, code = self.tracks_unit.run(cmd)
+        if code != 0:
+            message = 'Unable to get MySQL status on %s' % mysql_ip
+            amulet.raise_status(amulet.FAIL, msg=message)
+        else:
+            print('Tracks <-> MySQL relation validated!')
+
+    def test_2_verify_tracks(self):
+        url = 'http://%s/' % self.ipaddr
+        r = requests.get(url)
+        text = 'Welcome to TRACKS'
+
+        if text not in r:
+            message = 'Tracks was not found running on %s' self.ipaddr
+            amulet.raise_status(amulet.FAIL, msg=message)
+        else:
+            print('Tracks was found running on %s!' % self.ipaddr)
+
+
+if __name__ == '__main__':
+    unittest.main()