Merge lp:~jose/charms/precise/sbuild/1297637-fix into lp:charms/sbuild

Proposed by José Antonio Rey
Status: Merged
Merged at revision: 7
Proposed branch: lp:~jose/charms/precise/sbuild/1297637-fix
Merge into: lp:charms/sbuild
Diff against target: 131 lines (+37/-35)
5 files modified
README (+0/-27)
README.md (+28/-0)
config.yaml (+3/-4)
hooks/config-changed (+4/-4)
metadata.yaml (+2/-0)
To merge this branch: bzr merge lp:~jose/charms/precise/sbuild/1297637-fix
Reviewer Review Type Date Requested Status
charmers Pending
Review via email: mp+212774@code.launchpad.net

Commit message

Fixed config.yaml and edited config-changed accordingly, reformatted README to Markdown

Description of the change

Charmworld reports the following errors:

    err: config.yaml: mk-sbuild.sources does not conform to naming pattern
    err: config.yaml: mk-sbuild.rc does not conform to naming pattern
    warn: Metadata is missing categories.
    warn: No icon.svg file.
    warn: config.yaml: option salt has unknown keys: validator
    warn: config.yaml: option mk-sbuild.sources does not have the keys: description
    warn: config.yaml: option mk-sbuild.sources has unknown keys: descption

Fixed them all except icon adding and reformatted README to be in Markdown

To post a comment you must log in.
8. By José Antonio Rey

Removed icon as it didn't comply with Charm Store policies

Revision history for this message
Charles Butler (lazypower) wrote :

Thanks Jose!

LGTM

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed file 'README'
2--- README 2012-06-18 16:15:49 +0000
3+++ README 1970-01-01 00:00:00 +0000
4@@ -1,27 +0,0 @@
5-This charm is designed to set up sbuild for a bug-squashing party.
6-
7-It _enables_ SSH passwords (after locking the ubuntu user's password), so
8-beware.
9-
10-Hacks to run remotely:
11- "hooks/wipe" for destroying all chroots.
12- "hooks/report $EXTERNAL_HOSTNAME" for reporting the state of a machine.
13-
14-
15-For example, to throw a bug-squashing party:
16-
17-...configure juju and sbuild.yaml for the password salt, distros, etc...
18-
19-juju boostrap
20-...time passes...
21-
22-juju deploy --config sbuild.yaml --repository /scratch/ubuntu/vcs/juju/examples local:sbuild builder-bsp
23-juju add-unit builder-bsp
24-juju add-unit builder-bsp
25-juju add-unit builder-bsp
26-...
27-
28-...time passes...
29-
30-# Dump reports printable on little slips of paper to hand out at the party:
31-./slips builder-bsp | mpage -1 | lp
32
33=== added file 'README.md'
34--- README.md 1970-01-01 00:00:00 +0000
35+++ README.md 2014-04-08 01:07:49 +0000
36@@ -0,0 +1,28 @@
37+This charm is designed to set up sbuild for a bug-squashing party.
38+
39+It _enables_ SSH passwords (after locking the ubuntu user's password), so
40+beware.
41+
42+Hacks to run remotely:
43+
44+ hooks/wipe
45+
46+for destroying all chroots.
47+
48+ hooks/report $EXTERNAL_HOSTNAME
49+
50+for reporting the state of a machine.
51+
52+# Usage
53+
54+For example, to throw a bug-squashing party, configure juju and sbuild.yaml for
55+the password salt, distros, etc, then execute:
56+
57+ juju boostrap
58+ juju deploy --config sbuild.yaml --repository /scratch/ubuntu/vcs/juju/examples local:sbuild builder-bsp
59+ juju add-unit builder-bsp
60+ juju add-unit builder-bsp
61+ juju add-unit builder-bsp
62+
63+ # Dump reports printable on little slips of paper to hand out at the party:
64+ ./slips builder-bsp | mpage -1 | lp
65
66=== modified file 'config.yaml'
67--- config.yaml 2012-11-20 10:15:37 +0000
68+++ config.yaml 2014-04-08 01:07:49 +0000
69@@ -11,7 +11,6 @@
70 type: string
71 default: unset
72 description: Salt for generating builder accounts.
73- validator: '.{8,}'
74 btsparty:
75 type: boolean
76 default: yes
77@@ -24,11 +23,11 @@
78 type: string
79 default: ""
80 description: Comma-separated list of extra packages to install in chroots.
81- mk-sbuild.rc:
82+ mksbuildrc:
83 type: string
84 default: ""
85 description: Contents of mk-sbuild.rc. See $ man mk-sbuild.
86- mk-sbuild.sources:
87+ mksbuildsources:
88 type: string
89 default: ""
90- descption: Conternts of ~/.mk-sbuild.sources. See $ man mk-sbuild.
91+ description: Conternts of ~/.mk-sbuild.sources. See $ man mk-sbuild.
92
93=== modified file 'hooks/config-changed'
94--- hooks/config-changed 2012-11-20 10:15:37 +0000
95+++ hooks/config-changed 2014-04-08 01:07:49 +0000
96@@ -13,18 +13,18 @@
97
98 CHROOTS=$(config-get chroots)
99 PACKAGES=$(config-get packages)
100-MK_SBUILD_RC=$(config-get mk-sbuild.rc)
101-MK_SBUILD_SOURCES=$(config-get mk-sbuild.sources)
102+MK_SBUILD_RC=$(config-get mksbuildrc)
103+MK_SBUILD_SOURCES=$(config-get mksbuildsources)
104 HOMEDIR=$(getent passwd $USERNAME | cut -d: -f 6)
105 if [ -n "$PACKAGES" ]; then
106 PACKAGES="--debootstrap-include=$PACKAGES"
107 fi
108 if [ -n "$MK_SBUILD_RC" ]; then
109- config-get mk-sbuild.rc -o $HOMEDIR/.mk-sbuild.rc
110+ config-get mksbuildrc -o $HOMEDIR/.mk-sbuild.rc
111 chown $USERNAME $HOMEDIR/.mk-sbuild.rc
112 fi
113 if [ -n "$MK_SBUILD_SOURCES" ]; then
114- config-get mk-sbuild.rc -o $HOMEDIR/.mk-sbuild.sources
115+ config-get mksbuildrc -o $HOMEDIR/.mk-sbuild.sources
116 chown $USERNAME $HOMEDIR/.mk-sbuild.sources
117 fi
118
119
120=== modified file 'metadata.yaml'
121--- metadata.yaml 2012-06-18 16:27:32 +0000
122+++ metadata.yaml 2014-04-08 01:07:49 +0000
123@@ -3,6 +3,8 @@
124 description: |
125 Installs an sbuild and schroot environment for package building.
126 maintainer: Kees Cook <kees@ubuntu.com>
127+categories:
128+ - misc
129 provides:
130 package-builder:
131 interface: sbuild

Subscribers

People subscribed via source and target branches

to all changes: