Merge lp:~jose/charms/precise/owncloud/fix-poodle into lp:charms/owncloud

[José Antonio Rey]

Fixed POODLE vulnerability.

[Charles Butler (lazypower)]

LGTM

just as a curiosity, have you run an owncloud deployment through the certification process on https://www.ssllabs.com/ssltest/? I use this almost exclusively when doing SSL work to verify I have built my keys correctly and have them implemented with perfect forward secrecy.

Not a requirement, but food for thought :)

review: Approve

[Charles Butler (lazypower)]

Ah wait, i didn't notice this is in install - what about existing deployments?

Can you move this to either upgrade-charm, or config-changed so we make sure we've fixed anythin gout there in the wild? Thanks!

review: Needs Fixing

[Review Queue (review-queue)]

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-10950-results

review: Needs Fixing (automated testing)

[lp:~jose/charms/precise/owncloud/fix-poodle]

30. By José Antonio Rey on 2015-02-03

Moved from install to config-changed

[José Antonio Rey (jose)]

Should be done now!

[Charles Butler (lazypower)]

+1 LGTM - deployed and checked site and poodle was not a listed vulnerability.

Thanks for this, keep up the good work Jose!

review: Approve

=== modified file 'hooks/config-changed'
--- hooks/config-changed	2014-07-21 21:59:37 +0000
+++ hooks/config-changed	2015-02-03 07:07:49 +0000
@@ -170,6 +170,10 @@
 service apache2 start || :
 service apache2 reload
 
+if [ ! -f .fixpoodle ]; then
+    sed -i "s/SSLProtocol all/SSLProtocol all -SSLv3/g" /etc/apache2/mods-enabled/ssl.conf
+    touch .fixpoodle
+fi
 
 
 if [ ! -f .443 ]; then