Merge lp:~jose/charms/precise/glance/add-blank-defaults into lp:~openstack-charmers-archive/charms/precise/glance/trunk

Proposed by José Antonio Rey
Status: Rejected
Rejected by: James Page
Proposed branch: lp:~jose/charms/precise/glance/add-blank-defaults
Merge into: lp:~openstack-charmers-archive/charms/precise/glance/trunk
Diff against target: 27 lines (+3/-0)
1 file modified
config.yaml (+3/-0)
To merge this branch: bzr merge lp:~jose/charms/precise/glance/add-blank-defaults
Reviewer Review Type Date Requested Status
James Page Disapprove
Review via email: mp+212880@code.launchpad.net

Commit message

Added blank defaults to missing defaults on config.yaml

Description of the change

Some options on the config.yaml file were missing defaults and charm proof didn't like that, added blank defaults.

To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote :

This is intentional.

review: Disapprove

Unmerged revisions

47. By José Antonio Rey

Added blank defaults for missing defaults

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2014-02-03 11:24:02 +0000
3+++ config.yaml 2014-03-26 16:08:08 +0000
4@@ -45,6 +45,7 @@
5 # HA configuration settings
6 vip:
7 type: string
8+ default: ""
9 description: "Virtual IP to use to front Glance API in ha configuration"
10 vip_iface:
11 type: string
12@@ -68,6 +69,7 @@
13 HA Cluster nodes.
14 ssl_cert:
15 type: string
16+ default: ""
17 description: |
18 SSL certificate to install and use for API ports. Setting this value
19 and ssl_key will enable reverse proxying, point Glance's entry in the
20@@ -75,6 +77,7 @@
21 issued by Keystone (if it is configured to do so).
22 ssl_key:
23 type: string
24+ default: ""
25 description: SSL key to use with certificate specified as ssl_cert.
26 rabbit-user:
27 default: glance

Subscribers

People subscribed via source and target branches