Merge lp:~jose/charms/precise/cinder/add-blank-defaults into lp:~openstack-charmers-archive/charms/precise/cinder/trunk

Proposed by José Antonio Rey
Status: Rejected
Rejected by: James Page
Proposed branch: lp:~jose/charms/precise/cinder/add-blank-defaults
Merge into: lp:~openstack-charmers-archive/charms/precise/cinder/trunk
Diff against target: 29 lines (+4/-0)
1 file modified
config.yaml (+4/-0)
To merge this branch: bzr merge lp:~jose/charms/precise/cinder/add-blank-defaults
Reviewer Review Type Date Requested Status
James Page Disapprove
Review via email: mp+212798@code.launchpad.net

Commit message

Added blank defaults to config.yaml

Description of the change

Added blank defaults where there was no defaults as charm proof didn't like it

To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote :

This is intentional.

review: Disapprove

Unmerged revisions

32. By José Antonio Rey

Added blank defaults to config.yaml

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2014-02-03 10:44:24 +0000
3+++ config.yaml 2014-03-26 09:20:59 +0000
4@@ -89,6 +89,7 @@
5 # HA configuration settings
6 vip:
7 type: string
8+ default: ""
9 description: "Virtual IP to use to front cinder API in ha configuration"
10 vip_iface:
11 type: string
12@@ -113,6 +114,7 @@
13 # Per-service HTTPS configuration.
14 ssl_cert:
15 type: string
16+ default: ""
17 description: |
18 SSL certificate to install and use for API ports. Setting this value
19 and ssl_key will enable reverse proxying, point Glance's entry in the
20@@ -120,7 +122,9 @@
21 issued by Keystone (if it is configured to do so).
22 ssl_key:
23 type: string
24+ default: ""
25 description: SSL key to use with certificate specified as ssl_cert.
26 config-flags:
27 type: string
28+ default: ""
29 description: Comma separated list of key=value config flags to be set in cinder.conf.

Subscribers

People subscribed via source and target branches