Code review comment for lp:~jose/charms/precise/bip/1297544-fix

Revision history for this message
Antonio Rosales (arosales) wrote :


Thanks for taking the time to improve the Bip charm. Your contribution to improve the Bip charm quality is much appreciated. I too saw this problem with Bip and deduced that charm proof wanted a yaml key that had 3 characters or greater, less than 3 characters filed proof. Your fix resolves that issue.

# I am providing a initial +1 review. A ~charmer will give a final review and merge this request if they don't have any additional feedback.

## Review points:
- charm proof bip' now pass
- deployment in EC2 successful
- I can successfully set the listen port.

### In summary this update to Bip lgtm, and makes charm proof happy.


« Back to merge proposal