Merge lp:~jose-exposito89/ubuntuone-ios-files/1163620 into lp:ubuntuone-ios-files
Proposed by
José Expósito
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Natalia Bidart | ||||
Proposed branch: | lp:~jose-exposito89/ubuntuone-ios-files/1163620 | ||||
Merge into: | lp:ubuntuone-ios-files | ||||
Diff against target: |
11 lines (+1/-0) 1 file modified
Files/U1FileDetailsViewController.m (+1/-0) |
||||
To merge this branch: | bzr merge lp:~jose-exposito89/ubuntuone-ios-files/1163620 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mike McCracken (community) | Needs Fixing | ||
Review via email: mp+170035@code.launchpad.net |
Description of the change
To post a comment you must log in.
Unmerged revisions
- 111. By José Expósito
-
Fixes identation
- 110. By José Expósito
-
Fixes https:/
/bugs.launchpad .net/ubuntuone- ios-files/ +bug/1163620
José, sorry for the delay in reviewing these branches. This looks fine - but would you mind switching the indentation on the line to match the rest of the file? That means using tabs.
Unfortunately in xcode this is not a per-project setting, and I know that's huge pain, and I personally prefer spaces to tabs, but it's not really worth it to fix every file.
Thanks.
(One way to fix this is to use emacs to edit, and dtrt-indent-mode, but I know xcode has nice completion features, so that's unappealing too.)