Merge lp:~jose-exposito89/ubuntuone-ios-files/1163620 into lp:ubuntuone-ios-files

Proposed by José Expósito
Status: Rejected
Rejected by: Natalia Bidart
Proposed branch: lp:~jose-exposito89/ubuntuone-ios-files/1163620
Merge into: lp:ubuntuone-ios-files
Diff against target: 11 lines (+1/-0)
1 file modified
Files/U1FileDetailsViewController.m (+1/-0)
To merge this branch: bzr merge lp:~jose-exposito89/ubuntuone-ios-files/1163620
Reviewer Review Type Date Requested Status
Mike McCracken (community) Needs Fixing
Review via email: mp+170035@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Mike McCracken (mikemc) wrote :

José, sorry for the delay in reviewing these branches. This looks fine - but would you mind switching the indentation on the line to match the rest of the file? That means using tabs.

Unfortunately in xcode this is not a per-project setting, and I know that's huge pain, and I personally prefer spaces to tabs, but it's not really worth it to fix every file.

Thanks.

(One way to fix this is to use emacs to edit, and dtrt-indent-mode, but I know xcode has nice completion features, so that's unappealing too.)

review: Needs Fixing
111. By José Expósito

Fixes identation

Revision history for this message
José Expósito (jose-exposito89) wrote :

Hi Mike, of course, I think that now all is correct. Thanks!

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Setting MP as Rejected to reduce numbers of landing candidates in @reviewlist.
Change status again if this MP is still current.

Unmerged revisions

111. By José Expósito

Fixes identation

110. By José Expósito

Fixes https://bugs.launchpad.net/ubuntuone-ios-files/+bug/1163620

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Files/U1FileDetailsViewController.m'
2--- Files/U1FileDetailsViewController.m 2013-05-31 17:51:33 +0000
3+++ Files/U1FileDetailsViewController.m 2013-08-11 22:58:18 +0000
4@@ -377,6 +377,7 @@
5 [titleLabel sizeToFit];
6 [self.nameLabel setText:self.title];
7 [self reflowFileInfoView];
8+ self.docController.URL = [NSURL fileURLWithPath:newNode.path];
9 }
10 }];
11 }

Subscribers

People subscribed via source and target branches