Merge lp:kmsistemas-openerp-addons into lp:ocb-addons/6.1

Proposed by Jordi Llinares - KM Sistemas
Status: Merged
Merged at revision: 6822
Proposed branch: lp:kmsistemas-openerp-addons
Merge into: lp:ocb-addons/6.1
Diff against target: 31 lines (+6/-1)
1 file modified
stock/report/report_stock_move.py (+6/-1)
To merge this branch: bzr merge lp:kmsistemas-openerp-addons
Reviewer Review Type Date Requested Status
Omar (Pexego) code review Approve
Pedro Manuel Baeza code review Approve
Stefan Rijnhart (Opener) Approve
Review via email: mp+198348@code.launchpad.net

Description of the change

[FIX] Fix of bug 1256619, where report_stock_inventory class had 'month' field wrongly declared and two fields missing in SQL view.

Regarding to Pedro's question related to my previous MP (which I have just deleted), the answer is Eclipse's "Auto-format editor contents before saving". I had purposely checked this quite a long time ago because I liked that feature. But when it comes to collaboration, I failed noticing all those space-after-comma unintentional changes. Just disabled it.

My bad, won't happen again. Regards.

To post a comment you must log in.
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Thanks, looking good!

review: Approve
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Jordi, thanks for the fix!

Regards.

review: Approve (code review)
Revision history for this message
Omar (Pexego) (omar7r) wrote :

LGTM

review: Approve (code review)
lp:kmsistemas-openerp-addons updated
6822. By Jordi Llinares - KM Sistemas

[FIX] stock: Fix of bug 1256619, where report_stock_inventory class had 'month' field wrongly declared and two fields missing in SQL view.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'stock/report/report_stock_move.py'
2--- stock/report/report_stock_move.py 2013-04-04 12:46:09 +0000
3+++ stock/report/report_stock_move.py 2013-12-10 08:43:28 +0000
4@@ -153,7 +153,8 @@
5 'date': fields.datetime('Date', readonly=True),
6 'year': fields.char('Year', size=4, readonly=True),
7 'month':fields.selection([('01','January'), ('02','February'), ('03','March'), ('04','April'),
8- ('05','May'), ('06','June'), ('07','July'), ('08','August'), ('09','September')]),
9+ ('05', 'May'), ('06', 'June'), ('07', 'July'), ('08', 'August'), ('09', 'September'),
10+ ('10', 'October'), ('11', 'November'), ('12', 'December')], 'Month', readonly = True),
11 'partner_id':fields.many2one('res.partner.address', 'Partner', readonly=True),
12 'product_id':fields.many2one('product.product', 'Product', readonly=True),
13 'product_categ_id':fields.many2one('product.category', 'Product Category', readonly=True),
14@@ -173,6 +174,8 @@
15 CREATE OR REPLACE view report_stock_inventory AS (
16 (SELECT
17 min(m.id) as id, m.date as date,
18+ to_char(m.date, 'YYYY') as year,
19+ to_char(m.date, 'MM') as month,
20 m.address_id as partner_id, m.location_id as location_id,
21 m.product_id as product_id, pt.categ_id as product_categ_id, l.usage as location_type,
22 m.company_id,
23@@ -196,6 +199,8 @@
24 ) UNION ALL (
25 SELECT
26 -m.id as id, m.date as date,
27+ to_char(m.date, 'YYYY') as year,
28+ to_char(m.date, 'MM') as month,
29 m.address_id as partner_id, m.location_dest_id as location_id,
30 m.product_id as product_id, pt.categ_id as product_categ_id, l.usage as location_type,
31 m.company_id,

Subscribers

People subscribed via source and target branches

to all changes: