Merge lp:~jorge/charms/precise/node-app/fix-node-readme into lp:charms/node-app

Proposed by Jorge Castro
Status: Merged
Approved by: Juan L. Negron
Approved revision: 32
Merge reported by: Juan L. Negron
Merged at revision: not available
Proposed branch: lp:~jorge/charms/precise/node-app/fix-node-readme
Merge into: lp:charms/node-app
Diff against target: 118 lines (+23/-25)
1 file modified
README.markdown (+23/-25)
To merge this branch: bzr merge lp:~jorge/charms/precise/node-app/fix-node-readme
Reviewer Review Type Date Requested Status
Juan L. Negron (community) Approve
Marco Ceppi (community) Approve
Review via email: mp+124716@code.launchpad.net

Description of the change

Update the README to reflect the charm store and the name "charm"

To post a comment you must log in.
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Changes look good, just one thing.

I'd remove the for loop, and instead use `juju add-unit -n10 myapp`

Otherwise, LGTM

review: Approve
32. By Jorge Castro

Of course we don't need a loop with add-unit!

Revision history for this message
Juan L. Negron (negronjl) wrote :

I agree with Marco about the loop ( take the loop out and just use -n<n> ).
Other than that, it looks good to me as well.

-Juan

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README.markdown'
2--- README.markdown 2011-09-30 20:09:18 +0000
3+++ README.markdown 2012-09-17 16:23:20 +0000
4@@ -1,44 +1,42 @@
5
6-# juju formula to deploy a user-defined node.js app
7+# juju charm to deploy a user-defined node.js app
8
9 This is an example
10 [juju](http://juju.ubuntu.com)
11-formula to deploy a user-defined node app
12+charm to deploy a user-defined node app
13 directly from revision control.
14
15-This formula will be maintained with a general set of hooks
16+This charm will be maintained with a general set of hooks
17 for various services that can be used with node apps
18 (like mongodb).
19
20
21-# Using this formula
22+# Using this charm
23
24 First, edit `config.yaml` to add info about your app.
25
26 Then deploy some basic services
27
28- $ juju deploy --repository ~/formulas node-app myapp
29- $ juju deploy --repository ~/formulas mongodb
30- $ juju deploy --repository ~/formulas haproxy
31+ juju deploy node-app myapp
32+ juju deploy mongodb
33+ juju deploy haproxy
34
35 relate them
36
37- $ juju add-relation mongodb myapp
38- $ juju add-relation myapp haproxy
39-
40-scale up your app
41-
42- $ for i in {1..10}; do
43- $ juju add-unit myapp
44- $ done
45+ juju add-relation mongodb myapp
46+ juju add-relation myapp haproxy
47+
48+scale up your app (to 10 nodes for example)
49+
50+ juju add-unit -n 10 myapp
51
52 open it up to the outside world
53
54- $ juju expose haproxy
55+ juju expose haproxy
56
57 Find the haproxy instance's public URL from
58
59- $ juju status
60+ juju status
61
62 (or attach it to an elastic IP via the aws console)
63 and open it up in a browser.
64@@ -60,16 +58,16 @@
65 - starts your node app as a service
66
67
68-## Formula configuration
69+## Charm configuration
70
71-Configurable aspects of the formula are listed in `config.yaml`
72+Configurable aspects of the charm are listed in `config.yaml`
73 and can be set by either editing the default values directly
74 in the yaml file or passing a `myapp.yaml` configuration
75 file during deployment
76
77- $ juju deploy --repository ~/formulas --config ~/myapp.yaml node-app myapp
78+ juju deploy --config ~/myapp.yaml node-app myapp
79
80-Some of these parameters are used directly by the formula,
81+Some of these parameters are used directly by the charm,
82 and some are passed through to the node app using `config/config.js`.
83
84 ## Application configuration
85@@ -104,7 +102,7 @@
86
87 ## Network access
88
89-This formula does not open any public ports itself.
90+This charm does not open any public ports itself.
91 The intention is to relate it to a proxy service like
92 `haproxy`, which will in turn open port 80 to the outside world.
93 This allows for instant horizontal scalability.
94@@ -117,7 +115,7 @@
95 to the bottom of the `install` hook, and then once your stack
96 is started, you expose
97
98- $ juju expose myapp
99+ juju expose myapp
100
101 it to the outside world.
102
103@@ -128,13 +126,13 @@
104
105 # Making this work with your node.js app
106
107-This formula makes some strong assumptions
108+This charm makes some strong assumptions
109 about the structure of the node application
110 (`config/config.js`) that might not apply to your app.
111 Please treat this formula as a template that
112 you can fork and modify to suit your needs.
113
114-The biggest difference between how the formula
115+The biggest difference between how the charm
116 behaves for different kind of apps is application
117 startup. A simple application will want to start
118 upon install (startup code goes in the `install` hook),

Subscribers

People subscribed via source and target branches

to all changes: