Merge lp:~jontai/openvista-gtm-integration/bug422885 into lp:openvista-gtm-integration

[Jon Tai]

[lp:~jontai/openvista-gtm-integration/bug422885]

90. By Jon Tai on 2009-10-19

Per Rick Marshall's suggestion, return the value of ^%ZOSF("CLUSTER") if it exists instead of hard-coding a string. This has a number of advantages -- it's backwards compatible for folks who are upgrading, it preserves the flexibility to have TaskMan configured differently on different machines, and it still allows cluster users to have a host-independent value if they need it.

[Jon Tai (jontai)]

Bump. Joel -- this is ready for review and merging now.

[JSHER (joel-sher)]

I assume the CLUSTER node is just manually set by a user.

review: Approve

[Jon Tai (jontai)]

> I assume the CLUSTER node is just manually set by a user.

Yes. We will likely set it manually to "GTM" in our progenitor databases, since that's the behavior we want most of the time. If we do a really really large deployment where we want multiple Task Managers, or if we do a deployment where we want Task Managers to be configured differently depending on which cluster node it's running on, we can unset the CLUSTER node.

=== modified file 'mumps/ZOSVGUX.m'
--- mumps/ZOSVGUX.m	2009-07-13 18:41:18 +0000
+++ mumps/ZOSVGUX.m	2009-10-19 23:41:13 +0000
@@ -1,4 +1,4 @@
-%ZOSV ;SFISC/AC,PUG/TOAD,HOU/DHW,MSC/JDA/JKT - View commands & special functions. ;13JUL2009
+%ZOSV ;SFISC/AC,PUG/TOAD,HOU/DHW,MSC/JDA/JKT - View commands & special functions. ;19OCT2009
  ;;8.0;KERNEL;**275,MSC**;Jul 10, 1995
  ;
 ACTJ() ; # active jobs
@@ -139,8 +139,10 @@
  S Y=0 Q
  ;
 GETENV ;Get environment Return Y='UCI^VOL^NODE^BOX LOOKUP'
+ ; see https://bugs.launchpad.net/openvista-gtm-integration/+bug/422885
  N %HOST,%V S %V=^%ZOSF("PROD"),%HOST=$$RETURN("hostname -s")
- S Y=$TR(%V,",","^")_"^"_%HOST_"^"_$P(%V,",",2)_":"_%HOST
+ N %CLUSTER S %CLUSTER=$G(^%ZOSF("CLUSTER")) I %CLUSTER="" S %CLUSTER=%HOST
+ S Y=$TR(%V,",","^")_"^"_%HOST_"^"_$P(%V,",",2)_":"_%CLUSTER
  Q
  ;
 VERSION(X) ;return OS version, X=1 - return OS