Merge lp:~jontai/openvista-gtm-integration/bug400432 into lp:openvista-gtm-integration

[Jon Tai]

[Jon Tai (jontai)]

I was hoping to push out a 0.8.4 release last night, but since I have GT.M 5.3-004 packaged, I figured we'd include it in this release. 5.3-003 is still available (and will remain available for sites who do not want to upgrade). 5.3-004 can be parallel-installed. Any new OpenVista instances added with ovinstanceadd will use the latest version of GT.M installed on the system.

The main reason I'm including this branch in the 0.8.4 release is beacuse it provides a new GT.M 5.3-003 package that makes the "groupdel gtm" in the postun script conditional - the gtm group is only removed if there are no other GT.M installations in /opt/lsb-gtm. This prevents the scenario where 5.3-004 is installed, all instances are upgraded (manually), and the administrator goes to remove 5.3-003, and the postun script removes the gtm group, breaking the system.

[lp:~jontai/openvista-gtm-integration/bug400432]

86. By Jon Tai on 2009-07-20

explicitly depend on gpgme, libgpg-error, and libgcrypt

[jeff.apple (jeff-apple)]

review: Approve

=== modified file 'packages/rpm/fis-gtm-5.3003.spec'
--- packages/rpm/fis-gtm-5.3003.spec	2009-07-08 04:10:08 +0000
+++ packages/rpm/fis-gtm-5.3003.spec	2009-07-18 00:45:57 +0000
@@ -16,7 +16,7 @@
 
 Name:		fis-gtm-5.3003
 Version:	5.3003
-Release:	2
+Release:	3
 Summary:	High end TP schemaless database
 License:	AGPL
 Vendor:		Fidelity Information Services
@@ -138,10 +138,13 @@
 /sbin/restorecon %{gtm_dist}/libgtmshr.so || :
 
 %postun
-# Remove libgtmshr.so from the SELinux policy if we're removing the package
-#
-# See http://fedoraproject.org/wiki/PackagingDrafts/SELinux
 if [ $1 -eq 0 ]; then
+    # Remove libgtmshr.so from the SELinux policy if we're removing the package
+    # See http://fedoraproject.org/wiki/PackagingDrafts/SELinux
     /usr/sbin/semanage fcontext -d -t textrel_shlib_t %{gtm_dist}/libgtmshr.so 2>/dev/null || :
-    /usr/sbin/groupdel gtm 2> /dev/null || :
+
+    # if we were the last GT.M package on the system, remove the gtm group
+    if [ ! -d /opt/lsb-gtm ]; then
+        /usr/sbin/groupdel gtm 2> /dev/null || :
+    fi
 fi

=== added file 'packages/rpm/fis-gtm-5.3004.spec'
--- packages/rpm/fis-gtm-5.3004.spec	1970-01-01 00:00:00 +0000
+++ packages/rpm/fis-gtm-5.3004.spec	2009-07-18 00:45:57 +0000
@@ -0,0 +1,151 @@
+# FIXME: this is a pretty bad RPM:
+#  - It requires that gtm_curpro already exists on the build box
+#  - It requires that gtm_dist does not already exist on the build box
+#  - It requires the RPM be built as root
+#  - The arch is wrong (?) - GT.M requires i686 but this package is marked i386
+
+# This must point to an existing binary installation of GT.M because GT.M
+# requires GT.M to build
+%define gtm_curpro /tmp/gtm
+
+%ifarch x86_64
+%define gtm_dist /opt/lsb-gtm/V5.3-004_x86_64
+%else
+%define gtm_dist /opt/lsb-gtm/V5.3-004_i686
+%endif
+
+Name:		fis-gtm-5.3004
+Version:	5.3004
+Release:	3
+Summary:	High end TP schemaless database
+License:	AGPL
+Vendor:		Fidelity Information Services
+URL:		http://www.fidelityinfoservices.com/FNFIS/Markets/NonFinancialIndustries/Healthcare/GTM/
+Group:		Applications/Databases
+Packager:	Jonathan Tai <[e-mail]>
+
+Provides:	fis-gtm
+
+Requires(pre):		/usr/sbin/groupadd
+Requires(post):		/usr/sbin/semanage, /sbin/restorecon
+Requires(postun):	/usr/sbin/semanage, /usr/sbin/groupdel
+
+Requires:	/bin/sh, coreutils, libicu, zlib, ncurses
+BuildRequires:	/bin/tcsh, libicu-devel, zlib-devel, ncurses-devel, gpgme-devel, libgpg-error-devel, libgcrypt-devel
+
+%ifarch x86_64
+BuildRequires:	elfutils-libelf-devel
+%endif
+
+# The source for both i686 and x86_64 versions are both in this tarball, even
+# though the tarball is named i686_src
+Source:		gtm_V53004_linux_i686_src.tar.gz
+
+# Patch the configure script to pre-answer all of the prompts and set the
+# installation directory
+Patch1:		fis-gtm-5.3004_noninteractive-configure.patch
+
+Patch2:		fis-gtm-5.3004_configure-fix.patch
+
+BuildRoot:	%{_tmppath}/%{name}-root
+
+%description
+GT.M is a vetted, industrial strength, transaction processing application
+platform consisting of a schema-less database engine optimized for extreme
+transaction processing throughput & business continuity plus a compiler for the
+MUMPS language.
+
+%prep
+if [ ! -d "%{gtm_curpro}" ]; then
+    echo "existing binary installation of GT.M not found at %{gtm_curpro}"
+    exit 1
+fi
+
+if [ -d "%{gtm_dist}" ]; then
+    echo "target GT.M directory %{gtm_dist} already exists"
+    exit 1
+fi
+
+if ! grep '^gtm:' /etc/group > /dev/null; then
+    echo "gtm group not found in /etc/group"
+    exit 1
+fi
+
+if [ `/usr/bin/id -u` -ne 0 ]; then
+    echo "this RPM must be built as root"
+    exit 1
+fi 
+%setup -c
+%patch2 -p0
+
+%build
+# GT.M needs to be built with tcsh, and with a bunch of environmental variables
+# set.  Since we can't run tcsh interactively, we put all the setenv commands
+# and the build command itself into a temporary script, then execute it with
+# tcsh.
+echo 'setenv gtm_curpro %{gtm_curpro}' > build.csh
+echo 'setenv gtm_exe %{gtm_curpro}' >> build.csh
+echo 'setenv HOSTOS `uname -s`' >> build.csh
+echo 'setenv gtm_tools '$(pwd)'/sr_linux' >> build.csh
+echo 'setenv gtm_inc '$(pwd)'/sr_linux' >> build.csh
+%ifarch x86_64
+echo 'setenv OBJECT_MODE 64' >> build.csh
+%endif
+echo 'setenv gtm_icu_version `icu-config --version`' >> build.csh
+echo 'setenv gtm_version_change 1' >> build.csh
+cat sr_unix/gtm_env.csh >> build.csh
+echo 'make -f sr_unix/comlist.mk -I./sr_unix -I./sr_linux buildtypes=pro gtm_ver='$(pwd) >> build.csh
+tcsh -b build.csh
+rm -f build.csh
+
+# Put a copy of the COPYING file in the pro directory so that it will be
+# installed by the ./configure script later
+cp COPYING pro
+
+%install
+rm -rf %{buildroot}
+
+mkdir -p $(dirname %{gtm_dist})
+
+cd pro
+# We need to patch the configure script to pre-answer all of the prompts and
+# set the installation directory
+sed 's,@GTMDIST@,%{gtm_dist},' < %{PATCH1} | patch -p0 -b
+chmod +x configure
+./configure
+
+mkdir -p %{buildroot}$(dirname %{gtm_dist})
+mv %{gtm_dist} %{buildroot}$(dirname %{gtm_dist})
+
+%clean
+rm -rf %{buildroot}
+
+%files
+%defattr(-,-,-)
+/opt/lsb-gtm
+
+%pre
+/usr/sbin/groupadd gtm 2> /dev/null || :
+
+%post
+# GT.M's installation script just chcon directly, but it won't have any effect
+# on the target system (only on the build system, and then only if SELinux is
+# enabled on the build system).  On the target system, we should use semanage
+# to save the correct context for libgtmshr.so in the SELinux policy.  This
+# will ensure that the file has the correct context, even after relabling. 
+#
+# See http://fedoraproject.org/wiki/PackagingDrafts/SELinux
+/usr/sbin/semanage fcontext -a -t textrel_shlib_t %{gtm_dist}/libgtmshr.so 2>/dev/null || :
+/sbin/restorecon %{gtm_dist}/libgtmshr.so || :
+
+%postun
+if [ $1 -eq 0 ]; then
+    # Remove libgtmshr.so from the SELinux policy if we're removing the package
+    # See http://fedoraproject.org/wiki/PackagingDrafts/SELinux
+    /usr/sbin/semanage fcontext -d -t textrel_shlib_t %{gtm_dist}/libgtmshr.so 2>/dev/null || :
+
+    # if we were the last GT.M package on the system, remove the gtm group
+    if [ ! -d /opt/lsb-gtm ]; then
+        /usr/sbin/groupdel gtm 2> /dev/null || :
+    fi
+fi

=== added file 'packages/rpm/fis-gtm-5.3004_configure-fix.patch'
--- packages/rpm/fis-gtm-5.3004_configure-fix.patch	1970-01-01 00:00:00 +0000
+++ packages/rpm/fis-gtm-5.3004_configure-fix.patch	2009-07-18 00:42:00 +0000
@@ -0,0 +1,23 @@
+--- sr_unix/configure.gtc	2009-07-10 08:31:45.000000000 -0700
++++ sr_unix/configure.gtc	2009-07-14 11:06:21.000000000 -0700
+@@ -208,9 +208,9 @@
+ 		is64bit_gtm=`file mumps | grep "64-bit" | wc -l`
+ 	fi
+ 	if [ $is64bit_gtm -eq 1 ] ; then
+-		library_path="/usr/local/lib64 /usr/local/lib /usr/lib /usr/lib32"
++		library_path="/usr/local/lib64 /usr/local/lib /usr/lib64 /usr/lib /lib64 /lib"
+ 	else
+-		library_path="/usr/local/lib /usr/lib /usr/lib32"
++		library_path="/usr/local/lib32 /usr/local/lib /usr/lib32 /usr/lib /lib32 /lib"
+ 	fi
+ 	$echo "Should unicode support be installed? (y or n) \c"
+ 	read resp
+@@ -303,7 +303,7 @@
+ 			fi
+ 		done
+ 		if [ "$found_icu" -eq 0 ] ; then
+-			if [ $majmin != "" ] ; then
++			if [ "$majmin" != "" ] ; then
+ 				echo "WARNING: ICU version $gtm_icu_version not found. Not installing Unicode support."
+ 			else
+ 				echo "WARNING: Default ICU version not found. Not installing Unicode support."

=== added file 'packages/rpm/fis-gtm-5.3004_noninteractive-configure.patch'
--- packages/rpm/fis-gtm-5.3004_noninteractive-configure.patch	1970-01-01 00:00:00 +0000
+++ packages/rpm/fis-gtm-5.3004_noninteractive-configure.patch	2009-07-16 23:02:21 +0000
@@ -0,0 +1,78 @@
+--- configure	2009-07-16 15:26:02.000000000 -0700
++++ configure	2009-07-16 15:28:00.000000000 -0700
+@@ -112,7 +112,7 @@
+ # create temporary file to test for valid user and group names
+ touch tmp_owngrp
+ $echo "What account should own the files? (bin) \c"
+-read resp
++resp=""
+ if [ "$resp" = "" ] ; then
+ 	owner="bin"
+ else
+@@ -126,10 +126,10 @@
+ fi
+ 
+ $echo "Should execution of GT.M to be restricted to a group? (y or n) \c"
+-read resp
++resp="y"
+ if [ "$resp" = "Y" -o "$resp" = "y" ] ; then
+ 	$echo "Enter group name? \c"
+-	read group
++	group="gtm"
+ 	if [ "$group" != "" ] ; then
+ 		chgrp $group tmp_owngrp 2> /dev/null
+ 		if [ 1 = "$?" ] ; then
+@@ -145,7 +145,7 @@
+ rm tmp_owngrp
+ 
+ $echo "In what directory should GT.M be installed? \c"
+-read gtmdist
++gtmdist="@GTMDIST@"
+ 
+ # if gtmdist is relative then need to make it absolute
+ 
+@@ -171,7 +171,7 @@
+ 	$echo "Directory $gtmdist does not exist. Do you wish to create it as part of"
+ 	$echo "this installation? (y or n) \c"
+ 
+-	read resp
++	resp="y"
+ 	if [ "$resp" = "Y" -o "$resp" = "y" ] ; then
+ 		mkdir -p $gtmdist
+ 		chmod 0755 $gtmdist
+@@ -213,14 +213,14 @@
+ 		library_path="/usr/local/lib32 /usr/local/lib /usr/lib32 /usr/lib /lib32 /lib"
+ 	fi
+ 	$echo "Should unicode support be installed? (y or n) \c"
+-	read resp
++	resp="y"
+ 	if [ "$resp" = "Y" -o "$resp" = "y" ] ; then
+ 		would_like_utf8=1
+ 		$echo "Should an ICU version other than the default be used? (y or n) \c"
+-		read resp
++		resp="y"
+ 		if [ "$resp" = "Y" -o "$resp" = "y" ] ; then
+ 			$echo "Enter ICU version (at least ICU version 3.6 is required. Enter as <minor-ver>.<major-ver>): \c"
+-			read gtm_icu_version
++			gtm_icu_version="3.6"
+ 			icu_ver=`$echo $gtm_icu_version | sed 's/\.//'`
+ 			majmin=`$echo $icu_ver | cut -f 1 -d "."`
+ 			if [ "$majmin" -lt "36" ] ; then
+@@ -567,7 +567,7 @@
+ $echo "only the uppercase versions of the files."
+ $echo ""
+ $echo "Do you want uppercase and lowercase versions of the MUMPS routines? (y or n)\c"
+-read resp
++resp="n"
+ if [ "$resp" = "Y" -o "$resp" = "y" ] ; then
+ 	$echo ""
+ 	$echo "Creating lowercase versions of the MUMPS routines."
+@@ -768,7 +768,7 @@
+ $echo ""
+ $echo "Installation completed. Would you like all the temporary files"
+ $echo "removed from this directory? (y or n) \c"
+-read resp
++resp="y"
+ 
+ if [ "$resp" = "Y" -o "$resp" = "y" ] ; then
+ 	\rm -rf $binaries $pathmods $rscripts $nscripts $dirs configure \

=== added file 'packages/rpm/openvista-libs-5.3004.spec'
--- packages/rpm/openvista-libs-5.3004.spec	1970-01-01 00:00:00 +0000
+++ packages/rpm/openvista-libs-5.3004.spec	2009-07-18 03:03:33 +0000
@@ -0,0 +1,86 @@
+%ifarch x86_64
+%define gtm_dist /opt/lsb-gtm/V5.3-004_x86_64
+%else
+%define gtm_dist /opt/lsb-gtm/V5.3-004_i686
+%endif
+
+Name:		openvista-libs-5.3004
+Version:	0.8.4
+Release:	1
+Summary:	GT.M External Calls for OpenVista
+License:	AGPL
+Vendor:		Medsphere Systems Corporation
+URL:		https://medsphere.org/community/project/gtm
+Group:		Applications/System
+Packager:	Jonathan Tai <[e-mail]>
+
+Provides:	openvista-libs
+
+Requires(post):		/usr/sbin/semanage, /sbin/restorecon
+Requires(postun):	/usr/sbin/semanage
+
+Requires:	fis-gtm-5.3004
+BuildRequires:	fis-gtm-5.3004
+
+Obsoletes:	openvista-libs
+
+Source:		openvista-libs-5.3004-%{version}.tar.bz2
+BuildRoot:	%{_tmppath}/%{name}-root
+
+%description
+OpenVista is a cost-effective, open, trusted and complete EHR which enhances
+patient safety, increases clinical and operational efficiency and provides an
+opportunity to improve quality of care delivery.
+
+This package provides a shared library that OpenVista code running in GT.M
+calls out to for PAM authentication and duplicating a device onto a spawned
+child's stdin/stdout.  This package also provides an suid wrapper around GT.M
+utilities used to send signals to other GT.M processes.
+
+%prep
+%setup
+
+%build
+cd src/libopenvista
+echo 'export gtm_dist="%{gtm_dist}"' > env
+. ./env
+./compile.sh
+
+cd ../../
+
+cd src/gtmsignal
+./compile.sh
+
+%install
+rm -rf %{buildroot}
+
+install -d %{buildroot}%{gtm_dist}
+install -m 550 src/libopenvista/libopenvista.so %{buildroot}%{gtm_dist}
+install -m 440 src/libopenvista/openvista.xc %{buildroot}%{gtm_dist}
+install -m 4550 src/gtmsignal/gtmsignal %{buildroot}%{gtm_dist}
+
+%clean
+rm -rf %{buildroot}
+
+%files
+%defattr(-,root,root)
+%doc README
+%doc COPYING
+%doc COPYING.AGPL
+%doc NEWS
+%defattr(-,bin,gtm)
+%{gtm_dist}/libopenvista.so
+%{gtm_dist}/openvista.xc
+%defattr(-,root,gtm)
+%{gtm_dist}/gtmsignal
+
+%post
+# See http://fedoraproject.org/wiki/PackagingDrafts/SELinux
+/usr/sbin/semanage fcontext -a -t textrel_shlib_t %{gtm_dist}/libopenvista.so 2>/dev/null || :
+/sbin/restorecon %{gtm_dist}/libopenvista.so || :
+
+%postun
+# See http://fedoraproject.org/wiki/PackagingDrafts/SELinux
+if [ $1 -eq 0 ]; then
+    /usr/sbin/semanage fcontext -d -t textrel_shlib_t %{gtm_dist}/libopenvista.so 2>/dev/null || :
+fi

=== modified file 'scripts/usr/bin/ovcc'
--- scripts/usr/bin/ovcc	2009-07-17 08:17:11 +0000
+++ scripts/usr/bin/ovcc	2009-07-18 03:01:31 +0000
@@ -88,6 +88,12 @@
 # garbled (both JOBs will write to them in no particular order) 
 cd "$root/$instance/tmp"
 
+# ensure that $PRINCIPAL is initialized to a NOCENABLE state.  This removes a
+# minuscule window where GT.M might recognize a <CTRL-C> and enter direct mode
+# even if a USE $PRINCIPAL:NOCENABLE was the very first command executed.
+gtm_nocenable=1
+export gtm_nocenable
+
 # use exec to replace this script with the mumps process; this ensures that an
 # ovcc user's session will end when the mumps process finishes (either
 # gracefully or otherwise)

=== modified file 'scripts/usr/bin/ovtied'
--- scripts/usr/bin/ovtied	2009-07-17 08:17:11 +0000
+++ scripts/usr/bin/ovtied	2009-07-18 03:01:31 +0000
@@ -88,6 +88,12 @@
 # garbled (both JOBs will write to them in no particular order) 
 cd "$root/$instance/tmp"
 
+# ensure that $PRINCIPAL is initialized to a NOCENABLE state.  This removes a
+# minuscule window where GT.M might recognize a <CTRL-C> and enter direct mode
+# even if a USE $PRINCIPAL:NOCENABLE was the very first command executed.
+gtm_nocenable=1
+export gtm_nocenable
+
 # use exec to replace this script with the mumps process; this ensures that a
 # tied user's session will end when the mumps process finishes (either
 # gracefully or otherwise)