Merge lp:~jontai/openvista-gtm-integration/bug383367 into lp:openvista-gtm-integration

Proposed by Jon Tai
Status: Merged
Merged at revision: not available
Proposed branch: lp:~jontai/openvista-gtm-integration/bug383367
Merge into: lp:openvista-gtm-integration
Diff against target: None lines
To merge this branch: bzr merge lp:~jontai/openvista-gtm-integration/bug383367
Reviewer Review Type Date Requested Status
jeff.apple Approve
Review via email: mp+7049@code.launchpad.net
To post a comment you must log in.
Revision history for this message
jeff.apple (jeff-apple) wrote :

This works around the symptom and is good enough. It may be a cleaner approach to create $tempdir in /tmp, though.

review: Approve
Revision history for this message
Jon Tai (jontai) wrote :

> This works around the symptom and is good enough. It may be a cleaner approach
> to create $tempdir in /tmp, though.

Then you'd run into the same problem if you unpacked your routines in /tmp and tried to import from there.

I don't want to exclude importing *all* directories because I want to leave the door open for multiple routine tiers in the future, so not copying dot directories is the only remaining sane behavior.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/usr/bin/ovimport'
2--- scripts/usr/bin/ovimport 2009-05-12 23:02:05 +0000
3+++ scripts/usr/bin/ovimport 2009-06-03 21:36:14 +0000
4@@ -217,7 +217,7 @@
5
6 (
7 umask 007
8- rsync -rl --include '*/' --include '*.m' --exclude '*' "$real_routines/" "$root/$instance/routines/"
9+ rsync -rl --exclude '.*/' --include '*/' --include '*.m' --exclude '*' "$real_routines/" "$root/$instance/routines/"
10 ) || exit_with_error "ovimport" "Unable to import routines"
11
12 # the umask is not enough to guarantee that the routines are user

Subscribers

People subscribed via source and target branches