Merge lp:~jonathanharker/wikkid/gravatar-lowercase into lp:wikkid

Proposed by Jonathan Harker
Status: Merged
Approved by: Tim Penhey
Approved revision: 53
Merged at revision: 55
Proposed branch: lp:~jonathanharker/wikkid/gravatar-lowercase
Merge into: lp:wikkid
Diff against target: 11 lines (+1/-1)
1 file modified
wikkid/user/baseuser.py (+1/-1)
To merge this branch: bzr merge lp:~jonathanharker/wikkid/gravatar-lowercase
Reviewer Review Type Date Requested Status
Tim Penhey Approve
Review via email: mp+41406@code.launchpad.net

Description of the change

Now converts email to lower case first

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

It looks like you forgot to push your branch.

53. By Jonathan Harker

Ensure the email is in lower case for the Gravatar MD5 hash.

Revision history for this message
Jonathan Harker (jonathanharker) wrote :

Pushed now - bzr no longer segfaulting \o/

Revision history for this message
Tim Penhey (thumper) wrote :

Did you fix the underlying problem with bzr?

Revision history for this message
Tim Penhey (thumper) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'wikkid/user/baseuser.py'
2--- wikkid/user/baseuser.py 2010-05-25 22:12:26 +0000
3+++ wikkid/user/baseuser.py 2010-11-21 03:48:08 +0000
4@@ -17,6 +17,6 @@
5 @property
6 def gravatar(self):
7 url = "http://www.gravatar.com/avatar/"
8- url += hashlib.md5(self.email).hexdigest()
9+ url += hashlib.md5(self.email.lower()).hexdigest()
10 url += "?s=50&d=identicon"
11 return url

Subscribers

People subscribed via source and target branches