ulysses

Merge lp:~jonas-drange/ulysses/test-search into lp:ulysses

  1. test-search
  2. Merge into trunk
Proposed by Jonas G. Drange
Status: Merged
Approved by: Jonas G. Drange
Approved revision: 35
Merged at revision: 35
Proposed branch: lp:~jonas-drange/ulysses/test-search
Merge into: lp:ulysses
Diff against target: 34 lines (+4/-0)
2 files modified
test/visual/config/desktop.js (+2/-0)
test/visual/config/smallscreen.js (+2/-0)
To merge this branch: bzr merge lp:~jonas-drange/ulysses/test-search
Reviewer Review Type Date Requested Status
Stephen Stewart (community) Approve
Review via email: mp+214600@code.launchpad.net

Commit message

regression tests for the two new navbar patterns: search with button and search with indicator

To post a comment you must log in.
Revision history for this message
Stephen Stewart (stephen-stewart) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'test/visual/config/desktop.js'
2--- test/visual/config/desktop.js 2014-04-03 15:40:39 +0000
3+++ test/visual/config/desktop.js 2014-04-07 19:54:27 +0000
4@@ -19,6 +19,8 @@
5 phantomcss.screenshot('[data-qa="navbar-full"]', 'Full Navbar');
6 phantomcss.screenshot('[data-qa="navbar-button"]', 'Navbar with button');
7 phantomcss.screenshot('[data-qa="navbar-secondary-text"]', 'Navbar with secondary text');
8+ phantomcss.screenshot('[data-qa="navbar-search"]', 'Navbar with search');
9+ phantomcss.screenshot('[data-qa="navbar-search-indicator"]', 'Navbar with search (indicator)');
10
11 // forms
12 phantomcss.screenshot('[data-qa="default-form"]', 'Default form');
13
14=== modified file 'test/visual/config/smallscreen.js'
15--- test/visual/config/smallscreen.js 2014-03-06 17:35:25 +0000
16+++ test/visual/config/smallscreen.js 2014-04-07 19:54:27 +0000
17@@ -5,6 +5,8 @@
18 phantomcss.screenshot('[data-qa="navbar-simple"]', 'Simple Navbar');
19 phantomcss.screenshot('[data-qa="navbar-invert"]', 'Invert Navbar');
20 phantomcss.screenshot('[data-qa="navbar-full"]', 'Full Navbar');
21+ phantomcss.screenshot('[data-qa="navbar-search"]', 'Navbar with search');
22+ phantomcss.screenshot('[data-qa="navbar-search-indicator"]', 'Navbar with search (indicator)');
23 });
24
25 casper.then( function end_it(){
26
27=== added file 'test/visual/screenshots/desktop/Navbar with search (indicator)_12.png'
28Binary files test/visual/screenshots/desktop/Navbar with search (indicator)_12.png 1970-01-01 00:00:00 +0000 and test/visual/screenshots/desktop/Navbar with search (indicator)_12.png 2014-04-07 19:54:27 +0000 differ
29=== added file 'test/visual/screenshots/desktop/Navbar with search_11.png'
30Binary files test/visual/screenshots/desktop/Navbar with search_11.png 1970-01-01 00:00:00 +0000 and test/visual/screenshots/desktop/Navbar with search_11.png 2014-04-07 19:54:27 +0000 differ
31=== added file 'test/visual/screenshots/smallscreen/Navbar with search (indicator)_4.png'
32Binary files test/visual/screenshots/smallscreen/Navbar with search (indicator)_4.png 1970-01-01 00:00:00 +0000 and test/visual/screenshots/smallscreen/Navbar with search (indicator)_4.png 2014-04-07 19:54:27 +0000 differ
33=== added file 'test/visual/screenshots/smallscreen/Navbar with search_3.png'
34Binary files test/visual/screenshots/smallscreen/Navbar with search_3.png 1970-01-01 00:00:00 +0000 and test/visual/screenshots/smallscreen/Navbar with search_3.png 2014-04-07 19:54:27 +0000 differ

Subscribers

People subscribed via source and target branches