Ubuntu UI Toolkit Extras

Merge lp:~jonas-drange/ubuntu-ui-extras/no-loading-of-empty-default into lp:~phablet-team/ubuntu-ui-extras/printer-components

  1. no-loading-of-empty-default
  2. Merge into printer-components
Proposed by Jonas G. Drange
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 129
Merged at revision: 129
Proposed branch: lp:~jonas-drange/ubuntu-ui-extras/no-loading-of-empty-default
Merge into: lp:~phablet-team/ubuntu-ui-extras/printer-components
Diff against target: 11 lines (+1/-1)
1 file modified
modules/Ubuntu/Components/Extras/Printers/printers/printers.cpp (+1/-1)
To merge this branch: bzr merge lp:~jonas-drange/ubuntu-ui-extras/no-loading-of-empty-default
Reviewer Review Type Date Requested Status
Andrew Hayzen (community) Approve
Review via email: mp+317982@code.launchpad.net

Commit message

removes {} which caused a non-printer to always be loaded if no default

Description of the change

removes {} which caused a non-printer to always be loaded if no default

To post a comment you must log in.
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/Extras/Printers/printers/printers.cpp'
2--- modules/Ubuntu/Components/Extras/Printers/printers/printers.cpp 2017-02-21 10:46:29 +0000
3+++ modules/Ubuntu/Components/Extras/Printers/printers/printers.cpp 2017-02-22 14:37:03 +0000
4@@ -81,7 +81,7 @@
5 }
6
7 // Eagerly load the default printer.
8- if (!m_backend->defaultPrinterName().isEmpty()) {}
9+ if (!m_backend->defaultPrinterName().isEmpty())
10 m_backend->requestPrinter(m_backend->defaultPrinterName());
11 }
12

Subscribers

People subscribed via source and target branches