Code review comment for lp:~jonas-drange/ubuntu-ui-extras/consolidated-devices

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Looks good so far, just 3 inline comments.

1) It seems like this should be set?

Otherwise further down this if will be false
if (makeLower == "hp") {
...
}

2) Same here

3) Should this then do
makeLower = make.toLower();

review: Needs Fixing

« Back to merge proposal