Merge lp:~jonas-drange/ubuntu-system-settings/wifi-other-network-label-fix-1365984 into lp:ubuntu-system-settings

Proposed by Jonas G. Drange
Status: Merged
Approved by: Ken VanDine
Approved revision: 1021
Merged at revision: 1040
Proposed branch: lp:~jonas-drange/ubuntu-system-settings/wifi-other-network-label-fix-1365984
Merge into: lp:ubuntu-system-settings
Diff against target: 25 lines (+2/-2)
2 files modified
plugins/wifi/OtherNetwork.qml (+1/-1)
plugins/wifi/PageComponent.qml (+1/-1)
To merge this branch: bzr merge lp:~jonas-drange/ubuntu-system-settings/wifi-other-network-label-fix-1365984
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+234099@code.launchpad.net

Commit message

[wifi] "Other Network" -> "Connect to hidden network"

Description of the change

[wifi] "Other Network" -> "Connect to hidden network"

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1021. By Jonas G. Drange

merge trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good

review: Approve
Revision history for this message
Adolfo Jayme Barrientos (fitojb) wrote :

The POT file wasn’t updated...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/wifi/OtherNetwork.qml'
2--- plugins/wifi/OtherNetwork.qml 2014-09-10 13:07:31 +0000
3+++ plugins/wifi/OtherNetwork.qml 2014-09-11 14:16:40 +0000
4@@ -24,7 +24,7 @@
5
6 ItemPage {
7 id: othernetwork
8- title: i18n.tr("Other network")
9+ title: i18n.tr("Connect to hidden network")
10
11 function settingsValid() {
12 if(networkname.length == 0) {
13
14=== modified file 'plugins/wifi/PageComponent.qml'
15--- plugins/wifi/PageComponent.qml 2014-06-23 08:16:41 +0000
16+++ plugins/wifi/PageComponent.qml 2014-09-11 14:16:40 +0000
17@@ -117,7 +117,7 @@
18 }
19
20 ListItem.SingleValue {
21- text: i18n.tr("Other network")
22+ text: i18n.tr("Connect to hidden network")
23 progression: true
24 onClicked: pageStack.push(Qt.resolvedUrl("OtherNetwork.qml"))
25 }

Subscribers

People subscribed via source and target branches