Merge lp:~jonas-drange/ubuntu-system-settings/lp1644268 into lp:ubuntu-system-settings

Proposed by Jonas G. Drange
Status: Merged
Approved by: Jonas G. Drange
Approved revision: 1749
Merged at revision: 1753
Proposed branch: lp:~jonas-drange/ubuntu-system-settings/lp1644268
Merge into: lp:ubuntu-system-settings
Diff against target: 14 lines (+1/-3)
1 file modified
plugins/language/PageComponent.qml (+1/-3)
To merge this branch: bzr merge lp:~jonas-drange/ubuntu-system-settings/lp1644268
Reviewer Review Type Date Requested Status
Jonas G. Drange (community) Approve
system-apps-ci-bot continuous-integration Needs Fixing
Ken VanDine Approve
Review via email: mp+313230@code.launchpad.net

Commit message

unhides hw keyboard page now that input sources are listed

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

looks good

review: Approve
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1749
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/278/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/2191/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2194
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2021
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2021/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2021
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2021/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2021
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2021/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2021
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2021/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2021
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2021/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2021
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2021/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/2021/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2021
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2021/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2021
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2021/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/278/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

approved syncing with trunk

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/language/PageComponent.qml'
2--- plugins/language/PageComponent.qml 2016-12-10 01:16:09 +0000
3+++ plugins/language/PageComponent.qml 2017-01-02 14:48:45 +0000
4@@ -169,9 +169,7 @@
5 progression: true
6 showDivider: false
7 onClicked: pageStack.push(Qt.resolvedUrl("PageHardwareKeyboard.qml"))
8- /* Hidden due to lp:1644268, i.e. no layout sources are
9- enumerated by the current code due to hard coded paths. */
10- visible: (externalKeyboardPresent && !isSnap) || showAllUI
11+ visible: externalKeyboardPresent || showAllUI
12 }
13
14 ListItem.Divider {}

Subscribers

People subscribed via source and target branches