Merge lp:~jonas-drange/ubuntu-system-settings/fix-pruning into lp:ubuntu-system-settings

Proposed by Jonas G. Drange
Status: Merged
Approved by: Jonas G. Drange
Approved revision: 1712
Merged at revision: 1729
Proposed branch: lp:~jonas-drange/ubuntu-system-settings/fix-pruning
Merge into: lp:ubuntu-system-settings
Diff against target: 11 lines (+1/-0)
1 file modified
plugins/system-update/updatemanager.cpp (+1/-0)
To merge this branch: bzr merge lp:~jonas-drange/ubuntu-system-settings/fix-pruning
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
Ken VanDine Approve
Review via email: mp+308262@code.launchpad.net

Commit message

adds pruning of db

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks fine, I'd rather not have the arbitrary blank line, but not a blocker.

review: Approve
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1711
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/209/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1830/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1830
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1673
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1673/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1673/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1673/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1673
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1673/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1673
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1673/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1673
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1673/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1673
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1673/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1673
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1673/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1673
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1673/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/209/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/system-update/updatemanager.cpp'
2--- plugins/system-update/updatemanager.cpp 2016-08-12 07:40:41 +0000
3+++ plugins/system-update/updatemanager.cpp 2016-10-12 14:28:37 +0000
4@@ -52,6 +52,7 @@
5
6 void UpdateManager::init()
7 {
8+ m_model->db()->pruneDb();
9 m_pending.setSourceModel(m_model);
10 m_pending.filterOnInstalled(false);
11 m_clicks.setSourceModel(m_model);

Subscribers

People subscribed via source and target branches