ubuntu-system-settings

Merge lp:~jonas-drange/ubuntu-system-settings/fix-datetime-test-failure into lp:ubuntu-system-settings

  1. fix-datetime-test-failure
  2. Merge into trunk
Proposed by Jonas G. Drange on 2015-01-26
Status: Merged
Approved by: Ken VanDine on 2015-01-27
Approved revision: 1268
Merged at revision: 1276
Proposed branch: lp:~jonas-drange/ubuntu-system-settings/fix-datetime-test-failure
Merge into: lp:ubuntu-system-settings
Diff against target: 12 lines (+1/-1)
1 file modified
tests/autopilot/ubuntu_system_settings/tests/test_datetime.py (+1/-1)
To merge this branch: bzr merge lp:~jonas-drange/ubuntu-system-settings/fix-datetime-test-failure
Reviewer Review Type Date Requested Status
Ken VanDine 2015-01-26 Approve on 2015-01-27
PS Jenkins bot continuous-integration Needs Fixing on 2015-01-26
Review via email: mp+247586@code.launchpad.net

Commit Message

[ap] avoid use of scroll_to_and_click where the element to be clicked is visible without scrolling

Description of the Change

[ap] avoid use of scroll_to_and_click where the element to be clicked is visible without scrolling

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1268
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1928/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/981
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-vivid-i386-ci/198
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/870
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/979
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/979/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17441

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1928/rebuild

review: Needs Fixing (continuous-integration)
Iain Lane (laney) wrote :

On Mon, Jan 26, 2015 at 02:00:46PM -0000, Jonas G. Drange wrote:
> Jonas G. Drange has proposed merging lp:~jonas-drange/ubuntu-system-settings/fix-datetime-test-failure into lp:ubuntu-system-settings.
>
> Commit message:
> [ap] avoid use of scroll_to_and_click where the element to be clicked is visible without scrolling

Would be more tolerant to future UI changes or screen sizes etc if
scroll_to_and_click could instead cope with this situation itself, i.e.
not scroll if it doesn't need to.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1268
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1931/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/990
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-vivid-i386-ci/201/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/877
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/988
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/988/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17455

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1931/rebuild

review: Needs Fixing (continuous-integration)
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1268
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1934/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1002
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-vivid-i386-ci/204
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/887
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1000
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1000/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17472

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1934/rebuild

review: Approve (continuous-integration)
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Ken VanDine (ken-vandine) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/ubuntu_system_settings/tests/test_datetime.py'
2--- tests/autopilot/ubuntu_system_settings/tests/test_datetime.py 2014-12-10 20:47:38 +0000
3+++ tests/autopilot/ubuntu_system_settings/tests/test_datetime.py 2015-01-26 14:00:05 +0000
4@@ -62,7 +62,7 @@
5 raise e
6
7 def click_tz_search_field(self):
8- self.main_view.scroll_to_and_click(self.tz_page)
9+ self.main_view.pointing_device.click_object(self.tz_page)
10 text_field = self.main_view.wait_select_single(
11 objectName='selectTimeZoneField'
12 )

Subscribers

People subscribed via source and target branches