Code review comment for lp:~jonas-drange/ubuntu-system-settings/call-fwd-wait-dual-sim

Revision history for this message
Leo Arias (elopio) wrote :

Thanks for merging my branch.
Many of the tests have failed on Jenkins because the app wasn't launched. That's weird.

439 + :param sim: TODO I'm not sure what this is for.
465 + :param sim: TODO I'm not sure what this is for.
478 + :param sim: TODO I'm not sure what this is for.

Please fill the docstring here. I didn't know what to put in there.

tests/autopilot/ubuntu_system_settings/tests/__init__.py

There are some conflicts here ^

624 + def test_call_fwd(self):

That test just opens the page. It still needs to do an action and check its result.

And I thought you were going to add tests for the two other pages.

review: Needs Fixing

« Back to merge proposal