Merge lp:~jonas-drange/ubuntu-system-settings/apn-no-overwrite-1415495 into lp:ubuntu-system-settings
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Ken VanDine | ||||
Approved revision: | 1358 | ||||
Merged at revision: | 1358 | ||||
Proposed branch: | lp:~jonas-drange/ubuntu-system-settings/apn-no-overwrite-1415495 | ||||
Merge into: | lp:ubuntu-system-settings | ||||
Diff against target: |
130 lines (+42/-36) 1 file modified
plugins/cellular/PageChooseApn.qml (+42/-36) |
||||
To merge this branch: | bzr merge lp:~jonas-drange/ubuntu-system-settings/apn-no-overwrite-1415495 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ken VanDine | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email: mp+254000@code.launchpad.net |
Commit message
[cellular] apn page does not overwrite empty, provisioned contexts
Description of the change
What changed:
The current APN page made the assumption that an empty internet context was really a recently added custom context. I have made this logic more precise by using a temporary event handler on ConnectionManager's contextAdded.
How to test:
If you have special a special APN configuration, please back up the gprs file.
1. Stop ofono (sudo service ofono stop)
2. Edit /var/lib/
3. Start ofono (sudo service ofono start)
4. Wait 5 secs. Confirm that the output of /usr/share/
5. Enter the APN page
6. Add a custom context and confirm it is not overwriting anything.
PASSED: Continuous integration, rev:1358 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- ci/2030/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 1967 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- vivid-i386- ci/300 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-mako/ 1734 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1965 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1965/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 19150
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- system- settings- ci/2030/ rebuild
http://