Merge lp:~jonas-drange/ubuntu-system-settings-online-accounts/lp1445350 into lp:ubuntu-system-settings-online-accounts

Proposed by Jonas G. Drange on 2015-09-22
Status: Merged
Approved by: Alberto Mardegan on 2015-09-23
Approved revision: 296
Merged at revision: 304
Proposed branch: lp:~jonas-drange/ubuntu-system-settings-online-accounts/lp1445350
Merge into: lp:ubuntu-system-settings-online-accounts
Diff against target: 39 lines (+8/-3)
1 file modified
system-settings-plugin/ProvidersList.qml (+8/-3)
To merge this branch: bzr merge lp:~jonas-drange/ubuntu-system-settings-online-accounts/lp1445350
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) 2015-09-22 Approve on 2015-09-23
PS Jenkins bot continuous-integration Needs Fixing on 2015-09-22
Review via email: mp+271956@code.launchpad.net

Commit Message

pressed will refer to the AbstractButton's MouseArea.pressed, so rename the property to avoid the conflict

Description of the Change

pressed will refer to the AbstractButton's MouseArea.pressed, so rename the property to avoid the conflict

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'system-settings-plugin/ProvidersList.qml'
2--- system-settings-plugin/ProvidersList.qml 2014-09-30 12:29:26 +0000
3+++ system-settings-plugin/ProvidersList.qml 2015-09-22 12:39:26 +0000
4@@ -38,19 +38,24 @@
5 model: providerModel
6
7 delegate: ListItem.Standard {
8+ id: provider
9 text: displayName
10 enabled: accountModel === null || accountModel.count === 0
11 iconSource: model.iconName.indexOf("/") === 0 ?
12 model.iconName : "image://theme/" + model.iconName
13 progression: false
14- onClicked: { pressed = true; root.providerClicked(providerId) }
15+ onTriggered: {
16+ activated = true;
17+ root.providerClicked(providerId);
18+ }
19 property var accountModel: isSingleAccount ? createAccountModel(providerId) : null
20+ property bool activated: false
21
22 ActivityIndicator {
23 anchors.verticalCenter: parent.verticalCenter
24 anchors.right: parent.right
25 anchors.rightMargin: units.gu(2)
26- running: pressed
27+ running: provider.activated
28 }
29
30 function createAccountModel(providerId) {
31@@ -70,7 +75,7 @@
32
33 function clearPressedButtons() {
34 for (var i = 0; i < repeater.count; i++) {
35- repeater.itemAt(i).pressed = false
36+ repeater.itemAt(i).activated = false
37 }
38 }
39 }

Subscribers

People subscribed via source and target branches