Online Accounts setup for Ubuntu Touch

Merge lp:~jonas-drange/ubuntu-system-settings-online-accounts/apl-1651183-test-fixes into lp:ubuntu-system-settings-online-accounts

  1. apl-1651183-test-fixes
  2. Merge into trunk
Proposed by Jonas G. Drange on 2017-01-06
Status: Merged
Approved by: Alberto Mardegan on 2017-01-09
Approved revision: 412
Merged at revision: 411
Proposed branch: lp:~jonas-drange/ubuntu-system-settings-online-accounts/apl-1651183-test-fixes
Merge into: lp:ubuntu-system-settings-online-accounts
Prerequisite: lp:~mardy/ubuntu-system-settings-online-accounts/apl-1651183
Diff against target: 17 lines (+4/-3)
1 file modified
tests/autopilot/online_accounts_ui/tests/test_online_accounts_ui.py (+4/-3)
To merge this branch: bzr merge lp:~jonas-drange/ubuntu-system-settings-online-accounts/apl-1651183-test-fixes
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) 2017-01-06 Approve on 2017-01-09
Review via email: mp+314221@code.launchpad.net

Commit Message

fixes autopilot test failing after ItemPage changed upstream

To post a comment you must log in.
Alberto Mardegan (mardy) wrote :

LGTM, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/online_accounts_ui/tests/test_online_accounts_ui.py'
2--- tests/autopilot/online_accounts_ui/tests/test_online_accounts_ui.py 2014-08-19 09:16:44 +0000
3+++ tests/autopilot/online_accounts_ui/tests/test_online_accounts_ui.py 2017-01-06 12:43:30 +0000
4@@ -35,9 +35,10 @@
5 def test_title(self):
6 """Checks whether the Online Accounts window title is correct."""
7 # TODO turn this into a QML test. --elopio - 2014-07-03
8- header = self.application.main_view.get_header()
9- self.assertTrue(header.visible)
10- self.assertEquals(header.title, 'Accounts')
11+ title = self.application.main_view.select_single(
12+ objectName='accountsPage'
13+ ).title
14+ self.assertEquals(title, 'Accounts')
15
16
17 class AvailableProvidersTestCase(tests.BaseOnlineAccountsUITestCase):

Subscribers

People subscribed via source and target branches