Ubuntu Push Notifications

Merge lp:~jonas-drange/ubuntu-push/remove-unused into lp:ubuntu-push

  1. remove-unused
  2. Merge into trunk
Proposed by Jonas G. Drange
Status: Merged
Approved by: Ken VanDine
Approved revision: 163
Merged at revision: 167
Proposed branch: lp:~jonas-drange/ubuntu-push/remove-unused
Merge into: lp:ubuntu-push
Diff against target: 20 lines (+1/-2)
1 file modified
server/session/session_test.go (+1/-2)
To merge this branch: bzr merge lp:~jonas-drange/ubuntu-push/remove-unused
Reviewer Review Type Date Requested Status
Ken VanDine Approve
system-apps-ci-bot continuous-integration Needs Fixing
Review via email: mp+300314@code.launchpad.net

Commit message

remove unused sess variable

Description of the change

Sems the gcgo compiler is right—sess is unused but declared. Let's drop it.

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:163
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/16/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/993/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/993
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/894/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/894/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/894/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/16/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'server/session/session_test.go'
2--- server/session/session_test.go 2015-12-04 15:31:27 +0000
3+++ server/session/session_test.go 2016-07-18 12:49:56 +0000
4@@ -166,7 +166,6 @@
5 }
6
7 func (s *sessionSuite) TestSessionRegisterError(c *C) {
8- var sess broker.BrokerSession
9 errCh := make(chan error, 1)
10 up := make(chan interface{}, 5)
11 down := make(chan interface{}, 5)
12@@ -176,7 +175,7 @@
13 brkr.err = errRegister
14 go func() {
15 var err error
16- sess, err = sessionStart(tp, brkr, cfg10msPingInterval5msExchangeTout, &tracker{sessionId: "s2"})
17+ _, err = sessionStart(tp, brkr, cfg10msPingInterval5msExchangeTout, &tracker{sessionId: "s2"})
18 errCh <- err
19 }()
20 up <- protocol.ConnectMsg{Type: "connect", ClientVer: "1", DeviceId: "dev-1"}

Subscribers

People subscribed via source and target branches