Merge lp:~jonas-drange/ubuntu-push/lp1554547 into lp:ubuntu-push

[Jonas G. Drange]

deprecate the usage of Info and replace it with Information

[lp:~jonas-drange/ubuntu-push/lp1554547]

160. By Jonas G. Drange on 2016-03-09

fix test failure in client caused by Info -> Information

Unmerged revisions

160. By Jonas G. Drange on 2016-03-09

fix test failure in client caused by Info -> Information

159. By Jonas G. Drange on 2016-03-08

deprecate the Info usage

=== modified file 'bus/systemimage/systemimage.go'
--- bus/systemimage/systemimage.go	2015-01-21 17:21:42 +0000
+++ bus/systemimage/systemimage.go	2016-03-08 17:27:16 +0000
@@ -18,6 +18,9 @@
 package systemimage
 
 import (
+	"strconv"
+	"strings"
+
 	"launchpad.net/ubuntu-push/bus"
 	"launchpad.net/ubuntu-push/logger"
 )
@@ -37,11 +40,12 @@
 	// xxx channel_target missing
 	LastUpdate    string
 	VersionDetail map[string]string
+	Raw           map[string]string
 }
 
 // A SystemImage exposes the a subset of system-image service.
 type SystemImage interface {
-	Info() (*InfoResult, error)
+	Information() (*InfoResult, error)
 }
 
 type systemImage struct {
@@ -56,13 +60,36 @@
 
 var _ SystemImage = &systemImage{} // ensures it conforms
 
-func (si *systemImage) Info() (*InfoResult, error) {
-	si.log.Debugf("invoking Info")
-	res := &InfoResult{}
-	err := si.endp.Call("Info", bus.Args(), &res.BuildNumber, &res.Device, &res.Channel, &res.LastUpdate, &res.VersionDetail)
+func (si *systemImage) Information() (*InfoResult, error) {
+	m := map[string]string{}
+	err := si.endp.Call("Information", bus.Args(), &m)
+
 	if err != nil {
-		si.log.Errorf("Info failed: %v", err)
+		si.log.Errorf("Information failed: %v", err)
 		return nil, err
 	}
+
+	res := &InfoResult{}
+
+	bn, err := strconv.ParseInt(m["current_build_number"], 10, 32)
+	if err == nil {
+		res.BuildNumber = int32(bn)
+	} else {
+		res.BuildNumber = -1
+	}
+
+	res.Device = m["device_name"]
+	res.Channel = m["channel_name"]
+	res.LastUpdate = m["last_update_date"]
+	res.VersionDetail = map[string]string{}
+
+	// Split version detail key=value,key2=value2 into a string map
+	vals := strings.Split(m["version_detail"], ",")
+	for _, val := range vals {
+		pairs := strings.Split(val, "=")
+		res.VersionDetail[pairs[0]] = pairs[1]
+	}
+	res.Raw = m
+
 	return res, err
 }

=== modified file 'bus/systemimage/systemimage_test.go'
--- bus/systemimage/systemimage_test.go	2014-04-02 08:46:48 +0000
+++ bus/systemimage/systemimage_test.go	2016-03-08 17:27:16 +0000
@@ -41,22 +41,38 @@
 }
 
 func (s *SISuite) TestWorks(c *C) {
-	endp := testibus.NewMultiValuedTestingEndpoint(nil, condition.Work(true), []interface{}{int32(101), "mako", "daily", "Unknown", map[string]string{}})
+	m := map[string]string{
+		"version_detail":        "ubuntu=20160304.2,device=20160304.2,custom=20160304.2,version=381",
+		"last_update_date":      "2016-03-04 15:25:31",
+		"last_check_date":       "2016-03-08 04:30:34",
+		"target_version_detail": "-1",
+		"device_name":           "mako",
+		"target_build_number":   "-1",
+		"channel_name":          "ubuntu-touch/rc-proposed/ubuntu",
+		"current_build_number":  "381",
+	}
+	endp := testibus.NewMultiValuedTestingEndpoint(nil, condition.Work(true), []interface{}{m})
 	si := New(endp, s.log)
-	res, err := si.Info()
+	res, err := si.Information()
 	c.Assert(err, IsNil)
 	c.Check(res, DeepEquals, &InfoResult{
-		BuildNumber:   101,
-		Device:        "mako",
-		Channel:       "daily",
-		LastUpdate:    "Unknown",
-		VersionDetail: map[string]string{},
+		BuildNumber: 381,
+		Device:      "mako",
+		Channel:     "ubuntu-touch/rc-proposed/ubuntu",
+		LastUpdate:  "2016-03-04 15:25:31",
+		VersionDetail: map[string]string{
+			"ubuntu":  "20160304.2",
+			"device":  "20160304.2",
+			"custom":  "20160304.2",
+			"version": "381",
+		},
+		Raw: m,
 	})
 }
 
 func (s *SISuite) TestFailsIfCallFails(c *C) {
 	endp := testibus.NewTestingEndpoint(nil, condition.Work(false))
 	si := New(endp, s.log)
-	_, err := si.Info()
+	_, err := si.Information()
 	c.Check(err, NotNil)
 }

=== modified file 'client/client.go'
--- client/client.go	2015-09-30 14:44:14 +0000
+++ client/client.go	2016-03-08 17:27:16 +0000
@@ -292,7 +292,7 @@
 	go cs.Track(client.connCh)
 	util.NewAutoRedialer(client.systemImageEndp).Redial()
 	sysimg := systemimage.New(client.systemImageEndp, client.log)
-	info, err := sysimg.Info()
+	info, err := sysimg.Information()
 	if err != nil {
 		return err
 	}