Merge lp:~jonas-drange/ubuntu-push/fix-dot-install into lp:ubuntu-push

Proposed by Jonas G. Drange
Status: Rejected
Rejected by: Jonas G. Drange
Proposed branch: lp:~jonas-drange/ubuntu-push/fix-dot-install
Merge into: lp:ubuntu-push
Prerequisite: lp:ubuntu-push/automatic
Diff against target: 18 lines (+2/-2)
2 files modified
debian/ubuntu-push-client.install (+1/-1)
debian/ubuntu-push-dev-server.install (+1/-1)
To merge this branch: bzr merge lp:~jonas-drange/ubuntu-push/fix-dot-install
Reviewer Review Type Date Requested Status
dobey (community) Disapprove
Review via email: mp+293542@code.launchpad.net

This proposal supersedes a proposal from 2016-05-02.

Commit message

remove symbols creating ftbfs issues on vivid

To post a comment you must log in.
430. By Jonas G. Drange

undrop final names

Revision history for this message
dobey (dobey) wrote :

This seems wrong, so I"m disapproving. If I build lp:ubuntu-push/automatic locally on vivid, the build issues don't happen, so something else is wrong, and I think we should not land this change.

review: Disapprove

Unmerged revisions

430. By Jonas G. Drange

undrop final names

429. By Jonas G. Drange

remove misbehaving symbols

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/ubuntu-push-client.install'
2--- debian/ubuntu-push-client.install 2014-08-12 02:31:51 +0000
3+++ debian/ubuntu-push-client.install 2016-05-02 15:12:07 +0000
4@@ -5,5 +5,5 @@
5 debian/push-helper.hook /usr/share/click/hooks
6 signing-helper/signing-helper /usr/lib/ubuntu-push-client
7 scripts/click-hook /usr/lib/ubuntu-push-client
8-usr/bin/ubuntu-push => /usr/lib/ubuntu-push-client/ubuntu-push-client
9+usr/bin/ubuntu-push /usr/lib/ubuntu-push-client/ubuntu-push-client
10
11
12=== modified file 'debian/ubuntu-push-dev-server.install'
13--- debian/ubuntu-push-dev-server.install 2014-07-17 23:01:19 +0000
14+++ debian/ubuntu-push-dev-server.install 2016-05-02 15:12:07 +0000
15@@ -1,2 +1,2 @@
16 #!/usr/bin/dh-exec
17-usr/bin/dev => /usr/bin/ubuntu-push-dev-server
18+usr/bin/dev /usr/bin/ubuntu-push-dev-server

Subscribers

People subscribed via source and target branches