u1-test-utils

Merge lp:~jonas-drange/u1-test-utils/remove-qa-prefixes into lp:u1-test-utils

  1. remove-qa-prefixes
  2. Merge into trunk
Proposed by Jonas G. Drange
Status: Merged
Approved by: Simon Davy
Approved revision: 67
Merged at revision: 67
Proposed branch: lp:~jonas-drange/u1-test-utils/remove-qa-prefixes
Merge into: lp:u1-test-utils
Diff against target: 63 lines (+7/-7)
1 file modified
u1testutils/sso/sst/pages.py (+7/-7)
To merge this branch: bzr merge lp:~jonas-drange/u1-test-utils/remove-qa-prefixes
Reviewer Review Type Date Requested Status
Simon Davy (community) Approve
Review via email: mp+163872@code.launchpad.net

Commit message

nuking qa prefixes

Description of the change

* nuking qa prefixes on qa anchors/ids

14:31 < jgdx> anyway, pindonga. What are we changing the qa id to? :)
---
14:33 < pindonga> jgdx, personally, I prefer to just use what we have but without the _qa/qa prefix

To post a comment you must log in.
Revision history for this message
Simon Davy (bloodearnest) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'u1testutils/sso/sst/pages.py'
2--- u1testutils/sso/sst/pages.py 2013-05-13 13:18:18 +0000
3+++ u1testutils/sso/sst/pages.py 2013-05-15 09:24:54 +0000
4@@ -36,7 +36,7 @@
5 url_path = '/'
6 headings1 = ['Ubuntu Single Sign On']
7 headings2 = ['Log in to Ubuntu Single Sign On', 'Are you new?']
8- qa_anchor = '_qa_ubuntu_login_title'
9+ qa_anchor = 'ubuntu_login_title'
10
11 @log_action(logging.info)
12 def log_in_to_site_recognized(self, user=None):
13@@ -85,7 +85,7 @@
14
15 def _click_continue_button(self):
16 continue_button = sst.actions.get_element_by_css(
17- '*[data-qa-id="_qa_ubuntu_login_button"]')
18+ '*[data-qa-id="ubuntu_login_button"]')
19 sst.actions.click_button(continue_button)
20
21 @log_action(logging.info)
22@@ -103,7 +103,7 @@
23 url_path = '/.*/\+decide'
24 is_url_path_regex = True
25 headings2 = ['Log in', 'Are you new?']
26- qa_anchor = '_qa_ubuntu_login_title'
27+ qa_anchor = 'ubuntu_login_title'
28
29 @log_action(logging.info)
30 def go_to_create_new_account(self):
31@@ -158,7 +158,7 @@
32 title = 'Create account'
33 url_path = '/+new_account'
34 headings1 = ['Ubuntu Single Sign On', 'Create an account']
35- qa_anchor = '_qa_new_account'
36+ qa_anchor = 'new_account'
37
38 @log_action(logging.info)
39 def create_ubuntu_sso_account(self, user):
40@@ -212,7 +212,7 @@
41 url_path = '/+new_account'
42 headings1 = ['Account creation mail sent']
43 headings2 = ["Haven't received it?"]
44- qa_anchor = '_qa_new_account'
45+ qa_anchor = 'new_account'
46
47 @log_action(logging.info)
48 def confirm_email_to_site_recognized(self, confirmation_code):
49@@ -377,7 +377,7 @@
50
51 title = "{0}'s details"
52 url_path = '/'
53- qa_anchor = '_qa_edit_account'
54+ qa_anchor = 'edit_account'
55
56 def __init__(self, user_name, open_page=False):
57 self.title = self.title.format(user_name)
58@@ -390,5 +390,5 @@
59 title = 'You have been logged out'
60 url_path = '/+logout'
61 headings1 = ['Ubuntu Single Sign On', 'You have been logged out']
62- qa_anchor = '_qa_logout'
63+ qa_anchor = 'logout'
64

Subscribers

People subscribed via source and target branches

to all changes: