Merge lp:~jonas-drange/indicator-network/allow-auth-none into lp:indicator-network/15.10

[Jonas G. Drange]

Allow creation and configuration of insecure hotspot via the connectivity service. Bumped version due to new API.

We should allow the user to create and configure an insecure hotspot via the Connectivity API.

* Allow for “wpa-psk” and “none” authentication schemes at creation and configuration time. “none” does not mean WEP—we've decided to never support WEP, since it gives a false sense of security.
* Detect a insecure hotspot on startup.

[lp:~jonas-drange/indicator-network/allow-auth-none]

522. By Jonas G. Drange on 2015-08-31

revert po changes

523. By Jonas G. Drange on 2015-08-31

undo line addition

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:523
http://jenkins.qa.ubuntu.com/job/indicator-network-ci/387/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-amd64-ci/39
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-armhf-ci/39
        deb: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-armhf-ci/39/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-network-ci/387/rebuild

review: Approve (continuous-integration)

[lp:~jonas-drange/indicator-network/allow-auth-none]

524. By Jonas G. Drange on 2015-09-01

add failing test

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:524
http://jenkins.qa.ubuntu.com/job/indicator-network-ci/388/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-amd64-ci/40/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-armhf-ci/40/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-network-ci/388/rebuild

review: Needs Fixing (continuous-integration)

[lp:~jonas-drange/indicator-network/allow-auth-none]

525. By Jonas G. Drange on 2015-09-01

don't need device, and use correct dbus object path

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:525
http://jenkins.qa.ubuntu.com/job/indicator-network-ci/389/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-amd64-ci/41
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-armhf-ci/41
        deb: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-armhf-ci/41/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-network-ci/389/rebuild

review: Approve (continuous-integration)

[lp:~jonas-drange/indicator-network/allow-auth-none]

526. By Jonas G. Drange on 2015-09-03

bump version

527. By Jonas G. Drange on 2015-09-03

bump dep properly this time

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:527
http://jenkins.qa.ubuntu.com/job/indicator-network-ci/390/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-amd64-ci/42
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-armhf-ci/42
        deb: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-armhf-ci/42/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-network-ci/390/rebuild

review: Approve (continuous-integration)

[lp:~jonas-drange/indicator-network/allow-auth-none]

528. By Jonas G. Drange on 2015-09-09

re-add trailing whitespace

529. By Jonas G. Drange on 2015-09-09

re-add trailing whitespace

=== modified file 'data/com.ubuntu.connectivity1.Private.xml'
--- data/com.ubuntu.connectivity1.Private.xml	2015-07-15 11:20:26 +0000
+++ data/com.ubuntu.connectivity1.Private.xml	2015-09-09 12:18:20 +0000
@@ -9,7 +9,6 @@
         <method name="UnlockModem">
             <arg type="s" direction="in" name="modem"/>
         </method>
-        
         <method name="SetFlightMode">
             <arg type="b" direction="in" name="enabled"/>
         </method>
@@ -34,8 +33,14 @@
             <arg type="s" direction="in" name="mode"/>
         </method>
 
+        <method name="SetHotspotAuth">
+            <arg type="s" direction="in" name="auth"/>
+        </method>
+
         <property name="HotspotPassword" type="s" access="read"/>
 
+        <property name="HotspotAuth" type="s" access="read"/>
+
         <signal name="ReportError">
             <arg type="i" direction="out" name="reason"/>
         </signal>

=== modified file 'debian/changelog'
--- debian/changelog	2015-08-18 08:46:30 +0000
+++ debian/changelog	2015-09-09 12:18:20 +0000
@@ -1,3 +1,11 @@
+indicator-network (0.5.4-0ubuntu1) UNRELEASED; urgency=medium
+
+  [ jonas-drange]
+  * Allow creation and configuration of insecure hotspot via the
+    connectivity service (LP: #1431876)
+
+ -- Jonas G. Drange <[e-mail]>  Thu, 03 Sep 2015 14:49:46 +0200
+
 indicator-network (0.5.3+15.10.20150818-0ubuntu1) wily; urgency=medium
 
   [ Pete Woods ]

=== modified file 'src/connectivity-api/connectivity-qt/connectivityqt/connectivity.cpp'
--- src/connectivity-api/connectivity-qt/connectivityqt/connectivity.cpp	2015-08-16 16:43:16 +0000
+++ src/connectivity-api/connectivity-qt/connectivityqt/connectivity.cpp	2015-09-09 12:18:20 +0000
@@ -146,6 +146,10 @@
         {
             Q_EMIT p.hotspotModeUpdated(value.toString());
         }
+        else if (name == "HotspotAuth")
+        {
+            Q_EMIT p.hotspotAuthUpdated(value.toString());
+        }
         else if (name == "HotspotStored")
         {
             Q_EMIT p.hotspotStoredUpdated(value.toBool());
@@ -295,6 +299,11 @@
     return d->m_propertyCache->get("HotspotMode").toString();
 }
 
+QString Connectivity::hotspotAuth() const
+{
+    return d->m_writePropertyCache->get("HotspotAuth").toString();
+}
+
 bool Connectivity::hotspotStored() const
 {
     return d->m_propertyCache->get("HotspotStored").toBool();
@@ -323,6 +332,11 @@
     d->m_writeInterface->SetHotspotMode(mode);
 }
 
+void Connectivity::setHotspotAuth(const QString& auth)
+{
+    d->m_writeInterface->SetHotspotAuth(auth);
+}
+
 }
 
 #include "connectivity.moc"

=== modified file 'src/connectivity-api/connectivity-qt/connectivityqt/connectivity.h'
--- src/connectivity-api/connectivity-qt/connectivityqt/connectivity.h	2015-08-14 16:03:42 +0000
+++ src/connectivity-api/connectivity-qt/connectivityqt/connectivity.h	2015-09-09 12:18:20 +0000
@@ -120,6 +120,9 @@
     Q_PROPERTY(QString hotspotMode READ hotspotMode WRITE setHotspotMode NOTIFY hotspotModeUpdated)
     QString hotspotMode() const;
 
+    Q_PROPERTY(QString hotspotAuth READ hotspotAuth WRITE setHotspotAuth NOTIFY hotspotAuthUpdated)
+    QString hotspotAuth() const;
+
     Q_PROPERTY(bool hotspotStored READ hotspotStored NOTIFY hotspotStoredUpdated)
     bool hotspotStored() const;
 
@@ -139,6 +142,8 @@
 
     void setHotspotMode(const QString& mode);
 
+    void setHotspotAuth(const QString& auth);
+
 Q_SIGNALS:
     void flightModeUpdated(bool);
 
@@ -168,6 +173,8 @@
 
     void hotspotModeUpdated(const QString& mode);
 
+    void hotspotAuthUpdated(const QString& auth);
+
     void hotspotStoredUpdated(bool);
 
     void reportError(int reason);

=== modified file 'src/indicator/connectivity-service/connectivity-service.cpp'
--- src/indicator/connectivity-service/connectivity-service.cpp	2015-08-17 15:38:34 +0000
+++ src/indicator/connectivity-service/connectivity-service.cpp	2015-09-09 12:18:20 +0000
@@ -137,6 +137,15 @@
                               { "HotspotMode" });
     }
 
+    // Note that this is on the private object
+    void hotspotAuthUpdated()
+    {
+        notifyPropertyChanged(*m_privateService,
+                              DBusTypes::PRIVATE_PATH,
+                              DBusTypes::PRIVATE_INTERFACE,
+                              { "HotspotAuth" });
+    }
+
     void hotspotStoredUpdated()
     {
         notifyPropertyChanged(p,
@@ -211,6 +220,7 @@
     connect(d->m_manager.get(), &Manager::hotspotSsidChanged, d.get(), &Private::hotspotSsidUpdated);
     connect(d->m_manager.get(), &Manager::hotspotPasswordChanged, d.get(), &Private::hotspotPasswordUpdated);
     connect(d->m_manager.get(), &Manager::hotspotModeChanged, d.get(), &Private::hotspotModeUpdated);
+    connect(d->m_manager.get(), &Manager::hotspotAuthChanged, d.get(), &Private::hotspotAuthUpdated);
     connect(d->m_manager.get(), &Manager::hotspotStoredChanged, d.get(), &Private::hotspotStoredUpdated);
 
     connect(d->m_manager.get(), &Manager::reportError, d->m_privateService.get(), &PrivateService::ReportError);
@@ -342,11 +352,21 @@
     p.d->m_manager->setHotspotMode(mode);
 }
 
+void PrivateService::SetHotspotAuth(const QString &auth)
+{
+    p.d->m_manager->setHotspotAuth(auth);
+}
+
 QString PrivateService::hotspotPassword() const
 {
     return p.d->m_manager->hotspotPassword();
 }
 
+QString PrivateService::hotspotAuth() const
+{
+    return p.d->m_manager->hotspotAuth();
+}
+
 }
 
 #include "connectivity-service.moc"

=== modified file 'src/indicator/connectivity-service/connectivity-service.h'
--- src/indicator/connectivity-service/connectivity-service.h	2015-08-14 10:29:55 +0000
+++ src/indicator/connectivity-service/connectivity-service.h	2015-09-09 12:18:20 +0000
@@ -96,6 +96,9 @@
     Q_PROPERTY(QString HotspotPassword READ hotspotPassword)
     QString hotspotPassword() const;
 
+    Q_PROPERTY(QString HotspotAuth READ hotspotAuth)
+    QString hotspotAuth() const;
+
 protected Q_SLOTS:
     void UnlockAllModems();
 
@@ -113,6 +116,8 @@
 
     void SetHotspotMode(const QString &mode);
 
+    void SetHotspotAuth(const QString &auth);
+
 Q_SIGNALS:
     void ReportError(int reason);
 

=== modified file 'src/indicator/nmofono/hotspot-manager.cpp'
--- src/indicator/nmofono/hotspot-manager.cpp	2015-08-17 11:01:23 +0000
+++ src/indicator/nmofono/hotspot-manager.cpp	2015-09-09 12:18:20 +0000
@@ -67,7 +67,7 @@
         // Get new settings
         QVariantDictMap new_settings = createConnectionSettings(m_ssid,
                                                                 m_password,
-                                                                m_mode, false);
+                                                                m_mode, m_auth, false);
         auto updating = m_hotspot->Update(new_settings);
         updating.waitForFinished();
         if (!updating.isValid())
@@ -190,6 +190,8 @@
             {
                 p.setPassword(pwd);
             }
+        } else {
+            p.setAuth("none");
         }
     }
 
@@ -302,7 +304,7 @@
      */
     QVariantDictMap createConnectionSettings(
         const QByteArray &ssid, const QString &password,
-        QString mode, bool autoConnect = true)
+        QString mode, QString auth, bool autoConnect = true)
     {
         QVariantDictMap connection;
 
@@ -313,7 +315,11 @@
         s_uuid.remove(s_uuid.size() - 1, 1);
 
         QVariantMap wireless;
-        wireless[QStringLiteral("security")] = QVariant(QStringLiteral("802-11-wireless-security"));
+
+        if (auth != "none")
+        {
+            wireless[QStringLiteral("security")] = QVariant(QStringLiteral("802-11-wireless-security"));
+        }
         wireless[QStringLiteral("ssid")] = QVariant(ssid);
         wireless[QStringLiteral("mode")] = QVariant(mode);
 
@@ -337,13 +343,16 @@
         ipv6[QStringLiteral("method")] = QVariant(QStringLiteral("ignore"));
         connection["ipv6"] = ipv6;
 
-        QVariantMap security;
-        security[QStringLiteral("proto")] = QVariant(QStringList{ "rsn" });
-        security[QStringLiteral("pairwise")] = QVariant(QStringList{ "ccmp" });
-        security[QStringLiteral("group")] = QVariant(QStringList{ "ccmp" });
-        security[QStringLiteral("key-mgmt")] = QVariant(QStringLiteral("wpa-psk"));
-        security[QStringLiteral("psk")] = QVariant(password);
-        connection["802-11-wireless-security"] = security;
+        if (auth != "none")
+        {
+            QVariantMap security;
+            security[QStringLiteral("proto")] = QVariant(QStringList{ "rsn" });
+            security[QStringLiteral("pairwise")] = QVariant(QStringList{ "ccmp" });
+            security[QStringLiteral("group")] = QVariant(QStringList{ "ccmp" });
+            security[QStringLiteral("key-mgmt")] = QVariant(auth);
+            security[QStringLiteral("psk")] = QVariant(password);
+            connection["802-11-wireless-security"] = security;
+        }
 
         return connection;
     }
@@ -382,7 +391,7 @@
     void addConnection()
     {
         QVariantDictMap connection = createConnectionSettings(m_ssid, m_password,
-                                                              m_mode);
+                                                              m_mode, m_auth);
 
         auto add_connection_reply = m_settings->AddConnection(connection);
         add_connection_reply.waitForFinished();
@@ -627,6 +636,7 @@
     HotspotManager& p;
 
     QString m_mode = "ap";
+    QString m_auth = "wpa-psk";
     bool m_enabled = false;
     bool m_stored = false;
     QString m_password;
@@ -816,6 +826,10 @@
     return d->m_mode;
 }
 
+QString HotspotManager::auth() const {
+    return d->m_auth;
+}
+
 void HotspotManager::setMode(const QString& value) {
     if (d->m_mode != value)
     {
@@ -824,6 +838,14 @@
     }
 }
 
+void HotspotManager::setAuth(const QString& value) {
+    if (d->m_auth != value)
+    {
+        d->m_auth = value;
+        Q_EMIT authChanged(value);
+    }
+}
+
 bool HotspotManager::disconnectWifi() const
 {
     return d->m_disconnectWifi;

=== modified file 'src/indicator/nmofono/hotspot-manager.h'
--- src/indicator/nmofono/hotspot-manager.h	2015-08-17 11:01:23 +0000
+++ src/indicator/nmofono/hotspot-manager.h	2015-09-09 12:18:20 +0000
@@ -70,9 +70,10 @@
  *   QString auth [readwrite]
  *     The current authentication of the hotspot. The default for this property
  *     is "wpa-psk" and is currently the only supported scheme. WEP is unsupported
- *     by design, as is no scheme at all.
- *
- *     TODO: Check/add support for wpa-eap
+ *     by design.
+ *
+ *     Possible authentication schemes: wpa-psk, none
+ *
  *
  *   QString password [readwrite]
  *     The current Pre-Shared-Key for the hotspot. If the key is 64-characters
@@ -110,6 +111,11 @@
         WRITE setMode
         NOTIFY modeChanged)
 
+    Q_PROPERTY( QString auth
+        READ auth
+        WRITE setAuth
+        NOTIFY authChanged)
+
     Q_PROPERTY( bool stored
         READ stored
         NOTIFY storedChanged)
@@ -135,6 +141,8 @@
 
     QString mode() const;
 
+    QString auth() const;
+
     bool disconnectWifi() const;
 
 Q_SIGNALS:
@@ -148,6 +156,8 @@
 
     void modeChanged(const QString& mode);
 
+    void authChanged(const QString& auth);
+
     void disconnectWifiChanged(bool disconnect);
 
     /*
@@ -169,6 +179,8 @@
 
     void setMode(const QString&);
 
+    void setAuth(const QString&);
+
 private:
     class Priv;
     std::shared_ptr<Priv> d;

=== modified file 'src/indicator/nmofono/manager-impl.cpp'
--- src/indicator/nmofono/manager-impl.cpp	2015-08-18 08:39:29 +0000
+++ src/indicator/nmofono/manager-impl.cpp	2015-09-09 12:18:20 +0000
@@ -267,6 +267,7 @@
     connect(d->m_hotspotManager.get(), &HotspotManager::ssidChanged, this, &Manager::hotspotSsidChanged);
     connect(d->m_hotspotManager.get(), &HotspotManager::passwordChanged, this, &Manager::hotspotPasswordChanged);
     connect(d->m_hotspotManager.get(), &HotspotManager::modeChanged, this, &Manager::hotspotModeChanged);
+    connect(d->m_hotspotManager.get(), &HotspotManager::authChanged, this, &Manager::hotspotAuthChanged);
     connect(d->m_hotspotManager.get(), &HotspotManager::storedChanged, this, &Manager::hotspotStoredChanged);
 
     connect(d->m_hotspotManager.get(), &HotspotManager::reportError, this, &Manager::reportError);
@@ -627,6 +628,12 @@
     return d->m_hotspotManager->mode();
 }
 
+QString
+ManagerImpl::hotspotAuth() const
+{
+    return d->m_hotspotManager->auth();
+}
+
 void
 ManagerImpl::setHotspotSsid(const QByteArray& ssid)
 {
@@ -645,6 +652,12 @@
     d->m_hotspotManager->setMode(mode);
 }
 
+void
+ManagerImpl::setHotspotAuth(const QString& auth)
+{
+    d->m_hotspotManager->setAuth(auth);
+}
+
 }
 
 #include "manager-impl.moc"

=== modified file 'src/indicator/nmofono/manager-impl.h'
--- src/indicator/nmofono/manager-impl.h	2015-08-14 15:52:39 +0000
+++ src/indicator/nmofono/manager-impl.h	2015-09-09 12:18:20 +0000
@@ -81,6 +81,8 @@
 
     QString hotspotMode() const override;
 
+    QString hotspotAuth() const override;
+
     void setHotspotEnabled(bool) override;
 
     void setHotspotSsid(const QByteArray&) override;
@@ -89,6 +91,8 @@
 
     void setHotspotMode(const QString&) override;
 
+    void setHotspotAuth(const QString&) override;
+
 private Q_SLOTS:
     void device_added(const QDBusObjectPath &path);
     void device_removed(const QDBusObjectPath &path);

=== modified file 'src/indicator/nmofono/manager.h'
--- src/indicator/nmofono/manager.h	2015-08-14 15:52:39 +0000
+++ src/indicator/nmofono/manager.h	2015-09-09 12:18:20 +0000
@@ -137,6 +137,9 @@
     Q_PROPERTY(QString hotspotMode READ hotspotMode WRITE setHotspotMode NOTIFY hotspotModeChanged)
     virtual QString hotspotMode() const = 0;
 
+    Q_PROPERTY(QString hotspotAuth READ hotspotAuth WRITE setHotspotAuth NOTIFY hotspotAuthChanged)
+    virtual QString hotspotAuth() const = 0;
+
 Q_SIGNALS:
     void flightModeUpdated(bool);
 
@@ -160,6 +163,8 @@
 
     void hotspotModeChanged(const QString& mode);
 
+    void hotspotAuthChanged(const QString& auth);
+
     void reportError(int reason);
 
     void unstoppableOperationHappeningUpdated(bool);
@@ -177,6 +182,8 @@
 
     virtual void setHotspotMode(const QString&) = 0;
 
+    virtual void setHotspotAuth(const QString&) = 0;
+
 protected:
     /**
      * @brief The default constructor is protected.

=== modified file 'tests/integration/test-connectivity-api.cpp'
--- tests/integration/test-connectivity-api.cpp	2015-08-17 15:38:34 +0000
+++ tests/integration/test-connectivity-api.cpp	2015-09-09 12:18:20 +0000
@@ -504,6 +504,7 @@
     QSignalSpy passwordSpy(connectivity.get(), SIGNAL(hotspotPasswordUpdated(const QString&)));
 
     EXPECT_EQ("Ubuntu", connectivity->hotspotSsid().toStdString());
+    EXPECT_EQ("wpa-psk", connectivity->hotspotAuth().toStdString());
     EXPECT_FALSE(connectivity->hotspotStored());
     EXPECT_FALSE(connectivity->hotspotEnabled());
 
@@ -630,4 +631,95 @@
     }
 }
 
+TEST_F(TestConnectivityApi, InsecureHotspotConfig)
+{
+    // Start the indicator
+    ASSERT_NO_THROW(startIndicator());
+    auto& nmSettingsMock = dbusMock.mockInterface(NM_DBUS_SERVICE,
+                           NM_DBUS_PATH_SETTINGS,
+                           NM_DBUS_IFACE_SETTINGS,
+                           QDBusConnection::SystemBus);
+    QSignalSpy nmSettingsMockCallSpy(
+                           &nmSettingsMock,
+                           SIGNAL(MethodCalled(const QString &, const QVariantList &)));
+
+    OrgFreedesktopNetworkManagerSettingsInterface settings(
+            NM_DBUS_SERVICE, NM_DBUS_PATH_SETTINGS, dbusTestRunner.systemConnection());
+    QSignalSpy settingsNewConnectionSpy(
+                           &settings,
+                           SIGNAL(NewConnection(const QDBusObjectPath &)));
+
+    // Connect the the service
+    auto connectivity(newConnectivity());
+
+    QSignalSpy storedSpy(connectivity.get(), SIGNAL(hotspotStoredUpdated(bool)));
+    QSignalSpy enabledSpy(connectivity.get(), SIGNAL(hotspotEnabledUpdated(bool)));
+    QSignalSpy authSpy(connectivity.get(), SIGNAL(hotspotAuthUpdated(const QString&)));
+
+    EXPECT_EQ("Ubuntu", connectivity->hotspotSsid().toStdString());
+    EXPECT_EQ("wpa-psk", connectivity->hotspotAuth().toStdString());
+    EXPECT_FALSE(connectivity->hotspotStored());
+    EXPECT_FALSE(connectivity->hotspotEnabled());
+
+    connectivity->setHotspotAuth("none");
+
+    if (authSpy.empty())
+    {
+        ASSERT_TRUE(authSpy.wait());
+    }
+    EXPECT_FALSE(authSpy.empty());
+    EXPECT_EQ("none", connectivity->hotspotAuth().toStdString());
+
+    connectivity->setHotspotEnabled(true);
+
+    if (enabledSpy.empty())
+    {
+        ASSERT_TRUE(enabledSpy.wait());
+    }
+    EXPECT_FALSE(enabledSpy.empty());
+
+    if (storedSpy.empty())
+    {
+        ASSERT_TRUE(storedSpy.wait());
+    }
+    EXPECT_FALSE(storedSpy.empty());
+
+    if (nmSettingsMockCallSpy.empty())
+    {
+        ASSERT_TRUE(nmSettingsMockCallSpy.wait());
+    }
+    EXPECT_FALSE(nmSettingsMockCallSpy.empty());
+
+    if (settingsNewConnectionSpy.empty())
+    {
+        ASSERT_TRUE(settingsNewConnectionSpy.wait());
+    }
+    EXPECT_FALSE(settingsNewConnectionSpy.empty());
+
+    EXPECT_TRUE(connectivity->hotspotEnabled());
+    EXPECT_TRUE(connectivity->hotspotStored());
+
+    // Connect to method calls on the newly added connection
+    auto connectionPath = qvariant_cast<QDBusObjectPath>(settingsNewConnectionSpy.first().first());
+    auto& connectionSettingsMock = dbusMock.mockInterface(NM_DBUS_SERVICE, connectionPath.path(),
+                           NM_DBUS_IFACE_SETTINGS_CONNECTION,
+                           QDBusConnection::SystemBus);
+    QSignalSpy connectionSettingsMockCallSpy(
+                           &connectionSettingsMock,
+                           SIGNAL(MethodCalled(const QString &, const QVariantList &)));
+
+    {
+        auto call = getMethodCall(nmSettingsMockCallSpy, "AddConnection");
+        // Decode the QDBusArgument
+        QVariantDictMap connection;
+        qvariant_cast<QDBusArgument>(call.first()) >> connection;
+        EXPECT_EQ(QVariantMap({
+            {"mode", "ap"},
+            {"ssid", "Ubuntu"}
+        }), connection["802-11-wireless"]);
+        EXPECT_EQ(QVariantMap(), connection["802-11-wireless-security"]);
+        EXPECT_TRUE(connection["connection"]["autoconnect"].toBool());
+    }
+}
+
 }