GSettings Ubuntu touch schemas

Merge lp:~jonas-drange/gsettings-ubuntu-touch-schemas/other-vibrations into lp:gsettings-ubuntu-touch-schemas

  1. other-vibrations
  2. Merge into trunk
Proposed by Jonas G. Drange on 2014-10-27
Status: Merged
Approved by: Jonas G. Drange on 2015-01-06
Approved revision: 52
Merged at revision: 50
Proposed branch: lp:~jonas-drange/gsettings-ubuntu-touch-schemas/other-vibrations
Merge into: lp:gsettings-ubuntu-touch-schemas
Diff against target: 30 lines (+12/-0)
2 files modified
accountsservice/com.ubuntu.touch.AccountsService.Sound.xml (+5/-0)
debian/changelog (+7/-0)
To merge this branch: bzr merge lp:~jonas-drange/gsettings-ubuntu-touch-schemas/other-vibrations
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve on 2015-01-06
Sebastien Bacher (community) 2014-10-27 Approve on 2014-10-27
Review via email: mp+239734@code.launchpad.net

Commit Message

adding new account service setting OtherVibrate

Description of the Change

New account service setting, “Other vibrations”, that should cover all vibrations except for those relating to phone calls and message.

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Sebastien Bacher (seb128) wrote :

looks fine to me, thanks

review: Approve
Jonas G. Drange (jonas-drange) wrote :

14:06 < jgdx> zsombi, no – are you okay with a boolean prop called OtherVibrate?
14:06 < zsombi> jgdx: until we are not defining any vibra pattern, this will be fine

Iain Lane (laney) wrote :

Please could you add a comment saying what 'Other' is?

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Charles Kerr (charlesk) wrote :

Laney, one example of "Other" is whether or not calendar notifications should vibrate in Silent Mode.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'accountsservice/com.ubuntu.touch.AccountsService.Sound.xml'
2--- accountsservice/com.ubuntu.touch.AccountsService.Sound.xml 2014-08-28 17:25:46 +0000
3+++ accountsservice/com.ubuntu.touch.AccountsService.Sound.xml 2015-01-06 14:24:04 +0000
4@@ -34,6 +34,11 @@
5 <annotation name="org.freedesktop.Accounts.DefaultValue" value="true"/>
6 </property>
7
8+ <!-- "Other vibrations" should cover all vibrations except for those relating to phone calls and messages -->
9+ <property name="OtherVibrate" type="b" access="readwrite">
10+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="true"/>
11+ </property>
12+
13 <property name="DialpadSoundsEnabled" type="b" access="readwrite">
14 <annotation name="org.freedesktop.Accounts.DefaultValue" value="true"/>
15 </property>
16
17=== modified file 'debian/changelog'
18--- debian/changelog 2014-09-12 18:52:08 +0000
19+++ debian/changelog 2015-01-06 14:24:04 +0000
20@@ -1,3 +1,10 @@
21+gsettings-ubuntu-touch-schemas (0.0.4) UNRELEASED; urgency=medium
22+
23+ [ Jonas G. Drange]
24+ * Added 'OtherVibrate' boolean settings to com.ubuntu.touch.AccountsService.Sound (LP: #1358610) (LP: #1391877)
25+
26+ -- Jonas G. Drange <jonas.drange@canonical.com> Tue, 06 Jan 2015 15:06:09 +0100
27+
28 gsettings-ubuntu-touch-schemas (0.0.3+14.10.20140912-0ubuntu1) utopic; urgency=low
29
30 [ Charles Kerr ]

Subscribers

People subscribed via source and target branches