Merge lp:~jonas-drange/gsettings-ubuntu-touch-schemas/hw-kbd into lp:gsettings-ubuntu-touch-schemas
Status: | Approved |
---|---|
Approved by: | Michael Terry |
Approved revision: | 63 |
Proposed branch: | lp:~jonas-drange/gsettings-ubuntu-touch-schemas/hw-kbd |
Merge into: | lp:gsettings-ubuntu-touch-schemas |
Diff against target: |
44 lines (+27/-0) 2 files modified
accountsservice/com.ubuntu.AccountsService.Input.xml (+20/-0) debian/changelog (+7/-0) |
To merge this branch: | bzr merge lp:~jonas-drange/gsettings-ubuntu-touch-schemas/hw-kbd |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Terry (community) | Approve | ||
Review via email: mp+284755@code.launchpad.net |
Commit message
Append hardware keyboard settings to com.ubuntu.
Description of the change
The list of properties comes from [1, 2] and is to be implemented as per the spec [3].
The rationale for appending these settings to the AS schema is the same as the rationale given in [4] — i.e. users with encrypted home would lose settings potentially crucial to accessibility (e.g. KeyboardDelay) if this was implemented in gsettings.
[1] https:/
[2] https:/
[3] https:/
[4] https:/
Unmerged revisions
- 63. By Jonas G. Drange
-
drop props not needed now, change i to unsigned and comment on units
- 62. By Jonas G. Drange
-
update changelog
- 61. By Jonas G. Drange
-
add hw keyboard settings
- CursorBlinkTime and CursorBlinkTimeout might be better typed as 'u'?
- And for both, you might want to mention the unit (milliseconds etc)
- What is CursorBlinkTimeout? Does the cursor stop blinking after a while? (maybe explain that slightly in the comment)
- I don't see InputSourcesShowAll and the CursorBlink options referenced in the LanguageAndText spec, but I trust you that they are needed.