Merge lp:~jonas-drange/gsettings-ubuntu-touch-schemas/hw-kbd into lp:gsettings-ubuntu-touch-schemas

[Jonas G. Drange]

Append hardware keyboard settings to com.ubuntu.AccountsService.Input schema

The list of properties comes from [1, 2] and is to be implemented as per the spec [3].

The rationale for appending these settings to the AS schema is the same as the rationale given in [4] — i.e. users with encrypted home would lose settings potentially crucial to accessibility (e.g. KeyboardDelay) if this was implemented in gsettings.

[1] https://github.com/GNOME/gsettings-desktop-schemas/blob/master/schemas/org.gnome.desktop.interface.gschema.xml.in
[2] https://github.com/GNOME/gsettings-desktop-schemas/blob/master/schemas/org.gnome.desktop.peripherals.gschema.xml.in
[3] https://wiki.ubuntu.com/LanguageAndText#phone
[4] https://code.launchpad.net/~mterry/gsettings-ubuntu-touch-schemas/input-schema/+merge/283546

[Michael Terry (mterry)]

- CursorBlinkTime and CursorBlinkTimeout might be better typed as 'u'?
- And for both, you might want to mention the unit (milliseconds etc)
- What is CursorBlinkTimeout? Does the cursor stop blinking after a while? (maybe explain that slightly in the comment)
- I don't see InputSourcesShowAll and the CursorBlink options referenced in the LanguageAndText spec, but I trust you that they are needed.

review: Needs Information

[lp:~jonas-drange/gsettings-ubuntu-touch-schemas/hw-kbd]

63. By Jonas G. Drange on 2016-02-03

drop props not needed now, change i to unsigned and comment on units

[Jonas G. Drange (jonas-drange)]

Thank Michael, I've removed the properties that weren't in the spec—let's add them when they're needed.

[Michael Terry (mterry)]

LGTM!

review: Approve

Unmerged revisions

63. By Jonas G. Drange on 2016-02-03

drop props not needed now, change i to unsigned and comment on units

62. By Jonas G. Drange on 2016-02-02

update changelog

61. By Jonas G. Drange on 2016-02-02

add hw keyboard settings

=== modified file 'accountsservice/com.ubuntu.AccountsService.Input.xml'
--- accountsservice/com.ubuntu.AccountsService.Input.xml	2016-01-21 16:36:40 +0000
+++ accountsservice/com.ubuntu.AccountsService.Input.xml	2016-02-03 13:16:16 +0000
@@ -62,5 +62,25 @@
             <annotation name="org.freedesktop.Accounts.DefaultValue" value="true"/>
         </property>
 
+        <!-- Use different input sources for each window -->
+        <property name="InputSourcesPerWindow" type="b" access="readwrite">
+            <annotation name="org.freedesktop.Accounts.DefaultValue" value="false"/>
+        </property>
+
+        <!-- Keyboard repeat -->
+        <property name="KeyboardRepeat" type="b" access="readwrite">
+            <annotation name="org.freedesktop.Accounts.DefaultValue" value="true"/>
+        </property>
+
+        <!-- Delay between repeats in milliseconds. -->
+        <property name="KeyboardRepeatInterval" type="u" access="readwrite">
+            <annotation name="org.freedesktop.Accounts.DefaultValue" value="30"/>
+        </property>
+
+        <!-- Initial key repeat delay in milliseconds. -->
+        <property name="KeyboardDelay" type="u" access="readwrite">
+            <annotation name="org.freedesktop.Accounts.DefaultValue" value="500"/>
+        </property>
+
     </interface>
 </node>

=== modified file 'debian/changelog'
--- debian/changelog	2016-01-28 18:28:36 +0000
+++ debian/changelog	2016-02-03 13:16:16 +0000
@@ -1,3 +1,10 @@
+gsettings-ubuntu-touch-schemas (0.0.6+16.04.20160202-0ubuntu1) UNRELEASED; urgency=medium
+
+  [ Jonas G. Drange ]
+  * Append hardware keyboard settings to com.ubuntu.AccountsService.Input schema
+
+ -- Jonas G. Drange <[e-mail]>  Tue, 2 Feb 2016 17:07:36 +0100
+
 gsettings-ubuntu-touch-schemas (0.0.5+16.04.20160128.1-0ubuntu1) xenial; urgency=medium
 
   [ Michael Terry ]