Merge lp:~jonas-drange/gsettings-ubuntu-touch-schemas/hw-kbd into lp:gsettings-ubuntu-touch-schemas

Proposed by Jonas G. Drange on 2016-02-02
Status: Approved
Approved by: Michael Terry on 2016-02-03
Approved revision: 63
Proposed branch: lp:~jonas-drange/gsettings-ubuntu-touch-schemas/hw-kbd
Merge into: lp:gsettings-ubuntu-touch-schemas
Diff against target: 44 lines (+27/-0)
2 files modified
accountsservice/com.ubuntu.AccountsService.Input.xml (+20/-0)
debian/changelog (+7/-0)
To merge this branch: bzr merge lp:~jonas-drange/gsettings-ubuntu-touch-schemas/hw-kbd
Reviewer Review Type Date Requested Status
Michael Terry (community) 2016-02-02 Approve on 2016-02-03
Review via email: mp+284755@code.launchpad.net

Commit message

Append hardware keyboard settings to com.ubuntu.AccountsService.Input schema

Description of the change

The list of properties comes from [1, 2] and is to be implemented as per the spec [3].

The rationale for appending these settings to the AS schema is the same as the rationale given in [4] — i.e. users with encrypted home would lose settings potentially crucial to accessibility (e.g. KeyboardDelay) if this was implemented in gsettings.

[1] https://github.com/GNOME/gsettings-desktop-schemas/blob/master/schemas/org.gnome.desktop.interface.gschema.xml.in
[2] https://github.com/GNOME/gsettings-desktop-schemas/blob/master/schemas/org.gnome.desktop.peripherals.gschema.xml.in
[3] https://wiki.ubuntu.com/LanguageAndText#phone
[4] https://code.launchpad.net/~mterry/gsettings-ubuntu-touch-schemas/input-schema/+merge/283546

To post a comment you must log in.
Michael Terry (mterry) wrote :

- CursorBlinkTime and CursorBlinkTimeout might be better typed as 'u'?
- And for both, you might want to mention the unit (milliseconds etc)
- What is CursorBlinkTimeout? Does the cursor stop blinking after a while? (maybe explain that slightly in the comment)
- I don't see InputSourcesShowAll and the CursorBlink options referenced in the LanguageAndText spec, but I trust you that they are needed.

review: Needs Information
63. By Jonas G. Drange on 2016-02-03

drop props not needed now, change i to unsigned and comment on units

Jonas G. Drange (jonas-drange) wrote :

Thank Michael, I've removed the properties that weren't in the spec—let's add them when they're needed.

Michael Terry (mterry) wrote :

LGTM!

review: Approve

Unmerged revisions

63. By Jonas G. Drange on 2016-02-03

drop props not needed now, change i to unsigned and comment on units

62. By Jonas G. Drange on 2016-02-02

update changelog

61. By Jonas G. Drange on 2016-02-02

add hw keyboard settings

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'accountsservice/com.ubuntu.AccountsService.Input.xml'
2--- accountsservice/com.ubuntu.AccountsService.Input.xml 2016-01-21 16:36:40 +0000
3+++ accountsservice/com.ubuntu.AccountsService.Input.xml 2016-02-03 13:16:16 +0000
4@@ -62,5 +62,25 @@
5 <annotation name="org.freedesktop.Accounts.DefaultValue" value="true"/>
6 </property>
7
8+ <!-- Use different input sources for each window -->
9+ <property name="InputSourcesPerWindow" type="b" access="readwrite">
10+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="false"/>
11+ </property>
12+
13+ <!-- Keyboard repeat -->
14+ <property name="KeyboardRepeat" type="b" access="readwrite">
15+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="true"/>
16+ </property>
17+
18+ <!-- Delay between repeats in milliseconds. -->
19+ <property name="KeyboardRepeatInterval" type="u" access="readwrite">
20+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="30"/>
21+ </property>
22+
23+ <!-- Initial key repeat delay in milliseconds. -->
24+ <property name="KeyboardDelay" type="u" access="readwrite">
25+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="500"/>
26+ </property>
27+
28 </interface>
29 </node>
30
31=== modified file 'debian/changelog'
32--- debian/changelog 2016-01-28 18:28:36 +0000
33+++ debian/changelog 2016-02-03 13:16:16 +0000
34@@ -1,3 +1,10 @@
35+gsettings-ubuntu-touch-schemas (0.0.6+16.04.20160202-0ubuntu1) UNRELEASED; urgency=medium
36+
37+ [ Jonas G. Drange ]
38+ * Append hardware keyboard settings to com.ubuntu.AccountsService.Input schema
39+
40+ -- Jonas G. Drange <jonas.drange@canonical.com> Tue, 2 Feb 2016 17:07:36 +0100
41+
42 gsettings-ubuntu-touch-schemas (0.0.5+16.04.20160128.1-0ubuntu1) xenial; urgency=medium
43
44 [ Michael Terry ]

Subscribers

People subscribed via source and target branches