Merge lp:~jonas-drange/gsettings-ubuntu-touch-schemas/fingerprint into lp:gsettings-ubuntu-touch-schemas

Proposed by Jonas G. Drange
Status: Merged
Approved by: Ken VanDine
Approved revision: 71
Merged at revision: 67
Proposed branch: lp:~jonas-drange/gsettings-ubuntu-touch-schemas/fingerprint
Merge into: lp:gsettings-ubuntu-touch-schemas
Diff against target: 54 lines (+18/-1)
3 files modified
accountsservice/com.ubuntu.AccountsService.SecurityPrivacy.xml (+4/-0)
debian/changelog (+9/-1)
schemas/com.ubuntu.touch.system.gschema.xml.in.in (+5/-0)
To merge this branch: bzr merge lp:~jonas-drange/gsettings-ubuntu-touch-schemas/fingerprint
Reviewer Review Type Date Requested Status
Michael Terry (community) Approve
Review via email: mp+290451@code.launchpad.net

Commit message

allow the user to enable/disable fingerprint auth

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

You probably want to bump the version so that any package that uses this property can version their dependency.

Revision history for this message
Michael Terry (mterry) wrote :

UGH. You did and I just totally missed that part of the diff. :P

Revision history for this message
Michael Terry (mterry) wrote :

Trunk is up to 0.0.6. This needs to bump to 0.0.7

review: Needs Fixing
68. By Jonas G. Drange

sync with trunk

69. By Jonas G. Drange

bump version due to newer upstream

70. By Jonas G. Drange

add fingerprint name map

Revision history for this message
Michael Terry (mterry) wrote :

Seems good.

review: Approve
Revision history for this message
Robert Bruce Park (robru) wrote :

Extreme nitpick inline

71. By Jonas G. Drange

remove brackets

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'accountsservice/com.ubuntu.AccountsService.SecurityPrivacy.xml'
2--- accountsservice/com.ubuntu.AccountsService.SecurityPrivacy.xml 2014-08-19 15:20:41 +0000
3+++ accountsservice/com.ubuntu.AccountsService.SecurityPrivacy.xml 2016-06-15 12:12:18 +0000
4@@ -12,6 +12,10 @@
5 <annotation name="org.freedesktop.Accounts.DefaultValue" value="0"/>
6 </property>
7
8+ <property name="EnableFingerprintIdentification" type="b" access="readwrite">
9+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="false"/>
10+ </property>
11+
12 <property name="EnableLauncherWhileLocked" type="b" access="readwrite">
13 <annotation name="org.freedesktop.Accounts.DefaultValue" value="true"/>
14 </property>
15
16=== modified file 'debian/changelog'
17--- debian/changelog 2016-04-14 13:09:42 +0000
18+++ debian/changelog 2016-06-15 12:12:18 +0000
19@@ -1,3 +1,11 @@
20+gsettings-ubuntu-touch-schemas (0.0.7+16.04.20160609-0ubuntu1) UNRELEASED; urgency=medium
21+
22+ Jonas G. Drange
23+ * Add EnableFingerprintIdentification to security accounts-service schema
24+ * Add fingerprint-names to system gsettings schema
25+
26+ -- Jonas G. Drange <jonas.drange@canonical.com> Wed, 14 June 2016 11:58:29 +0200
27+
28 gsettings-ubuntu-touch-schemas (0.0.6+16.04.20160414-0ubuntu1) xenial; urgency=medium
29
30 [ Michael Terry ]
31@@ -206,7 +214,7 @@
32
33 gsettings-ubuntu-touch-schemas (0.0.1+13.10.20130730-0ubuntu2) saucy; urgency=low
34
35- * Change the default sounds for calls and messages, depends on
36+ * Change the default sounds for calls and messages, depends on
37 ubuntu-touch-sounds so we are sure users get the files with the defaults
38
39 -- Sebastien Bacher <seb128@ubuntu.com> Mon, 14 Oct 2013 16:36:03 +0200
40
41=== modified file 'schemas/com.ubuntu.touch.system.gschema.xml.in.in'
42--- schemas/com.ubuntu.touch.system.gschema.xml.in.in 2014-09-11 18:21:55 +0000
43+++ schemas/com.ubuntu.touch.system.gschema.xml.in.in 2016-06-15 12:12:18 +0000
44@@ -53,5 +53,10 @@
45 <default>45</default>
46 <summary>Timeout in seconds for dimming the screen if there is no user activity. A value of 0 disables auto-dimming.</summary>
47 </key>
48+ <key name="fingerprint-names" type="a{ss}">
49+ <_summary>Fingerprint names</_summary>
50+ <default>{}</default>
51+ <_description>Mapping of unique fingerprint ids to names set by the user.</_description>
52+ </key>
53 </schema>
54 </schemalist>

Subscribers

People subscribed via source and target branches