Code review comment for lp:~jon-hill/spud/mac_port

Revision history for this message
Jon Hill (jon-hill) wrote :

a) Done

b) Done

c) Oops!

d) This is tricky: If the SVG is first, it get's picked up and then fails on loading (later on in diamond), but if we put the png first, that will get used, rather than the nice vector graphic. I can't remember if an error is raised that we can trap and hence try a png instead or if it just falls over. A hard code might be the only way to solve this.

e) There was a reason - I can't remember it now. It might not be necessary anymore.

f) Done

g) That should be OK. Will try it.

I've also used the environment variable to pick up the schema files etc - this might be nicer way to do things.

« Back to merge proposal