Merge ~johnsca/juju-wait:bug/retry-config into juju-wait:master
Proposed by
Cory Johns
on 2017-07-12
| Status: | Merged |
|---|---|
| Merged at revision: | 54eaa50674b6d38536f42634231a552c55d99263 |
| Proposed branch: | ~johnsca/juju-wait:bug/retry-config |
| Merge into: | juju-wait:master |
| Diff against target: |
13 lines (+2/-1) 1 file modified
juju_wait/__init__.py (+2/-1) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Stuart Bishop | 2017-07-12 | Approve on 2017-07-13 | |
|
Review via email:
|
|||
Description of the Change
The model config was not being read properly because of a trailing newline.
To post a comment you must log in.
| Stuart Bishop (stub) wrote : | # |
This sort of bug is why it is preferable to decode yaml or json. But this seems fine for now.
review:
Approve

It's attempting to run juju model-config before the version check, and that will fail with Juju 1.x