Merge lp:~johnsca/charms/trusty/apache-hadoop-hdfs-secondary/etc-hosts-refactor into lp:~bigdata-dev/charms/trusty/apache-hadoop-hdfs-secondary/trunk

Proposed by Cory Johns
Status: Merged
Merged at revision: 65
Proposed branch: lp:~johnsca/charms/trusty/apache-hadoop-hdfs-secondary/etc-hosts-refactor
Merge into: lp:~bigdata-dev/charms/trusty/apache-hadoop-hdfs-secondary/trunk
Diff against target: 29 lines (+6/-1) (has conflicts)
2 files modified
hooks/common.py (+2/-1)
resources.yaml (+4/-0)
Text conflict in resources.yaml
To merge this branch: bzr merge lp:~johnsca/charms/trusty/apache-hadoop-hdfs-secondary/etc-hosts-refactor
Reviewer Review Type Date Requested Status
Kevin W Monroe Approve
Review via email: mp+262464@code.launchpad.net

Description of the change

Use refactored /etc/hosts management

To post a comment you must log in.
Revision history for this message
Kevin W Monroe (kwmonroe) wrote :

lgtm, especially the bzr artifacts. merged.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/common.py'
2--- hooks/common.py 2015-05-12 21:52:31 +0000
3+++ hooks/common.py 2015-06-19 15:38:53 +0000
4@@ -67,7 +67,8 @@
5 namenode_master,
6 ],
7 'callbacks': [
8- namenode_master.update_etc_hosts,
9+ namenode_master.register_provided_hosts,
10+ jujubigdata.utils.manage_etc_hosts,
11 namenode_master.install_ssh_keys,
12 hdfs.configure_secondarynamenode,
13 hdfs.start_secondarynamenode,
14
15=== modified file 'resources.yaml'
16--- resources.yaml 2015-06-10 21:51:52 +0000
17+++ resources.yaml 2015-06-19 15:38:53 +0000
18@@ -8,7 +8,11 @@
19 six:
20 pypi: six
21 jujubigdata:
22+<<<<<<< TREE
23 pypi: jujubigdata>=1.2.10,<2.0.0
24+=======
25+ pypi: jujubigdata>=2.0.0,<3.0.0
26+>>>>>>> MERGE-SOURCE
27 charmhelpers:
28 pypi: http://bazaar.launchpad.net/~bigdata-dev/bigdata-data/trunk/download/kevin.monroe%40canonical.com-20150610215108-gq4ud2rriy1sp1h6/charmhelpers0.3.1.ta-20150610215050-vxrqhizdsrqwnmcm-1/charmhelpers-0.3.1.tar.gz
29 hash: 061fe7204289b96fab5d3ca02883040ea3026526ebf0ad38e21457527a18d139

Subscribers

People subscribed via source and target branches