Charm Helpers

Merge lp:~johnsca/charm-helpers/python3 into lp:charm-helpers

  1. python3
  2. Merge into devel
Proposed by Cory Johns on 2015-12-07
Status: Merged
Merged at revision: 494
Proposed branch: lp:~johnsca/charm-helpers/python3
Merge into: lp:charm-helpers
Diff against target: 14 lines (+0/-4)
1 file modified
charmhelpers/fetch/giturl.py (+0/-4)
To merge this branch: bzr merge lp:~johnsca/charm-helpers/python3
Reviewer Review Type Date Requested Status
Stuart Bishop 2015-12-07 Approve on 2015-12-08
Review via email: mp+279817@code.launchpad.net

Description of the Change

GitPython has supported Python 3 for just over a year.

https://github.com/gitpython-developers/GitPython/issues/114
https://github.com/gitpython-developers/gitdb/issues/4

To post a comment you must log in.
Stuart Bishop (stub) wrote :

Oh, cool.

I will land this, along with a change to the test dependencies and with the git tests enabled under Python3.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'charmhelpers/fetch/giturl.py'
2--- charmhelpers/fetch/giturl.py 2015-07-09 19:56:05 +0000
3+++ charmhelpers/fetch/giturl.py 2015-12-07 20:50:12 +0000
4@@ -21,10 +21,6 @@
5 )
6 from charmhelpers.core.host import mkdir
7
8-import six
9-if six.PY3:
10- raise ImportError('GitPython does not support Python 3')
11-
12 try:
13 from git import Repo
14 except ImportError:

Subscribers

People subscribed via source and target branches