KiCad

~john-j-beard/kicad:tidy_ups

  1. Git
  2. lp:~john-j-beard/kicad
  3. tidy_ups
Last commit made on 2017-03-22
Get this branch:
git clone -b tidy_ups https://git.launchpad.net/~john-j-beard/kicad
Only John Beard can upload to this branch. If you are John Beard please log in for upload directions.

Branch merges

Branch information

Name:
tidy_ups
Repository:
lp:~john-j-beard/kicad

Recent commits

f9b3121... by John Beard

Use smart pointer for ownership of GetNewConfig

This was previously done by a raw pointer, which made ownership of the
object prone to failure. It is now done by smart pointer, so the object
cannot be accidentally leaked.

The object was in fact leaked in one of the cases, in the constructor
of PCB_CALCULATOR_FRAME.

423f7d6... by John Beard

Move NAMELESS_PROJECT to directory_utils.h

Only 5 files need this constant, so put it with the
directory/config utils.

Also make it a proper wxString rather than a #define

bed3a21... by John Beard

Move ProcessExecute to its own header

This function is only used in 4 places, it doesn't need to be in
common.h

edfe769... by John Beard

Remove reference to InitKiCadAbout in kicad.i SWIG file

This function was removed in 2010, it no longer needs to be ignored.

41a8829... by John Beard

Remove unused GetCommandOptions function

e1dbcd2... by John Beard

Remove unused g_ShowPageLimits global variable

This variable was only defined, not declared in any header.

30f42d7... by John Beard

Move some unit related util function to base_units.h

aab0488... by John Beard

Remove unused PrePendPath function

c773893... by John Beard

Move directory/path/env var utils to own headers

These functions, previously in common.h, are only used in about 20 files
in the whole of kicad in total, which means they don't really need to be
in common.h and visible to every single translation unit.

This commit introduces:

* directory_utils.h for generic directory and config path utils
* help_file_utils.h for utilities to do with the help file stack
* env_var_utils.h for utilities to do with environment variables

968c750... by John Beard

Move executable name constants to own file

The executable name constants are only used by two files, they do not
have to be in common.h.

Also converted to const wxString for better type-safety and removed
old-style wxT macros.