Merge lp:~joey/linaro-wordpress-registration-form/lce12updatesv2 into lp:linaro-wordpress-registration-form

Proposed by Joey Stanford
Status: Merged
Approved by: James Tunnicliffe
Approved revision: 64
Merged at revision: 63
Proposed branch: lp:~joey/linaro-wordpress-registration-form/lce12updatesv2
Merge into: lp:linaro-wordpress-registration-form
Diff against target: 192 lines (+32/-69)
1 file modified
linaro_connect.php (+32/-69)
To merge this branch: bzr merge lp:~joey/linaro-wordpress-registration-form/lce12updatesv2
Reviewer Review Type Date Requested Status
James Tunnicliffe (community) Approve
Данило Шеган Pending
Review via email: mp+118600@code.launchpad.net

Description of the change

Several changes requested by Arwen to customize the form. Mostly textual changes but there are some form changes around travel details.

To post a comment you must log in.
Revision history for this message
James Tunnicliffe (dooferlad) wrote :

Looks fine to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'linaro_connect.php'
2--- linaro_connect.php 2012-08-02 15:44:09 +0000
3+++ linaro_connect.php 2012-08-07 17:08:23 +0000
4@@ -17,7 +17,7 @@
5
6 Greetings from Linaro Connect!
7
8-Congratulations on registering LCE12 at the Bella Center, Copenhagen,
9+Congratulations on registering for LCE12 at the Bella Center, Copenhagen,
10 - where you can expect another great week of planning,
11 discussing and hacking the future of Linux on ARM.
12
13@@ -208,7 +208,7 @@
14 " JOIN wp_em_locations ".
15 " ON wp_em_events.location_id = wp_em_locations.location_id ".
16 " WHERE event_end_date >= CURRENT_DATE AND ".
17- " event_name LIKE \"%Linaro Connect%\" ".
18+ " event_name LIKE \"%lce12%\" ".
19 " ORDER BY event_end_date LIMIT 1");
20 }
21
22@@ -223,7 +223,7 @@
23 " ON wp_em_events.location_id = wp_em_locations.location_id ".
24 " JOIN wp_connect_attendees ".
25 " ON wp_em_events.event_id = wp_connect_attendees.event_id ".
26- " WHERE event_name LIKE \"%Linaro Connect%\" AND ".
27+ " WHERE event_name LIKE \"%lce12%\" AND ".
28 " wp_em_events.event_id != $current_id ".
29 " HAVING COUNT(wp_connect_attendees.user_id) > 0 ".
30 " ORDER BY event_end_date DESC");
31@@ -346,9 +346,11 @@
32 $destination_country = $countries[$event->location_country];
33
34 return <<<EOT
35- <div><label for="visa_status">Do you need a new visa to enter $destination_country?*</label></div>
36+ <div><label for="visa_status">Visa: Business invitation letter *</label></div>
37 <div>{$visa}</div>
38-
39+ <div>
40+ <p>(Do you require an invitation letter to apply for a travel visa?).</p>
41+ </div>
42 <div id="visa_details" class="section {$css_class}">
43 <div>
44 It is essential you make sure the following information is precise and
45@@ -401,58 +403,20 @@
46 static function getTravelFields($data) {
47 return <<<EOT
48 <div id="travel_details">
49- <div><label>Arrival &amp; Departure Details:*</label></div>
50- <table>
51- <thead><tr>
52- <th><label for="flight_arrival">Arrival flight number</label></th>
53- <th><label for="check_in">Date</label></th>
54- <th><label for="check_in_time">Approx time (HH:MM)</label></th>
55- </thead></tr>
56- <tr>
57- <td><input name="flight_arrival" type="text" id="flight_arrival"
58- value="{$data[flight_arrival]}" /></td>
59- <td><input name="check_in" type="text" id="check_in"
60- value="{$data[check_in]}" class="date"/></td>
61- <td><input name="check_in_time" type="text" id="check_in_time"
62- value="{$data[check_in_time]}" class="time"/></td>
63- </tr>
64- <thead><tr>
65- <th><label for="flight_departure">Departure flight number</label></th>
66- <th><label for="check_out">Date</label></th>
67- <th><label for="check_out_time">Approx time (HH:MM)</label></th>
68- </thead></tr>
69- <tr>
70- <td><input name="flight_departure" type="text" id="flight_departure"
71- value="{$data[flight_departure]}" /></td>
72- <td><input name="check_out" type="text" id="check_out"
73- value="{$data[check_out]}" class="date"/></td>
74- <td><input name="check_out_time" type="text" id="check_out_time"
75- value="{$data[check_out_time]}" class="time"/></td>
76- </tr>
77- </table>
78- <div><label>Conference Attendance Details:*</label></div>
79- <table>
80- <thead><tr>
81- <th><label for="attendance_from_date">Start Date</label></th>
82- <th><label for="attendance_from_time">Time</label></th>
83- <th><label for="attendance_to_date">End Date</label></th>
84- <th><label for="attendance_to_time">Time</label></th>
85- </thead></tr>
86- <tr>
87- <td><input name="attendance_from_date" type="text"
88- id="attendance_from_date"
89- value="{$data[attendance_from_date]}" class="date"/></td>
90- <td><input name="attendance_from_time" type="text"
91- id="attendance_from_time"
92- value="{$data[attendance_from_time]}" class="time"/></td>
93- <td><input name="attendance_to_date" type="text"
94- id="attendance_to_date"
95- value="{$data[attendance_to_date]}" class="date"/></td>
96- <td><input name="attendance_to_time" type="text"
97- id="attendance_to_time"
98- value="{$data[attendance_to_time]}" class="time"/></td>
99- </tr>
100- </table>
101+ <div><label>Conference attendance arrival date *</label></div>
102+ <div><p>Mon 29 Oct - Fri 2 Nov</p></div>
103+ <div>
104+ <input name="attendance_from_date" type="text"
105+ id="attendance_from_date"
106+ value="{$data[attendance_from_date]}" class="date"/>
107+ </div>
108+ <div><label for="visa_passport_expiry">Conference attendance departure date *</label></div>
109+ <div><p>Mon 29 Oct - Fri 2 Nov</p></div>
110+ <div>
111+ <input name="attendance_to_date" type="text"
112+ id="attendance_to_date"
113+ value="{$data[attendance_to_date]}" class="date"/>
114+ </div>
115 </div>
116 EOT;
117 }
118@@ -577,8 +541,8 @@
119 important you complete registration as soon as possible as these details
120 help Linaro organise a successful event.</p>
121
122- <p>When you are ready to complete your registration, click the Register
123- Now button on the <a href=\"http://connect.linaro.org/\">LCE12
124+ <p>When you are ready to complete your registration, click the Register Now
125+ button on the <a href=\"http://connect.linaro.org/\">LCE12
126 website</a>.</p>";
127 self::emailSaved($registration, $user, $event);
128 return str_replace(self::form_tag, $warn, $text);
129@@ -628,7 +592,7 @@
130 <div><label for="first_name">First name:*</label></div>
131 <div><input name="first_name" type="text" id="first_name"
132 value="{$data[first_name]}" /></div>
133- <div><label for="last_name">Last name:*</label></div>
134+ <div><label for="last_name">Family name:*</label></div>
135 <div><input name="last_name" type="text" id="last_name"
136 value="{$data[last_name]}" /></div>
137 <div><label for="email">Email:*</label></div>
138@@ -638,13 +602,13 @@
139 <p>This email will be used to provide event details.
140 We will not pass your email on to any third parties.</p>
141 </div>
142- <div><label for="lp_name">Launchpad user name:*</label></div>
143+ <div><label for="lp_name">Launchpad ID:*</label></div>
144 <div><input name="lp_name" type="text" id="lp_name" readonly="readonly"
145 value="{$data[lp_name]}" disabled="disabled"/></div>
146 <div><label for="irc_name">IRC Nickname:*</label></div>
147 <div><input name="irc_name" type="text" id="irc_nickname"
148 value="{$data[irc_name]}"/></div>
149- <div><label for="phone">Phone:</label></div>
150+ <div><label for="phone">MObile Phone Number:</label></div>
151 <div><input name="phone" type="text" id="phone"
152 value="{$data[phone]}" /></div>
153 <div><label for="company_select">Company:*</label></div>
154@@ -655,18 +619,18 @@
155 <div><label for="job_title">Job Title:*</label></div>
156 <div><input name="job_title" type="text" id="job_title"
157 value="{$data[job_title]}" /></div>
158- <div><label for="linaro_team">Linaro Engineering team:*</label></div>
159+ <div><label for="linaro_team">Linaro team:*</label></div>
160 <div>{$team}</div>
161- <div><label for="attendance_type">Attending:*</label></div>
162+ <div><label for="attendance_type">Attendance type:*</label></div>
163 <div>{$attendance}</div>
164 <div id="attendance_details" class="{$attendance_css_class}">
165- <div><label for="dietary">Dietary requirements:</label></div>
166+ <div><label for="dietary">Special dietary requirements:</label></div>
167 <div><input name="dietary" type="text" id="dietary"
168 value="{$data[dietary]}" /></div>
169 {$visa}
170 {$travel}
171 </div>
172- <div><label for="comments">Comments:</label></div>
173+ <div><label for="comments">Additional comments:</label></div>
174 <div>
175 <textarea name="comments" id="comments">{$data[comments]}</textarea>
176 </div>
177@@ -774,13 +738,12 @@
178
179 /* Ensures required fields are present. */
180 static function validateRequiredData($values) {
181- $required = array('first_name', 'last_name', 'irc_name', 'email', 'company',
182+ $required = array('first_name', 'last_name', 'irc_name', 'email', 'phone', 'company',
183 'linaro_team', 'attendance_type', 'visa_status', 'job_title');
184 $visa_required = array('visa_country', 'visa_address', 'visa_embassy_address',
185 'visa_travel_start', 'visa_travel_end',
186 'visa_passport_number', 'visa_passport_expiry');
187- $attending_required = array('check_in', 'check_in_time',
188- 'check_out', 'check_out_time');
189+ $attending_required = array();
190 $missing = array();
191 foreach ($required as $key) {
192 if (!isset($values[$key]) or trim($values[$key])==='' or $values[$key]===NULL) {

Subscribers

People subscribed via source and target branches